From: Igor Zamyatin <izamyatin@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] DATA_ALIGNMENT vs. DATA_ABI_ALIGNMENT (PR target/56564)
Date: Wed, 19 Jun 2013 07:12:00 -0000 [thread overview]
Message-ID: <CAKdSQZkifGa2u=54MxTmBPX5xcRK3Xna=61h4RRP_aT3ASrLMw@mail.gmail.com> (raw)
Right, as you did for other cases. It works here as well.
Thanks,
Igor
On Wed, Jun 19, 2013 at 11:05 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Jun 19, 2013 at 11:01:59AM +0400, Igor Zamyatin wrote:
>> The change also affects vectorizer in avx case which could be seen for
>> gcc.dg/tree-ssa/loop-19.c test.
>>
>> After the change report says
>>
>> loop-19_bad.c:16: note: === vect_analyze_data_refs_alignment ===
>> loop-19_bad.c:16: note: vect_compute_data_ref_alignment:
>> loop-19_bad.c:16: note: can't force alignment of ref: a[j_9]
>> loop-19_bad.c:16: note: vect_compute_data_ref_alignment:
>> loop-19_bad.c:16: note: can't force alignment of ref: c[j_9]
>>
>> AFAICS first condition in ix86_data_alignment was true before the
>> change so 256 was a return value.
>>
>> Do we need to tweak this test also?
>
> I'd add -fno-common to the test.
>
> Jakub
next reply other threads:[~2013-06-19 7:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 7:12 Igor Zamyatin [this message]
2013-06-19 7:22 ` Jakub Jelinek
2013-06-19 8:38 ` Richard Biener
2013-06-19 8:44 ` Jakub Jelinek
2013-06-19 16:32 ` Mike Stump
2013-06-19 16:25 ` Mike Stump
2013-06-19 19:27 ` Kirill Yukhin
-- strict thread matches above, loose matches on Subject: below --
2013-06-07 19:26 Jakub Jelinek
2013-06-07 20:43 ` Richard Henderson
2013-06-07 21:14 ` Jakub Jelinek
2013-06-08 15:13 ` Jakub Jelinek
2013-06-10 14:52 ` Richard Henderson
2013-06-10 15:45 ` Jakub Jelinek
2013-06-10 19:44 ` David Edelsohn
2013-06-11 0:44 ` DJ Delorie
2013-06-11 6:06 ` Jakub Jelinek
2013-06-11 15:20 ` DJ Delorie
2013-06-07 22:56 ` Hans-Peter Nilsson
2013-06-08 15:05 ` Jakub Jelinek
2013-06-10 10:51 ` Bernd Schmidt
2013-06-10 10:56 ` Jakub Jelinek
2013-06-10 11:03 ` Bernd Schmidt
2013-06-10 11:52 ` Ulrich Weigand
2013-06-12 17:52 ` Edmar Wienskoski
2013-06-13 7:41 ` Alan Modra
2013-06-13 15:37 ` Alan Modra
2013-06-13 15:42 ` Jakub Jelinek
2013-06-13 22:48 ` Alan Modra
2013-06-14 9:00 ` Jakub Jelinek
2013-06-14 10:42 ` Alan Modra
2013-06-14 10:54 ` Jakub Jelinek
2013-06-14 14:57 ` Alan Modra
2013-06-17 23:37 ` David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKdSQZkifGa2u=54MxTmBPX5xcRK3Xna=61h4RRP_aT3ASrLMw@mail.gmail.com' \
--to=izamyatin@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).