From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by sourceware.org (Postfix) with ESMTPS id EB07039C3837 for ; Thu, 5 Nov 2020 12:03:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EB07039C3837 Received: by mail-oi1-x244.google.com with SMTP id m17so1414148oie.4 for ; Thu, 05 Nov 2020 04:03:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hZhk3ccx2x34eID1m1jmihQXE/voHaoKrQmwMMbkdNw=; b=dOJS8280T6bnuncdocUX3UnAC8SUJ6YMKGF1W4WdYzK3q1fGFVEAkxtwfWDK8h+wXB QIdx562gs2mSJrpVkRfP8p7s4WaQrUqaxyiP+4mienSrjD3HBQevbmw42c6l+OxdbotK z9MGFqaLUcSoxcPmW+Z2nzSAgYgWpQsPCZf/ET2JbUtkuv+u4FUWFIMhj3IMJQQnWqOn CmJ6w/bfQW9qid9d98TZNZqbGtjQRpbUrH35L4w5g6+3pC8yKqQQGkEyeLLj+GzASoHh fB+fzhys244k75eAqcPtg954FBGoyHrnuOzmgv9tamrr/2PoVIJCFkxdyq5isIwIAyDh t4bQ== X-Gm-Message-State: AOAM5317V1fchM4Y62xF5EWFGxfvxY8geK3RQrDeY8Cnn5xztzAYTOTL RKn1FDJd5cuJL0EqRibb104cWmMJZgn7amndh7OgOQ== X-Google-Smtp-Source: ABdhPJwyr3hBdkyjT7/7E2MOobyYCaSDjDZUjBg1QmRh3CwIIv53s0k9Nd8lwbH6t4aWZ6aDGDzvsRP2IcOvkrZY+Wo= X-Received: by 2002:aca:ea54:: with SMTP id i81mr1268101oih.48.1604577800297; Thu, 05 Nov 2020 04:03:20 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Christophe Lyon Date: Thu, 5 Nov 2020 13:03:09 +0100 Message-ID: Subject: Re: [PATCH] arm: [testcase] Better narrow some bfloat16 testcase To: Andrea Corallo Cc: Kyrylo Tkachov , "gcc-patches@gcc.gnu.org" , Richard Earnshaw , nd Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Nov 2020 12:03:22 -0000 On Thu, 5 Nov 2020 at 12:11, Andrea Corallo wrote: > > Christophe Lyon writes: > > [...] > > >> I think you need to add -mfloat-abi=hard to the dg-additional-options > >> otherwise vld1_lane_bf16_1.c > >> fails on targets with a soft float-abi default (eg arm-linux-gnueabi). > >> > >> See bf16_vldn_1.c. > > > > Actually that's not sufficient because in turn we get: > > /sysroot-arm-none-linux-gnueabi/usr/include/gnu/stubs.h:10:11: fatal > > error: gnu/stubs-hard.h: No such file or directory > > > > So you should check that -mfloat-abi=hard is supported. > > > > Ditto for the vst tests. > > Hi Christophe, > > this patch should implement your suggestions. > > On my arm-none-linux-gnueabi setup the tests were already skipped > as unsupported so if you could test and confirm this fixes the > issue you see would be great. Do you know why they are unsupported in your setup? > diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp > index 15f0649f8ae..2ab7e39756d 100644 > --- a/gcc/testsuite/lib/target-supports.exp > +++ b/gcc/testsuite/lib/target-supports.exp > @@ -5213,6 +5213,10 @@ proc check_effective_target_arm_v8_2a_bf16_neon_ok_nocache { } { > return 0; > } > > + if { ! [check_effective_target_arm_hard_ok] } { > + return 0; > + } > + > foreach flags {"" "-mfloat-abi=hard -mfpu=neon-fp-armv8" "-mfloat-abi=softfp -mfpu=neon-fp-armv8" } { > if { [check_no_compiler_messages_nocache arm_v8_2a_bf16_neon_ok object { > #include This seems strange since you would now exit early if check_effective_target_arm_hard_ok is false, so you'll never need the -mfloat-abi=softfp version of the flags. BTW in general, I think softfp is tried before hard in the other similar effective targets, any reason the order is different here? Christophe > > Thanks! > > Andrea >