From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47804 invoked by alias); 28 Aug 2015 08:08:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 47788 invoked by uid 89); 28 Aug 2015 08:08:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f49.google.com Received: from mail-qg0-f49.google.com (HELO mail-qg0-f49.google.com) (209.85.192.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 28 Aug 2015 08:08:38 +0000 Received: by qgj62 with SMTP id 62so25175818qgj.2 for ; Fri, 28 Aug 2015 01:08:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=QkoZwvcUKWipPWAnyRxZQ6wxezH8K9DJHTgQLvTl5+k=; b=Xa0CVOUsAfMAfeEDsAYV5OxaATyBF7QVWpKSUyCs+sNYoPR0UadwWLK8A86tvzlhsv 3N6H7pNnBJosQ08XlPWt9aJdERHUnN11UvULitw8uj9SAtoARCAL3iLrdiDx6kZIALd5 3FCCjDqwm7ajuW1rbF1FJUiGvoFEbApBs6TV/qOeiXY2R5WP81bHT3dx6fAls98BkKvU RFx4tSVIfL+BL+7y+icoxeI+Bvvwlgd6KnFsortiNedgPOnGDNh2rTGXZdBHfzhgga8u N1WpJR6dnkuApO9x4/6B0RjqXWf/+BHqBOmjJROws5Ho8JvmZq5bNuE3yZChEgBMrJXO 77Sw== X-Gm-Message-State: ALoCoQkJoyhYu6yK/u5HyhRWAJX0X0c0CkjpWPWRY8gN7rXkePAt71JclWqo8DF9E+yIJfDKlDsC MIME-Version: 1.0 X-Received: by 10.140.235.204 with SMTP id g195mr13466459qhc.35.1440749315960; Fri, 28 Aug 2015 01:08:35 -0700 (PDT) Received: by 10.140.96.226 with HTTP; Fri, 28 Aug 2015 01:08:35 -0700 (PDT) In-Reply-To: References: <20150825214232.GB12831@virgil.suse.cz> <1440690217-24461-1-git-send-email-alan.lawrence@arm.com> Date: Fri, 28 Aug 2015 08:16:00 -0000 Message-ID: Subject: Re: [PATCH 2/5] completely_scalarize arrays as well as records From: Christophe Lyon To: Richard Biener Cc: Alan Lawrence , martin.jambor@suse.cz, "gcc-patches@gcc.gnu.org" , Jeff Law Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg01770.txt.bz2 On 28 August 2015 at 09:48, Richard Biener wrote: > On Fri, 28 Aug 2015, Christophe Lyon wrote: > >> On 27 August 2015 at 17:43, Alan Lawrence wrote: >> > Martin Jambor wrote: >> >> >> >> First, I would be much >> >> happier if you added a proper comment to scalarize_elem function which >> >> you forgot completely. The name is not very descriptive and it has >> >> quite few parameters too. >> >> >> >> Second, this patch should also fix PR 67283. It would be great if you >> >> could verify that and add it to the changelog when committing if that >> >> is indeed the case. >> > >> > Thanks for pointing both of those out. I've added a comment to scalarize_elem, >> > deleted the bogus comment in the new test, and yes I can confirm that the patch >> > fixes PR 67283 on x86_64, and also AArch64 if >> > --param sra-max-scalarization-size-Ospeed is passed. (I've not added any >> > testcase specifically taken from that PR, however.) >> > >> > Pushed as r277265. >> >> Actually, is r227265. >> >> Since since commit I've noticed that >> g++.dg/torture/pr64312.C >> fails at -O1 in my config, saying "virtual memory exhaustion" (arm* targets) >> I run my validations under ulimit -v 10GB, which seems already large enough. >> >> Do we consider this a bug? > > Sure we do. You have to investigate this (I guess we run into some > endless looping/recursing that eats memory somewhere). > I asked because I assumed that Alan saw it pass in his configuration. > Richard.