From: Christophe Lyon <christophe.lyon@linaro.org>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc Patches <gcc-patches@gcc.gnu.org>,
danglin@gcc.gnu.org, sandra@gcc.gnu.org
Subject: Re: [PATCH] PR libstdc++/78179 run long double tests separately
Date: Wed, 19 Sep 2018 21:13:00 -0000 [thread overview]
Message-ID: <CAKdteOYBchV9Wc7=PfeGAYHqro9LWu5SisFmuW2XepGqRes9Jg@mail.gmail.com> (raw)
In-Reply-To: <20180903145430.GA11187@redhat.com>
On Mon, 3 Sep 2018 at 16:54, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> Split the long double testing into a separate file, so that we can XFAIL
> targets where the long double precision doesn't meet the expected
> tolerances. The float and double tests are still expefted to PASS for
> all targets.
>
> PR libstdc++/78179
> * testsuite/26_numerics/headers/cmath/hypot-long-double.cc: New test
> that runs the long double part of hypot.cc.
> * testsuite/26_numerics/headers/cmath/hypot.cc: Disable long double
> tests unless TEST_HYPOT_LONG_DOUBLE is defined.
>
> Tested x86_64-linux, committed to trunk.
>
Hi,
I have noticed failures on hypot-long-double.cc on arm, so I suggest we add:
diff --git a/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
b/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
index 8a05473..4c2e33b 100644
--- a/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
+++ b/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
@@ -17,7 +17,7 @@
// { dg-options "-std=gnu++17" }
// { dg-do run { target c++17 } }
-// { dg-xfail-run-if "PR 78179" { powerpc-ibm-aix* hppa-*-linux* nios2-*-* } }
+// { dg-xfail-run-if "PR 78179" { powerpc-ibm-aix* hppa-*-linux*
nios2-*-* arm*-*-* } }
// Run the long double tests from hypot.cc separately, because they fail on a
// number of targets. See PR libstdc++/78179 for details.
OK?
Christophe
next prev parent reply other threads:[~2018-09-19 21:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 14:54 Jonathan Wakely
2018-09-19 21:13 ` Christophe Lyon [this message]
2018-09-19 21:18 ` Rainer Orth
2018-09-20 13:40 ` Christophe Lyon
2018-09-20 14:22 ` Jonathan Wakely
2018-09-20 17:14 ` Christophe Lyon
2018-09-21 1:14 ` Hans-Peter Nilsson
2018-09-21 10:25 ` Richard Earnshaw (lists)
2018-09-21 10:39 ` Jonathan Wakely
2018-09-21 10:50 ` Richard Earnshaw (lists)
2018-09-21 11:36 ` Jonathan Wakely
2018-09-21 14:01 ` Hans-Peter Nilsson
2018-09-21 16:10 ` Jonathan Wakely
2018-09-21 10:34 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKdteOYBchV9Wc7=PfeGAYHqro9LWu5SisFmuW2XepGqRes9Jg@mail.gmail.com' \
--to=christophe.lyon@linaro.org \
--cc=danglin@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=sandra@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).