From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23980 invoked by alias); 7 Oct 2014 13:33:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 23967 invoked by uid 89); 7 Oct 2014 13:33:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f41.google.com Received: from mail-qg0-f41.google.com (HELO mail-qg0-f41.google.com) (209.85.192.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 07 Oct 2014 13:33:19 +0000 Received: by mail-qg0-f41.google.com with SMTP id f51so5364296qge.28 for ; Tue, 07 Oct 2014 06:33:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=IjOudD93T/kCBAVOXpOk0j6WBU/TdxAzkyHlBGvHdCw=; b=d+wzxrHfOoOP3afC1ZvhCkrQorC5kC45CXYpiuD2xxyVk/r73jZcM2lI+yqjns8HyZ ZwpjgFAu6jCMZH/BZlKwFHrSSnrzAjy7wdo2rdIWOcN9AqYsLnOCypd669IfH9EX6bz3 VLgTtB/FfRo5y+u17SQONno2zqmidodOquWCrr4QNfxPjGteEdHtWEeFr+FvaOJQXXYl l9IyZ22TRoj1CFrC460Koy5g9t+6ejpo42IHo7IvKMsyuuhQF1zAZJGYB7dUnHRwMiyS nUAOsztIgbC2Jc7MQiEExSH1Bt5mmwL1Snykb+VBHpcQZ2gnE92jfKkfsIS03Ik9Zt+C Rvog== X-Gm-Message-State: ALoCoQmgRkA9cpNvxJykPGWImDzOqOFBjeIG25h9bcOkc5T/Nm7uRXZwkwbeJzci6Wa3l8C8nurW MIME-Version: 1.0 X-Received: by 10.224.167.15 with SMTP id o15mr4239666qay.32.1412688796912; Tue, 07 Oct 2014 06:33:16 -0700 (PDT) Received: by 10.140.86.114 with HTTP; Tue, 7 Oct 2014 06:33:16 -0700 (PDT) In-Reply-To: References: <1404209174-25364-1-git-send-email-christophe.lyon@linaro.org> <1404209174-25364-2-git-send-email-christophe.lyon@linaro.org> Date: Tue, 07 Oct 2014 13:33:00 -0000 Message-ID: Subject: Re: [Patch ARM-AArch64/testsuite v2 01/21] Neon intrinsics execution tests initial framework. From: Christophe Lyon To: Marcus Shawcroft , Ramana Radhakrishnan Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00548.txt.bz2 On 1 October 2014 17:11, Marcus Shawcroft wrote: > On 30 September 2014 15:27, Christophe Lyon wrote: >> On 10 July 2014 12:12, Marcus Shawcroft wrote: >>> On 1 July 2014 11:05, Christophe Lyon wrote: >>>> * documentation (README) >>>> * dejanu driver (neon-intrinsics.exp) >>>> * support macros (arm-neon-ref.h, compute-ref-data.h) >>>> * Tests for 3 intrinsics: vaba, vld1, vshl >>> >>> Hi, The terminology in armv8 is advsimd rather than neon. Can we >>> rename neon-intrinsics to advsimd-intrinsics or simd-intrinsics >>> throughout please. The existing gcc.target/aarch64/simd directory of >>> tests will presumably be superseded by this more comprehensive set of >>> tests so I suggest these tests go in gcc.target/aarch64/advsimd and we >>> eventually remove gcc.target/aarch64/simd/ directory. >>> >>> GNU style should apply throughout this patch series, notably double >>> space after period in comments and README text. Space before left >>> parenthesis in function/macro call and function declaration. The >>> function name in a declaration goes on a new line. The GCC wiki notes >>> on test case state individual test should have file names ending in >>> _, see here https://gcc.gnu.org/wiki/TestCaseWriting >>> >> >> Hi, >> >> For the record, these tests are based on a testsuite I wrote quite >> some time ago: >> https://gitorious.org/arm-neon-tests/ >> >> where obviously I had no such requirement (and v8 wasn't public yet) >> >> So I prefer to apply the changes you request in my main version before >> re-submitting it here. >> (libsanitizer-style, sort-of....). >> >> This will take me some time, so the next version of my patch series >> should not be expected really soon :-( > > Ramana, Marcus, > Hi Christophe, Given that this test suite code is an existing body > of work I see no reason to impose the GNU style change I originally > asked for. I withdraw my original comment that these patches should > conform to GNU style. My comment on file names is also withdrawn. I > would like to see the terminology corrected. > Thanks, I have updated my patch according to this. But meanwhile I have also updated my testsuite, and fixed the #define flag I used to toggle float16 tests: I now use __ARM_FP16_FORMAT_IEEE, such as: #if defined(__ARM_FP16_FORMAT_IEEE) TEST_VLD1(vector, buffer, , float, f, 16, 4); TEST_VLD1(vector, buffer, q, float, f, 16, 8); #endif Which reminded me that: - on ARM (AArch32), float16x4_t is supported, but float16x8_t isn't yet - on AArch64, -mfp16-format=ieee is rejected, and I didn't see a similar option in the doc What do you prefer me to do for these tests? I can think of: - do not include them at all until fp16 is fully supported on both AArch32 and AArch64 - include only those with float16x4_t - include both float16x4_t and float16x8_t tests, leaving float16x8_t commented - include both, uncommented, but do not test with -mfp16-format=ieee Thanks, Christophe. > Thanks > /Marcus