From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76237 invoked by alias); 13 Jul 2018 08:53:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76228 invoked by uid 89); 13 Jul 2018 08:53:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1354 X-HELO: mail-vk0-f67.google.com Received: from mail-vk0-f67.google.com (HELO mail-vk0-f67.google.com) (209.85.213.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jul 2018 08:53:37 +0000 Received: by mail-vk0-f67.google.com with SMTP id e139-v6so16350696vkf.6 for ; Fri, 13 Jul 2018 01:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C7nPuD0Ee3DWs/TfjIqPPv2STBZfBZpMQW7skfTt5Mk=; b=SMZ+UoyRDv5lQYE5o1zRv+cC5pAcG4IeLwd02YnP+CUSwfRh78KV6FjZR8XZoKzjAW K/C04bBAwaT/ShBUi9/iLgMTAMS7FUFksKxjV85q7qO6t7MJZEGYJ2snoz60acj42Uon IKG+YVBWuNp8eMbEhWDhhsOIsEXMb/F3Oj4AE= MIME-Version: 1.0 References: <4c30a386-0be0-f796-a651-757d86ee16b4@gmail.com> In-Reply-To: <4c30a386-0be0-f796-a651-757d86ee16b4@gmail.com> From: Christophe Lyon Date: Fri, 13 Jul 2018 08:53:00 -0000 Message-ID: Subject: Re: [PATCH] reject conflicting attributes before calling handlers (PR 86453) To: Martin Sebor Cc: Richard Biener , gcc Patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00671.txt.bz2 Hi, On Thu, 12 Jul 2018 at 00:04, Martin Sebor wrote: > > The attached change set adjusts the attribute exclusion code > to detect and reject incompatible attributes before attribute > handlers are called to have a chance to make changes despite > the exclusions. The handlers are not run when a conflict is > found. > > Tested on x86_64-linux. I expected the fallout to be bigger > but only a handful of tests needed adjusting and the changes > all look like clear improvements. I.e., conflicting attributes > that diagnosed as being ignored really are being ignored as one > would expect. > Since you committed this patch (r262596), I've noticed regressions on aarch64/arm: g++.dg/warn/pr86453.C -std=c++11 (test for warnings, line 4) g++.dg/warn/pr86453.C -std=c++11 (test for excess errors) g++.dg/warn/pr86453.C -std=c++14 (test for warnings, line 4) g++.dg/warn/pr86453.C -std=c++14 (test for excess errors) g++.dg/warn/pr86453.C -std=c++98 (test for warnings, line 4) g++.dg/warn/pr86453.C -std=c++98 (test for excess errors) The log says: Excess errors: /gcc/testsuite/g++.dg/warn/pr86453.C:4:44: warning: ignoring attribute 'packed' because it conflicts with attribute 'aligned' [-Wattributes] Isn't there the same message on x86_64? > Martin