* [PATCH] testsuite: Fix gcc.target/arm/multilib.exp use of gcc_opts
@ 2020-08-11 13:02 Christophe Lyon
2020-08-11 16:40 ` Richard Sandiford
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Lyon @ 2020-08-11 13:02 UTC (permalink / raw)
To: gcc Patches
[-- Attachment #1: Type: text/plain, Size: 985 bytes --]
This patch fixes an incorrect parameter passing for $gcc_opts, which
produces a DejaGnu error: (DejaGnu) proc "gcc_opts" does not exist.
2020-08-11 Christophe Lyon <christophe.lyon@linaro.org>
gcc/testsuite/
* gcc.target/arm/multilib.exp: Fix parameter passing for gcc_opts.
diff --git a/gcc/testsuite/gcc.target/arm/multilib.exp
b/gcc/testsuite/gcc.target/arm/multilib.exp
index f67a92a..c5f3c02 100644
--- a/gcc/testsuite/gcc.target/arm/multilib.exp
+++ b/gcc/testsuite/gcc.target/arm/multilib.exp
@@ -40,7 +40,7 @@ proc multilib_config {profile} {
proc check_multi_dir { gcc_opts multi_dir } {
global tool
- set options [list "additional_flags=[concat
"--print-multi-directory" [gcc_opts]]"]
+ set options [list "additional_flags=[concat
"--print-multi-directory" $gcc_opts]"]
set gcc_output [${tool}_target_compile "" "" "none" $options]
if { [string match "$multi_dir\n" $gcc_output] } {
pass "multilibdir $gcc_opts $multi_dir"
[-- Attachment #2: arm-multilib-gcc-opts.patch.txt --]
[-- Type: text/plain, Size: 1026 bytes --]
testsuite: Fix gcc.target/arm/multilib.exp use of gcc_opts
This patch fixes an incorrect parameter passing for $gcc_opts, which
produces a DejaGnu error: (DejaGnu) proc "gcc_opts" does not exist.
2020-08-11 Christophe Lyon <christophe.lyon@linaro.org>
gcc/testsuite/
* gcc.target/arm/multilib.exp: Fix parameter passing for gcc_opts.
diff --git a/gcc/testsuite/gcc.target/arm/multilib.exp b/gcc/testsuite/gcc.target/arm/multilib.exp
index f67a92a..c5f3c02 100644
--- a/gcc/testsuite/gcc.target/arm/multilib.exp
+++ b/gcc/testsuite/gcc.target/arm/multilib.exp
@@ -40,7 +40,7 @@ proc multilib_config {profile} {
proc check_multi_dir { gcc_opts multi_dir } {
global tool
- set options [list "additional_flags=[concat "--print-multi-directory" [gcc_opts]]"]
+ set options [list "additional_flags=[concat "--print-multi-directory" $gcc_opts]"]
set gcc_output [${tool}_target_compile "" "" "none" $options]
if { [string match "$multi_dir\n" $gcc_output] } {
pass "multilibdir $gcc_opts $multi_dir"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] testsuite: Fix gcc.target/arm/multilib.exp use of gcc_opts
2020-08-11 13:02 [PATCH] testsuite: Fix gcc.target/arm/multilib.exp use of gcc_opts Christophe Lyon
@ 2020-08-11 16:40 ` Richard Sandiford
2020-08-12 9:20 ` Christophe Lyon
0 siblings, 1 reply; 3+ messages in thread
From: Richard Sandiford @ 2020-08-11 16:40 UTC (permalink / raw)
To: Christophe Lyon via Gcc-patches
Christophe Lyon via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> This patch fixes an incorrect parameter passing for $gcc_opts, which
> produces a DejaGnu error: (DejaGnu) proc "gcc_opts" does not exist.
Huh, wonder how that went unnoticed for so long…
> 2020-08-11 Christophe Lyon <christophe.lyon@linaro.org>
>
> gcc/testsuite/
> * gcc.target/arm/multilib.exp: Fix parameter passing for gcc_opts.
OK everywhere that needs it, thanks.
Richard
> diff --git a/gcc/testsuite/gcc.target/arm/multilib.exp b/gcc/testsuite/gcc.target/arm/multilib.exp
> index f67a92a..c5f3c02 100644
> --- a/gcc/testsuite/gcc.target/arm/multilib.exp
> +++ b/gcc/testsuite/gcc.target/arm/multilib.exp
> @@ -40,7 +40,7 @@ proc multilib_config {profile} {
> proc check_multi_dir { gcc_opts multi_dir } {
> global tool
>
> - set options [list "additional_flags=[concat "--print-multi-directory" [gcc_opts]]"]
> + set options [list "additional_flags=[concat "--print-multi-directory" $gcc_opts]"]
> set gcc_output [${tool}_target_compile "" "" "none" $options]
> if { [string match "$multi_dir\n" $gcc_output] } {
> pass "multilibdir $gcc_opts $multi_dir"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] testsuite: Fix gcc.target/arm/multilib.exp use of gcc_opts
2020-08-11 16:40 ` Richard Sandiford
@ 2020-08-12 9:20 ` Christophe Lyon
0 siblings, 0 replies; 3+ messages in thread
From: Christophe Lyon @ 2020-08-12 9:20 UTC (permalink / raw)
To: Christophe Lyon via Gcc-patches, Christophe Lyon, Richard Sandiford
On Tue, 11 Aug 2020 at 18:40, Richard Sandiford
<richard.sandiford@arm.com> wrote:
>
> Christophe Lyon via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> > This patch fixes an incorrect parameter passing for $gcc_opts, which
> > produces a DejaGnu error: (DejaGnu) proc "gcc_opts" does not exist.
>
> Huh, wonder how that went unnoticed for so long…
Me too... it was introduced on 2020-02-06 by r10-6475
>
> > 2020-08-11 Christophe Lyon <christophe.lyon@linaro.org>
> >
> > gcc/testsuite/
> > * gcc.target/arm/multilib.exp: Fix parameter passing for gcc_opts.
>
> OK everywhere that needs it, thanks.
So pushed to gcc-10 too.
Thanks,
Christophe
>
> Richard
>
> > diff --git a/gcc/testsuite/gcc.target/arm/multilib.exp b/gcc/testsuite/gcc.target/arm/multilib.exp
> > index f67a92a..c5f3c02 100644
> > --- a/gcc/testsuite/gcc.target/arm/multilib.exp
> > +++ b/gcc/testsuite/gcc.target/arm/multilib.exp
> > @@ -40,7 +40,7 @@ proc multilib_config {profile} {
> > proc check_multi_dir { gcc_opts multi_dir } {
> > global tool
> >
> > - set options [list "additional_flags=[concat "--print-multi-directory" [gcc_opts]]"]
> > + set options [list "additional_flags=[concat "--print-multi-directory" $gcc_opts]"]
> > set gcc_output [${tool}_target_compile "" "" "none" $options]
> > if { [string match "$multi_dir\n" $gcc_output] } {
> > pass "multilibdir $gcc_opts $multi_dir"
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-12 9:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11 13:02 [PATCH] testsuite: Fix gcc.target/arm/multilib.exp use of gcc_opts Christophe Lyon
2020-08-11 16:40 ` Richard Sandiford
2020-08-12 9:20 ` Christophe Lyon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).