From: Christophe Lyon <christophe.lyon@linaro.org>
To: sgk@troutmask.apl.washington.edu
Cc: Mark Eggleston <mark.eggleston@codethink.co.uk>,
Janne Blomqvist <blomqvist.janne@gmail.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
fortran <fortran@gcc.gnu.org>
Subject: Re: *ping* Re: [PATCH] PR fortran/89100 Default widths for i, f and g format specifiers in format strings
Date: Fri, 24 May 2019 09:06:00 -0000 [thread overview]
Message-ID: <CAKdteOYSPaOwwgP1TSnC=DgQSC0OXBdWUwzS3b+nSCfR7QP8Qg@mail.gmail.com> (raw)
In-Reply-To: <20190523172114.GA82325@troutmask.apl.washington.edu>
On Thu, 23 May 2019 at 19:21, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
>
> On Thu, May 23, 2019 at 05:26:53PM +0200, Christophe Lyon wrote:
> > On Thu, 23 May 2019 at 15:54, Mark Eggleston
> > <mark.eggleston@codethink.co.uk> wrote:
> > > >
> > > > The logs contain:
> > > > /gcc/testsuite/gfortran.dg/fmt_f_default_field_width_1.f90:15:11:
> > > > Error: Kind 16 not supported for type REAL at (1)
> > > >
> > > > Christophe
> > >
> > > Apologies, I'd forgotten that kind=16 is not always defined. The
> > > attached patch modifies the test cases to take this into account. I
> > > currently have no means of verifying this.
> > >
> > > Please confirm that this patch solves the problem.
> > >
> >
> > I confirm this patch does fix the problem, thanks
> >
>
> Patch committed as r271573.
>
Hi,
Sorry, I didn't check all the testcases you changed, and this commit
introduces a new failure on arm:
/gcc/testsuite/gfortran.dg/fmt_f_default_field_width_3.f90:23:23:
Error: Nonnegative width required in format string at (1)
/gcc/testsuite/gfortran.dg/fmt_f_default_field_width_3.f90:26:23:
Error: Nonnegative width required in format string at (1)
/gcc/testsuite/gfortran.dg/fmt_f_default_field_width_3.f90:29:23:
Error: Nonnegative width required in format string at (1)
compiler exited with status 1
PASS: gfortran.dg/fmt_f_default_field_width_3.f90 -O (test for
errors, line 23)
PASS: gfortran.dg/fmt_f_default_field_width_3.f90 -O (test for
errors, line 26)
PASS: gfortran.dg/fmt_f_default_field_width_3.f90 -O (test for
errors, line 29)
FAIL: gfortran.dg/fmt_f_default_field_width_3.f90 -O (test for
errors, line 33)
PASS: gfortran.dg/fmt_f_default_field_width_3.f90 -O (test for excess errors)
that is, it seems there's no error message generated for line 33.
Christophe
> --
> Steve
next prev parent reply other threads:[~2019-05-24 9:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 9:45 Mark Eggleston
2019-05-22 7:58 ` *ping* " Mark Eggleston
2019-05-22 11:57 ` Janne Blomqvist
2019-05-23 10:38 ` Christophe Lyon
2019-05-23 13:54 ` Mark Eggleston
2019-05-23 15:27 ` Christophe Lyon
2019-05-23 17:21 ` Steve Kargl
2019-05-24 9:06 ` Christophe Lyon [this message]
2019-05-24 10:28 ` Mark Eggleston
2019-05-24 10:34 ` Jakub Jelinek
2019-05-24 14:25 ` Steve Kargl
2019-05-27 6:42 ` Christophe Lyon
2019-05-23 13:58 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKdteOYSPaOwwgP1TSnC=DgQSC0OXBdWUwzS3b+nSCfR7QP8Qg@mail.gmail.com' \
--to=christophe.lyon@linaro.org \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=mark.eggleston@codethink.co.uk \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).