From: Christophe Lyon <christophe.lyon@linaro.org>
To: gcc Patches <gcc-patches@gcc.gnu.org>
Subject: [Patch] Fix lto-wrapper link flags
Date: Mon, 19 Feb 2018 10:11:00 -0000 [thread overview]
Message-ID: <CAKdteOYUozNdSt-gE5eHGPNq8d4J92YXv_TYXpjrtrtFoiaB0Q@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
Hi,
I think there's a typo in gcc/Makefile.in, where lto-wrapper is linked
using $(ALL_COMPILERFLAGS) while it should be $(ALL_LINKERFLAGS).
I noticed this while playing with linker flags, and not seeing them
when linking lto-wrapper.
It seems obvious, but maybe I'm missing something?
OK for trunk?
Thanks,
Christophe
[-- Attachment #2: lto-wrapper.chlog.txt --]
[-- Type: text/plain, Size: 127 bytes --]
gcc/ChangeLog:
2018-02-19 Christophe Lyon <christophe.lyon@linaro.org>
* Makefile.in (lto-wrapper): Use ALL_LINKERFLAGS.
[-- Attachment #3: lto-wrapper.patch.txt --]
[-- Type: text/plain, Size: 521 bytes --]
diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 6c37e46..c91499d 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -2151,7 +2151,7 @@ CFLAGS-collect2.o += -DTARGET_MACHINE=\"$(target_noncanonical)\" \
LTO_WRAPPER_OBJS = lto-wrapper.o collect-utils.o ggc-none.o
lto-wrapper$(exeext): $(LTO_WRAPPER_OBJS) libcommon-target.a $(LIBDEPS)
- +$(LINKER) $(ALL_COMPILERFLAGS) $(LDFLAGS) -o T$@ \
+ +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) -o T$@ \
$(LTO_WRAPPER_OBJS) libcommon-target.a $(LIBS)
mv -f T$@ $@
next reply other threads:[~2018-02-19 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 10:11 Christophe Lyon [this message]
2018-02-26 10:59 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKdteOYUozNdSt-gE5eHGPNq8d4J92YXv_TYXpjrtrtFoiaB0Q@mail.gmail.com \
--to=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).