From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92798 invoked by alias); 30 Oct 2015 14:43:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 92780 invoked by uid 89); 30 Oct 2015 14:43:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f41.google.com Received: from mail-qg0-f41.google.com (HELO mail-qg0-f41.google.com) (209.85.192.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 30 Oct 2015 14:42:58 +0000 Received: by qgad10 with SMTP id d10so62842882qga.3 for ; Fri, 30 Oct 2015 07:42:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=kNR2nk8Co8tjuL+ZTXKdCo2lQ0CzH6caqEHn3g4WFtY=; b=C20A22VWSKDDP2LNk7UhpWF3wKU4MYNDfh1ndJYbtFjx/eB+xgz545HTxW7ofmeNQ2 Pm1NWpDsrAwKMJb42L5rw018k+BWa5JcfHv4GuZp8l+3j8glxfQB1MtE/goNy/TI7PS3 UkNda/jD4d3fdqWjCiLzU+YgcfETYhbx9bIdz3xm1FYvsM7L2UafDgh3NSXopcsALXuB febM/nPZD4FCoKpQYuXD+wk8rD0Yjko5CW1Cg/I+/HXY8SgoGb4/jPcy3tMu4k94iR6r zU34xyiFUuoJsvy+gLjxqmXrf5N022+ROl6OJWq98C/bEw00KyAj1zPfZK+UHbNYI/dP PcoA== X-Gm-Message-State: ALoCoQnaEQOsT1P8DHXKDXcjW485cG4abs9ruKSkqZXdAhNmLhsKFjcrmDMvP/IJHjl46qyEjDRA MIME-Version: 1.0 X-Received: by 10.140.39.199 with SMTP id v65mr10453909qgv.62.1446216175879; Fri, 30 Oct 2015 07:42:55 -0700 (PDT) Received: by 10.140.29.136 with HTTP; Fri, 30 Oct 2015 07:42:55 -0700 (PDT) In-Reply-To: <56337FD6.5040602@foss.arm.com> References: <56337FD6.5040602@foss.arm.com> Date: Fri, 30 Oct 2015 14:47:00 -0000 Message-ID: Subject: Re: [PATCH] [ARM] neon-testgen.ml typo From: Christophe Lyon To: Ramana Radhakrishnan Cc: Jim Wilson , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg03409.txt.bz2 On 30 October 2015 at 15:33, Ramana Radhakrishnan wrote: > > > On 29/10/15 17:23, Jim Wilson wrote: >> I noticed a comment typo in this file while using grep to look for >> other stuff. The typo is easy to fix. >> >> I tried running neon-testgen.ml to verify, but it is apparently no >> longer valid ocaml, as it doesn't work with the ocamlc 4.01.0 I have >> on Ubuntu 14.04. I get a syntax error. Someone who knows ocaml will >> have to fix this. Meanwhile, the patch to fix the typo should still >> be OK, as this is a separate problem. >> >> Jim >> > > This is OK. > > I'd really like neon-testgen.ml and the tests in gcc.target/arm/neon to be removed if all the intrinsics are now tested from Christophe's work in getting his advsimd tests integrated. Where are we on that ? > The tests I added cover all ARMv7 intrinsics. I have converted all my tests. There were a few additions to support some aarch64 specific intrinsics. However, most of the tests in gcc.target/arm/neon contain scan-asm directives which mine don't. My tests do check functionality (they are executable, comparing their results against expected values). Christophe. > regards > Ramana