From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 9387C397202F for ; Wed, 4 Aug 2021 09:11:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9387C397202F Received: by mail-pl1-x632.google.com with SMTP id a20so2391068plm.0 for ; Wed, 04 Aug 2021 02:11:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IkCox2VRDvcRSh3GMmFkpuRp/piuogkE9q4gLINc/vA=; b=qQkQoT/Dk1/5qnOfl1YU2OOESG9J4R8V+zvmdzVSWOEd6CbfmMJXcIwwnuan8m2wuh ZUyb0M/6PMZmKmiXqJhRaYb4Nx+dOnZ3zMdzQg6OsXTcLRbdpt0TJTqbefdoX9+5iu3S MkJhjRQ/Yg0ovqRq6hQuIxtWGhsWqJrOhN+9VLduUdbQxMJz4cKTwXmAw8VBAe3A39rd 3QEg8ik39JHxRIpnad9cGHprt5dYdYvlQqbCPwJk93DZsiAchOyynctffG6Dpy5d5zH6 xvhOdNeHAjhhNCE+qCUJcKtYxBEtAIJ5HSwkJVK/4F/GjFYAf6BloulqbE/avECtgzXh 8GyQ== X-Gm-Message-State: AOAM530p2cVzOgeDBdltPrIlMVxCh7+sbR7omtSzdkX0igh6LPfrN2H8 hZat4ZvgJ0AuBcUyHdNZen8BW+w2XippB49PMcLt0eKS+18= X-Google-Smtp-Source: ABdhPJxOk683m5Hx1HzVXW6MeUAukq2oAt2182bMBpRhjv8Yvky32N/PkuBCNU2PMRlBROwd6N1iaP5xH4xO0XSpLso= X-Received: by 2002:a17:902:ed82:b029:ef:48c8:128e with SMTP id e2-20020a170902ed82b02900ef48c8128emr21979710plj.72.1628068295398; Wed, 04 Aug 2021 02:11:35 -0700 (PDT) MIME-Version: 1.0 References: <71064e87-e296-4bfd-e934-9b582e2ed3de@foss.st.com> In-Reply-To: <71064e87-e296-4bfd-e934-9b582e2ed3de@foss.st.com> From: Christophe Lyon Date: Wed, 4 Aug 2021 11:11:24 +0200 Message-ID: Subject: Re: [PATCH] arm: Fix multilib mapping for CDE extensions [PR100856] To: Christophe LYON Cc: gcc Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2021 09:11:38 -0000 ping? On Thu, 15 Jul 2021 at 15:07, Christophe LYON via Gcc-patches wrote: > > This is a followup to Srinath's recent patch: the newly added test is > failing e.g. on arm-linux-gnueabihf without R/M profile multilibs. > > It is also failing on arm-eabi with R/M profile multilibs if the > execution engine does not support v8.1-M instructions. > > The patch avoids this by adding check_effective_target_FUNC_multilib > in target-supports.exp which effectively checks whether the target > supports linking and execution, like what is already done for other > ARM effective targets. pr100856.c is updated to use it instead of > arm_v8_1m_main_cde_mve_ok (which makes the testcase a bit of a > duplicate with check_effective_target_FUNC_multilib). > > In addition, I noticed that requiring MVE does not seem necessary and > this enables the test to pass even when targeting a CPU without MVE: > since the test does not involve actual CDE instructions, it can pass > on other architecture versions. For instance, when requiring MVE, we > have to use cortex-m55 under QEMU for the test to pass because the > memset() that comes from v8.1-m.main+mve multilib uses LOB > instructions (DLS) (memset is used during startup). Keeping > arm_v8_1m_main_cde_mve_ok would mean we would enable the test provided > we have the right multilibs, causing a runtime error if the simulator > does not support LOB instructions (e.g. when targeting cortex-m7). > > I do not update sourcebuild.texi since the CDE effective targets are > already collectively documented. > > Finally, the patch fixes two typos in comments. > > 2021-07-15 Christophe Lyon > > PR target/100856 > gcc/ > * config/arm/arm.opt: Fix typo. > * config/arm/t-rmprofile: Fix typo. > > gcc/testsuite/ > * gcc.target/arm/acle/pr100856.c: Use arm_v8m_main_cde_multilib > and arm_v8m_main_cde. > * lib/target-supports.exp: Add > check_effective_target_FUNC_multilib for ARM CDE. > >