From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117148 invoked by alias); 17 Jan 2019 13:22:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117127 invoked by uid 89); 17 Jan 2019 13:21:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=BAYES_50,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=UD:params.def, 267882, paramsdef, percent X-HELO: mail-vs1-f53.google.com Received: from mail-vs1-f53.google.com (HELO mail-vs1-f53.google.com) (209.85.217.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Jan 2019 13:21:57 +0000 Received: by mail-vs1-f53.google.com with SMTP id x1so6166442vsc.10 for ; Thu, 17 Jan 2019 05:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AozuFJl3NxHuLFQOlt2u+UILtjxt70EiFKADAPHEtbw=; b=PMDcz14O+igCSHif0R8xPYzuiRjLEa57a+WgRO8/khAjvh7zltw/oac4+I9yD/pHRd aRe4Hs/m+QuidLoo61rkGUmEZh0oiAO08Ur+uzVjRG+j6z726YNFxRdvT/MMdN0seUH5 VPJxX3QVA0ody7EMmg+iNHc1eRJu8xenArBs0= MIME-Version: 1.0 References: <20190112183228.cajeytm4r3d4xyjs@kam.mff.cuni.cz> <20190114164039.vbk7kiwgvtrjxwhn@kam.mff.cuni.cz> In-Reply-To: <20190114164039.vbk7kiwgvtrjxwhn@kam.mff.cuni.cz> From: Christophe Lyon Date: Thu, 17 Jan 2019 13:22:00 -0000 Message-ID: Subject: Re: Set inline-unit-growth to 40 To: Jan Hubicka Cc: gcc Patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg01001.txt.bz2 On Mon, 14 Jan 2019 at 17:40, Jan Hubicka wrote: > > Hello, > > > Index: params.def > > > =================================================================== > > > --- params.def (revision 267882) > > > +++ params.def (working copy) > > > @@ -227,7 +227,7 @@ DEFPARAM(PARAM_LARGE_UNIT_INSNS, > > > DEFPARAM(PARAM_INLINE_UNIT_GROWTH, > > > "inline-unit-growth", > > > "How much can given compilation unit grow because of the inlining (in percent).", > > > - 20, 0, 0) > > > + 40, 0, 0) > > > DEFPARAM(PARAM_IPCP_UNIT_GROWTH, > > > "ipcp-unit-growth", > > > "How much can given compilation unit grow because of the interprocedural constant propagation (in percent).", > > > > This patch introduces a regression in libstdc++: > > FAIL: ext/pb_ds/regression/list_update_map_rand.cc execution test > > on a few arm targets. > > > > For instance: > > arm-none-linux-gnueabihf > > --with-mode arm > > --with-cpu cortex-a5 > > --with-fpu vfpv3-d16-fp16 > > Adjusting inliner heuiristics should not trigger correcness issues, so > this seems like a bug that was previously latent. I guess it may > legally break correct code only if stack usage gets too large. > Indeed I didn't expect such a change to involve correctness issues. > Do you have any idea what breaks in this testcase? > Hmm, I've just seen this test fail then pass again in validations that did not involve any change related to it. So there's some "randomness", and the logs are not very helpful (no message saying memory exhaustion or similar) > Honza > > > > Using --with-mode thumb and the same other configure options makes the > > test pass. > > I'm seeing this with other configurations --with-mode arm and > > --with-fpu vfp* (as opposed to neon*) > > > > The .log file has: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ---------------------------------------- > > ************qemu: uncaught target signal 11 (Segmentation fault) - core dumped > > > > The (incomplete?) qemu execution trace ends with: > > ---------------- > > IN: > > 0x40ada6b8: e5910008 ldr r0, [r1, #8] > > 0x40ada6bc: e1560000 cmp r6, r0 > > 0x40ada6c0: 1a00004f bne #0x40ada804 > > ---------------- > > IN: > > 0x40ada6c4: e5960004 ldr r0, [r6, #4] > > 0x40ada6c8: e582100c str r1, [r2, #0xc] > > 0x40ada6cc: e3500c02 cmp r0, #0x200 > > 0x40ada6d0: e5812008 str r2, [r1, #8] > > 0x40ada6d4: 3a000002 blo #0x40ada6e4 > > ---------------- > > IN: > > 0x40adb880: eaffff3e b #0x40adb580 > > ---------------- > > IN: _ZN10__gnu_pbds4test6detail30container_rand_regression_testINS_11list_updateINS0_10basic_typeES4_St8equal_toIS4_ENS0_26lu_move_to_front_policy_t_EN9__gnu_cxx22throw_allocator_randomIS4_EEEEE13subscript_impENSt3tr117integral_constantIiLi0EEE > > 0x0001ffc4: e3a06000 mov r6, #0 > > 0x0001ffc8: eaffff88 b #0x1fdf0 > > ---------------- > > IN: _ZN10__gnu_pbds4test6detail30container_rand_regression_testINS_11list_updateINS0_10basic_typeES4_St8equal_toIS4_ENS0_26lu_move_to_front_policy_t_EN9__gnu_cxx22throw_allocator_randomIS4_EEEEE13subscript_impENSt3tr117integral_constantIiLi0EEE > > 0x0001fdf0: ee180a10 vmov r0, s16 > > 0x0001fdf4: ebffcd12 bl #0x13244 > > > > Christophe