From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41133 invoked by alias); 13 Jun 2017 19:22:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 41119 invoked by uid 89); 13 Jun 2017 19:22:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-ua0-f177.google.com Received: from mail-ua0-f177.google.com (HELO mail-ua0-f177.google.com) (209.85.217.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jun 2017 19:22:06 +0000 Received: by mail-ua0-f177.google.com with SMTP id 68so64274692uas.0 for ; Tue, 13 Jun 2017 12:22:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3iFeskLaNIE9f0XvCvLh1OXu0pg9f4lp9LtRVe3dsxg=; b=sPQiPdRP4pwbmlGYDqtufhUQSQbn7B1Qf5mXhAR213ByJf0dWVmHoPWWC0fcXgrfHQ Sp41fOTgWpvg6OsRadlK6KFJQSTIJfZmnFo3mp91T06LCwcX/I60RTgDZ4hHUXWEuSLj eSryu999XCaIiOtsVDzg26ZSE1eC8UcfQu8X/irNp+V95ZP67D4568Chprhfd0S5sYFo 6SdESKE2XZa6ibqNa564X6liLV44sQOC/StBt3kCWFdTVcivBgmNc2dtdS8iSBcTQmDb mq553U02SJl7ipwCIkFL7bJRD5MygFba0kRbSzkexbKgGSJZAixymyqVrG3q/7s//CRv LPLw== X-Gm-Message-State: AKS2vOzS+V394eEcXkVp0J3sIQnHiQog/K71FKHs2V9P9Gj4/yZnpoDv wJbtguEhKF1E//sWES0tQxFLT813JCyv X-Received: by 10.176.28.28 with SMTP id a28mr3204938uaj.38.1497381729075; Tue, 13 Jun 2017 12:22:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.50.131 with HTTP; Tue, 13 Jun 2017 12:22:08 -0700 (PDT) In-Reply-To: References: From: Christophe Lyon Date: Tue, 13 Jun 2017 19:22:00 -0000 Message-ID: Subject: Re: [PATCH, GCC/testsuite/ARM] Consistently check for neon in vect effective targets To: Thomas Preudhomme Cc: Kyrill Tkachov , Ramana Radhakrishnan , Richard Earnshaw , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00980.txt.bz2 Hi Thomas, On 13 June 2017 at 11:08, Thomas Preudhomme wrote: > Hi, > > Conditions checked for ARM targets in vector-related effective targets > are inconsistent: > > * sometimes arm*-*-* is checked > * sometimes Neon is checked > * sometimes arm_neon_ok and sometimes arm_neon is used for neon check > * sometimes check_effective_target_* is used, sometimes is-effective-target > > This patch consolidate all of these check into using is-effective-target > arm_neon and when little endian was checked, the check is kept. > > ChangeLog entry is as follows: > > *** gcc/testsuite/ChangeLog *** > > 2017-06-06 Thomas Preud'homme > > * lib/target-supports.exp (check_effective_target_vect_int): Replace > current ARM check by ARM NEON's availability check. > (check_effective_target_vect_intfloat_cvt): Likewise. > (check_effective_target_vect_uintfloat_cvt): Likewise. > (check_effective_target_vect_floatint_cvt): Likewise. > (check_effective_target_vect_floatuint_cvt): Likewise. > (check_effective_target_vect_shift): Likewise. > (check_effective_target_whole_vector_shift): Likewise. > (check_effective_target_vect_bswap): Likewise. > (check_effective_target_vect_shift_char): Likewise. > (check_effective_target_vect_long): Likewise. > (check_effective_target_vect_float): Likewise. > (check_effective_target_vect_perm): Likewise. > (check_effective_target_vect_perm_byte): Likewise. > (check_effective_target_vect_perm_short): Likewise. > (check_effective_target_vect_widen_sum_hi_to_si_pattern): Likewise. > (check_effective_target_vect_widen_sum_qi_to_hi): Likewise. > (check_effective_target_vect_widen_mult_qi_to_hi): Likewise. > (check_effective_target_vect_widen_mult_hi_to_si): Likewise. > (check_effective_target_vect_widen_mult_qi_to_hi_pattern): Likewise. > (check_effective_target_vect_widen_mult_hi_to_si_pattern): Likewise. > (check_effective_target_vect_widen_shift): Likewise. > (check_effective_target_vect_extract_even_odd): Likewise. > (check_effective_target_vect_interleave): Likewise. > (check_effective_target_vect_multiple_sizes): Likewise. > (check_effective_target_vect64): Likewise. > (check_effective_target_vect_max_reduc): Likewise. > > Testing: Testsuite shows no regression when targeting ARMv7-A with > -mfpu=neon-fpv4 and -mfloat-abi=hard or when targeting Cortex-M3 with > default FPU and float ABI (soft). > That's strange, my testing detects a syntax error: Executed from: gcc.dg/vect/vect.exp gcc.dg/vect/slp-9.c: error executing dg-final: unbalanced close paren See http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/249142-consistent_neon_check/report-build-info.html for a full picture. Note that the cells with "BETTER" seem to be mostly several PASSes becoming unsupported. Thanks, Christophe > Is this ok for trunk? > > Best regards, > > Thomas