From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29623 invoked by alias); 11 Sep 2016 07:09:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29596 invoked by uid 89); 11 Sep 2016 07:08:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2760 X-HELO: mail-qt0-f174.google.com Received: from mail-qt0-f174.google.com (HELO mail-qt0-f174.google.com) (209.85.216.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 11 Sep 2016 07:08:47 +0000 Received: by mail-qt0-f174.google.com with SMTP id 93so59783082qtg.2 for ; Sun, 11 Sep 2016 00:08:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IgzL5IzYGaVniak13/JPcbseyKSJOgyuKE4mmEq22K8=; b=VpmDf+ALKnK7aqR7CqyN8Vpgm/py9azQvTxhVGj2CVWRqmMPfEis3HnqenpQ01MO95 7tpHiIzgVU4wHntvzz15ub9Rkn4BGtmK+4N4GJlsJivDnlWz8wgmxw8r7V5GxPUs+gH8 uHJff85HHqCQhw04oUNMK79OcZbChg1LebFfylzS2o72r/oEgGMN6z+N+gVfdRqmUvNS CLlrervIo3N2FCzpPkSu/2HlCaJiAMLmVUMoNJMQpWHkozdJi0FJgqsnXQEC7O51jl7r gwtkyOIOkbDVgKrqsh0wCQMk1zvpdfTgems89Q0OCMtQP/aXDG14IN3QKlizIjWzUofe 3hew== X-Gm-Message-State: AE9vXwPccO2rs7ZjNPNep2dtzgAcr4s9cOodjU3DUoCmXAY7tFlBRmV8oNnmHpErnSnSprtMhv11dhxInJdR126X X-Received: by 10.200.57.4 with SMTP id s4mr23513qtb.68.1473577725704; Sun, 11 Sep 2016 00:08:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.21.102 with HTTP; Sun, 11 Sep 2016 00:08:44 -0700 (PDT) In-Reply-To: References: <20160908110641.GB23306@redhat.com> From: Christophe Lyon Date: Sun, 11 Sep 2016 09:14:00 -0000 Message-ID: Subject: Re: RFA (libstdc++): PATCH to implement C++17 over-aligned new To: Jason Merrill Cc: Jonathan Wakely , "libstdc++@gcc.gnu.org" , gcc-patches List Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00597.txt.bz2 On 10 September 2016 at 08:59, Christophe Lyon wrote: > On 9 September 2016 at 23:20, Jason Merrill wrote: >> On Thu, Sep 8, 2016 at 7:06 AM, Jonathan Wakely wrote: >>> On 08/09/16 09:10 +0200, Marc Glisse wrote: >>>> >>>> Do we want a generic fallback implementation (similar to >>>> gcc/config/i386/gmm_malloc.h)? A windows version with _aligned_malloc / >>>> _aligned_free would also be possible. >>> >>> Making it work for MinGW would be nice. >> >> OK, this is what I'm checking in; could someone test it on MinGW? >> >> Jason > > Hi Jason, > > I'm seeing problems on arm*linux: the tests aligned-new[1235].C fail to link: > aligned-new5.C:(.text+0x14): undefined reference to `operator > new(unsigned int, std::align_val_t)' > > > On aarch64*-elf and arm-eabi (using newlib), I'm seeing: > /gccsrc/libstdc++-v3/libsupc++/new_opa.cc:66: undefined reference to > `aligned_alloc' > > Am I missing something in my setup? > I'm seeing an additional problem: to GCC build is broken after this commit for target arm-none-eabi (using default cpu): /home/christophe.lyon/src/GCC/sources/gcc-fsf/reg-240062/libstdc++-v3/libsupc++/new_opant.cc: In function 'void* operator new(std::size_t, std::align_val_t, const std::nothrow_t&)': /home/christophe.lyon/src/GCC/sources/gcc-fsf/reg-240062/libstdc++-v3/libsupc++/new_opant.cc:33:3: error: '__try' was not declared in this scope __try ^~~~~ /home/christophe.lyon/src/GCC/sources/gcc-fsf/reg-240062/libstdc++-v3/libsupc++/new_opant.cc:37:11: error: expected primary-expression before '...' token __catch(...) ^~~ /home/christophe.lyon/src/GCC/sources/gcc-fsf/reg-240062/libstdc++-v3/libsupc++/new_opant.cc:37:3: error: '__catch' was not declared in this scope __catch(...) ^~~~~~~ /home/christophe.lyon/src/GCC/sources/gcc-fsf/reg-240062/libstdc++-v3/libsupc++/new_opant.cc:41:1: warning: no return statement in function returning non-void [-Wreturn-type] } ^ /home/christophe.lyon/src/GCC/sources/gcc-fsf/reg-240062/libstdc++-v3/libsupc++/new_opant.cc:30:26: warning: unused parameter 'sz' [-Wunused-parameter] operator new(std::size_t sz, std::align_val_t al, const std::nothrow_t&) ^~ /home/christophe.lyon/src/GCC/sources/gcc-fsf/reg-240062/libstdc++-v3/libsupc++/new_opant.cc:30:47: warning: unused parameter 'al' [-Wunused-parameter] operator new(std::size_t sz, std::align_val_t al, const std::nothrow_t&) ^~ make[4]: *** [new_opant.lo] Error 1 make[4]: Leaving directory `/home/christophe.lyon/src/GCC/builds/gcc-fsf-reg-240062/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/libsupc++' Let me know if you need more details. Thanks, Christophe > Thanks, > > Christophe