From: Christophe Lyon <christophe.lyon@linaro.org>
To: "Andre Vieira (lists)" <Andre.SimoesDiasVieira@arm.com>
Cc: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCHv3][ARM] -mpure-code option for ARM
Date: Thu, 22 Sep 2016 19:34:00 -0000 [thread overview]
Message-ID: <CAKdteOYvqAjAytcLDD0God57eQ_kZ84SGD7FcOgdVSAC=yA_sA@mail.gmail.com> (raw)
In-Reply-To: <57E40F29.3010509@arm.com>
Hi Andre,
On 22 September 2016 at 19:04, Andre Vieira (lists)
<Andre.SimoesDiasVieira@arm.com> wrote:
> On 22/09/16 16:28, Richard Earnshaw (lists) wrote:
>> On 22/09/16 16:04, Andre Vieira (lists) wrote:
>>>
>>> I reworked the patch according to the comments above.
>>>
>>> Is this OK?
>>>
>>> gcc/ChangeLog:
>>> 2016-09-22 Andre Vieira <andre.simoesdiasvieira@arm.com>
>>> Terry Guo <terry.guo@arm.com>
>>>
>>> * target.def (elf_flags_numeric): New target hook.
>>> * targhooks.h (default_asm_elf_flags_numeric): New.
>>> * varasm.c (default_asm_elf_flags_numeric): New.
>>> (default_elf_asm_named_section): Use new target hook.
>>> * config/arm/arm.opt (mpure-code): New.
>>> * config/arm/arm.h (SECTION_ARM_PURECODE): New.
>>> * config/arm/arm.c (arm_asm_init_sections): Add section
>>> attribute to default text section if -mpure-code.
>>> (arm_option_check_internal): Diagnose use of option with
>>> non supported targets and/or options.
>>> (arm_asm_elf_flags_numeric): New.
>>> (arm_function_section): New.
>>> (arm_elf_section_type_flags): New.
>>> * config/arm/elf.h (JUMP_TABLES_IN_TEXT_SECTION): Disable
>>> for -mpure-code.
>>> * gcc/doc/texi (TARGET_ASM_ELF_FLAGS_NUMERIC): New.
>>> * gcc/doc/texi.in (TARGET_ASM_ELF_FLAGS_NUMERIC): Likewise.
>>>
>>>
>>>
>>> gcc/testsuite/ChangeLog:
>>> 2016-09-22 Andre Vieira <andre.simoesdiasvieira@arm.com>
>>> Terry Guo <terry.guo@arm.com>
>>>
>>> * gcc.target/arm/pure-code/ffunction-sections.c: New.
>>> * gcc.target/arm/pure-code/no-literal-pool.c: New.
>>> * gcc.target/arm/pure-code/pure-code.exp: New.
>>>
>>>
>>
>> I missed this last time around, but please can you wrap references to
>> SHF_ARM_PURECODE in the documentation with @code{...}.
>>
>> OK with that change.
>>
>> R.
>
> Done. Committed as revision r240379.
>
This patch broke the aarch64 builds:
/tmp/9380062_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/config/aarch64/aarch64.c:14391:
error: ‘hook_uint_uintp_false’ was not declared in this s
cope
/tmp/9380062_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/config/aarch64/aarch64.c:14391:
error: too many initializers for ‘gcc_target::asm_out’
make[2]: *** [aarch64.o] Error 1
make[2]: Leaving directory
`/tmp/9380062_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/gcc1/gcc'
make[1]: *** [all-gcc] Error 2
make[1]: Leaving directory
`/tmp/9380062_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/gcc1'
make: *** [all] Error 2
next prev parent reply other threads:[~2016-09-22 19:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 14:46 [PATCH][ARM] " Andre Vieira (lists)
2016-07-01 19:04 ` Sandra Loosemore
2016-07-07 12:29 ` mickael guene
2016-07-07 12:31 ` mickael guene
2016-07-11 16:57 ` [PATCHv2][ARM] " Andre Vieira (lists)
2016-07-25 10:52 ` [PATCHv2, PING][ARM] " Andre Vieira (lists)
2016-08-11 14:13 ` [PATCHv2, PING 2][ARM] " Andre Vieira (lists)
2016-08-30 8:01 ` [PATCHv2, PING 3][ARM] " Andre Vieira (lists)
2016-09-19 9:25 ` [PATCHv2, PING 4][ARM] " Andre Vieira (lists)
2016-09-22 14:22 ` [PATCHv2][ARM] " Richard Earnshaw (lists)
2016-09-22 15:10 ` [PATCHv3][ARM] " Andre Vieira (lists)
2016-09-22 15:47 ` Richard Earnshaw (lists)
2016-09-22 17:24 ` Andre Vieira (lists)
2016-09-22 19:34 ` Christophe Lyon [this message]
2016-09-22 20:05 ` Bill Seurer
2016-09-22 20:30 ` Martin Sebor
2016-09-22 20:20 ` Paolo Carlini
2016-09-23 13:47 ` [PATCH, arm-embedded] " Andre Vieira (lists)
2016-09-23 6:31 ` [PATCHv2][ARM] " Sandra Loosemore
2016-09-23 8:51 ` Andre Vieira (lists)
2016-09-23 10:41 ` Andre Vieira (lists)
2016-09-23 15:12 ` Sandra Loosemore
2016-10-04 13:24 ` mickael guene
2016-10-04 14:15 ` Andre Vieira (lists)
2016-09-22 18:22 [PATCHv3][ARM] " David Edelsohn
2016-09-22 22:16 Uros Bizjak
2016-09-23 10:18 ` Jakub Jelinek
2016-09-23 10:39 ` Andre Vieira (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKdteOYvqAjAytcLDD0God57eQ_kZ84SGD7FcOgdVSAC=yA_sA@mail.gmail.com' \
--to=christophe.lyon@linaro.org \
--cc=Andre.SimoesDiasVieira@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).