From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31493 invoked by alias); 22 Sep 2016 19:12:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31479 invoked by uid 89); 22 Sep 2016 19:12:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=sk:Andre.S, Andre.SimoesDiasVieira@arm.com, U*Andre.SimoesDiasVieira, AndreSimoesDiasVieiraarmcom X-HELO: mail-qk0-f169.google.com Received: from mail-qk0-f169.google.com (HELO mail-qk0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Sep 2016 19:11:57 +0000 Received: by mail-qk0-f169.google.com with SMTP id t7so85861939qkh.2 for ; Thu, 22 Sep 2016 12:11:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5NY7pVP0cO83fVrjJC3Q9gDY1b+Uudq/7EyHeRZASPw=; b=chh9mE8ySBIc6CjT8FGzEoiStlJPSq2XRPM4nwrVruS5pDh3RqyXzwsVRgxlTDLshF P6lVBWqpJIAwls7CqnVlVvY61CcRXsMzfKYJIVx2Xope3dk4TwgKu0db0QEB5A3slX9A ObsUzNsZEbdx0I8MVETX5pMZNOF3uX+8/vLaD71BhrzHPZe9huOwu7c2d7kLYp2PXK5O Tkp5J6uOaqjCBdYLsjEv7rRX3DNhoc82oT2nzItxAoYjTJkgRHTKKks29+QpXQxLNrxp gTkGT1j1cxK7PFJz4WTNLWFLxqREuaaxFP6kGbVWc5JWmkqPHMUWRoK/G2G0yUMvdd+k HGXw== X-Gm-Message-State: AA6/9RkXlWI6R8EkUuHU2mJZ75sRwor8vxbZTZ0hueE+CnncNnw1KzEyLrxqPZbIKsPQntspKjZqehWzwdYSxLLe X-Received: by 10.55.179.135 with SMTP id c129mr3934793qkf.98.1474571516244; Thu, 22 Sep 2016 12:11:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.21.80 with HTTP; Thu, 22 Sep 2016 12:11:55 -0700 (PDT) In-Reply-To: <57E40F29.3010509@arm.com> References: <57752D6E.9070006@arm.com> <47c8a674-3af0-afff-776b-9d71c0d1bb46@st.com> <5783CFD1.2070500@arm.com> <57E3F2F7.9000409@arm.com> <36b8c97a-6f1b-f28a-b954-789d141d18bb@arm.com> <57E40F29.3010509@arm.com> From: Christophe Lyon Date: Thu, 22 Sep 2016 19:34:00 -0000 Message-ID: Subject: Re: [PATCHv3][ARM] -mpure-code option for ARM To: "Andre Vieira (lists)" Cc: "Richard Earnshaw (lists)" , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg01615.txt.bz2 Hi Andre, On 22 September 2016 at 19:04, Andre Vieira (lists) wrote: > On 22/09/16 16:28, Richard Earnshaw (lists) wrote: >> On 22/09/16 16:04, Andre Vieira (lists) wrote: >>> >>> I reworked the patch according to the comments above. >>> >>> Is this OK? >>> >>> gcc/ChangeLog: >>> 2016-09-22 Andre Vieira >>> Terry Guo >>> >>> * target.def (elf_flags_numeric): New target hook. >>> * targhooks.h (default_asm_elf_flags_numeric): New. >>> * varasm.c (default_asm_elf_flags_numeric): New. >>> (default_elf_asm_named_section): Use new target hook. >>> * config/arm/arm.opt (mpure-code): New. >>> * config/arm/arm.h (SECTION_ARM_PURECODE): New. >>> * config/arm/arm.c (arm_asm_init_sections): Add section >>> attribute to default text section if -mpure-code. >>> (arm_option_check_internal): Diagnose use of option with >>> non supported targets and/or options. >>> (arm_asm_elf_flags_numeric): New. >>> (arm_function_section): New. >>> (arm_elf_section_type_flags): New. >>> * config/arm/elf.h (JUMP_TABLES_IN_TEXT_SECTION): Disable >>> for -mpure-code. >>> * gcc/doc/texi (TARGET_ASM_ELF_FLAGS_NUMERIC): New. >>> * gcc/doc/texi.in (TARGET_ASM_ELF_FLAGS_NUMERIC): Likewise. >>> >>> >>> >>> gcc/testsuite/ChangeLog: >>> 2016-09-22 Andre Vieira >>> Terry Guo >>> >>> * gcc.target/arm/pure-code/ffunction-sections.c: New. >>> * gcc.target/arm/pure-code/no-literal-pool.c: New. >>> * gcc.target/arm/pure-code/pure-code.exp: New. >>> >>> >> >> I missed this last time around, but please can you wrap references to >> SHF_ARM_PURECODE in the documentation with @code{...}. >> >> OK with that change. >> >> R. > > Done. Committed as revision r240379. > This patch broke the aarch64 builds: /tmp/9380062_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/config/aarch64= /aarch64.c:14391: error: =E2=80=98hook_uint_uintp_false=E2=80=99 was not declared in this s cope /tmp/9380062_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/config/aarch64= /aarch64.c:14391: error: too many initializers for =E2=80=98gcc_target::asm_out=E2=80=99 make[2]: *** [aarch64.o] Error 1 make[2]: Leaving directory `/tmp/9380062_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-l= inux-gnu/gcc1/gcc' make[1]: *** [all-gcc] Error 2 make[1]: Leaving directory `/tmp/9380062_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-l= inux-gnu/gcc1' make: *** [all] Error 2