From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105578 invoked by alias); 25 May 2015 11:57:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 105561 invoked by uid 89); 25 May 2015 11:57:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qk0-f169.google.com Received: from mail-qk0-f169.google.com (HELO mail-qk0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 25 May 2015 11:57:20 +0000 Received: by qkgv12 with SMTP id v12so62557716qkg.0 for ; Mon, 25 May 2015 04:57:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=3Bb/MfSq9hpaUqiVNhJZNSCt6qUsf46x05XoPXM5fCI=; b=W5lIRnAVnzHv7it5zYSdr2vNl5ztaefdd9gkzBWSnBsdPHogdk+FV/0ohGZWRqHPo9 YqMcq9aAhdTD/y/pS3SPunxl/Z2qlrSBSEtJTL0oOdXkRg5Dlwv0nxpVyBHN6cFu4eT1 2zWhwsCSh95DTysoQwqNzsw0oR74skMTvysBFf2aAStbHtY8kpbemimlTtTLRKuU54QU G3xOzageWmC2htpW3oPqAuYjGw2riafkj6n44JDUDSclhRKZcX+BY/rgeVnOHOunYPzf a8Z1438xuxVszJUE4DBV4uSzWQu9fxIdSyyH16N6Ad7zKhUX9PlfQLc90Ig0mrOUfTuI 0mNA== X-Gm-Message-State: ALoCoQn4rnBd+eICHJSoOSmm+n50Ia4NJj2EpEdrVYTrBQrtpaaRkT+dNOVFI35/JfpjZS3nFJpD MIME-Version: 1.0 X-Received: by 10.55.27.65 with SMTP id b62mr15222553qkb.107.1432555038652; Mon, 25 May 2015 04:57:18 -0700 (PDT) Received: by 10.140.102.164 with HTTP; Mon, 25 May 2015 04:57:18 -0700 (PDT) In-Reply-To: <5537DC12.1050201@arm.com> References: <5537D241.1000606@arm.com> <5537DC12.1050201@arm.com> Date: Mon, 25 May 2015 12:43:00 -0000 Message-ID: Subject: Re: [PATCH 13/14][ARM/AArch64 testsuite] Use gcc-dg-runtest in advsimd-intrinsics.exp From: Christophe Lyon To: Alan Lawrence Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg02241.txt.bz2 On 22 April 2015 at 19:36, Alan Lawrence wrote: > In the first revision of Christophe Lyon's advsimd-intrinsics tests, > https://gcc.gnu.org/ml/gcc-patches/2014-06/msg00532.html , both > gcc-dg-runtest (to assemble only) and c-torture-execute were used. In review > the gcc-dg-runtest part was then dropped, and execution tests continued > using c-torture-execute. However, c-torture-execute ignores e.g. dg-options > directives in the individual test files, whereas gcc-dg-runtest does not. > > This patch switches to gcc-dg-runtest (with dg-do-what-default = "run") for > all tests, allowing use of e.g. dg-options (in testsuite patch 3/3). This Sandra has recently committed a slightly different patch. If you want to update your, here are few comments/questions: - why do you add "-w" to additional_flags? - you changed the way we iterate over the tests, but this removes the possiblity to actually execute only a subset of the available tests, such as RUNTESTFLAGS=advsimd-intrinsics.exp=vadd.c Christophe. > generally seems to work OK - indeed I also dropped the > parallelization-disabling code - and the new advsimd-intrinsics.exp now > follows gcc.c-torture/compile/compile.exp and > gcc.c-torture/execute/execute.exp very closely. However, there are side > effects, of which we should be aware, but with which I think we can live, > specifically: > > (1) the lines in the test log change from... > > PASS: gcc.target/aarch64/advsimd-intrinsics/vcombine.c compilation, -O1 > PASS: gcc.target/aarch64/advsimd-intrinsics/vcombine.c execution, -O1 > > ...to... > > PASS: gcc.target/aarch64/advsimd-intrinsics/vcombine.c -O1 execution test > > (that is, the compilation line disappears, but the (test for excess errors) > remains unchanged) > > (2) The "-Og -g" variant is no longer tested; all of -O0, -O1, -O2, -O2 > -flto -fno-use-linker-plugin -flto-partition=none, -O2 -flto > -fuse-linker-plugin -fno-fat-lto-objects, -O3 -fomit-frame-pointer, -O3 -g, > -Os still are. My feeling is that this set of options is exhaustive enough. > > Cross-tested arm-none-eabi, aarch64-none-elf, aarch64_be-none-elf; natively > tested arm-none-linux-gnueabihf and aarch64-none-linux-gnu. > > gcc/testsuite/ChangeLog: > > * gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp: > Use gcc-dg-runtest.