From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11958 invoked by alias); 18 Jan 2015 19:58:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11946 invoked by uid 89); 18 Jan 2015 19:58:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qc0-f172.google.com Received: from mail-qc0-f172.google.com (HELO mail-qc0-f172.google.com) (209.85.216.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 18 Jan 2015 19:58:41 +0000 Received: by mail-qc0-f172.google.com with SMTP id i8so14810677qcq.3 for ; Sun, 18 Jan 2015 11:58:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=y+qXpaCdHlqoqP4430HzeMYR+i5u3n0IXaWiDtu1K84=; b=VqH50fadkOO9bzrCyeXpzFQRvwF9web56XRKvo8eac85wUK6tXK3VdF/rhLZWtr1/F ImIxpm+CEly3T3GwCjqOtkxIZkqRwD1OxLoczAvfI9szO4GSFRhpnu+tHQkcjrz6aiRo OfuNCmftSZvGMfEMowiJQa5mM6JYYj0GxHWBMd+YFJbw+mO7/8wxAq3KOJBCZyUJB7oJ p7YsGrX4VQ8rb4c+Am5NLIlLmd0GZ6amxz4MD3MYOD25b4M+pAmwj6sZpM7eUDlXmNpE viiRV7EMlrMHNjgUbYbmBetHRgRKnIWUN/q7AB0bK9xhOf84yqyjNJl/+kDAdUD9ZAGu u69w== X-Gm-Message-State: ALoCoQktvfZh1pnIfCnkyPceEpoaiOrTUWEKRgc018nq3RwflORKgKACT/Ugdm5saEnUHd0iWRB8 MIME-Version: 1.0 X-Received: by 10.229.70.133 with SMTP id d5mr42359676qcj.2.1421611118875; Sun, 18 Jan 2015 11:58:38 -0800 (PST) Received: by 10.140.84.176 with HTTP; Sun, 18 Jan 2015 11:58:38 -0800 (PST) In-Reply-To: References: <000101d007a5$0d120f30$27362d90$@arm.com> <5472F2EA.9000702@redhat.com> <000001d0088b$a4590c40$ed0b24c0$@arm.com> <54744AEA.9010706@redhat.com> <000201d015e0$89a2f480$9ce8dd80$@arm.com> <548B4131.2030300@redhat.com> <000001d01842$eaa16be0$bfe443a0$@arm.com> <54B80461.704@redhat.com> Date: Sun, 18 Jan 2015 21:26:00 -0000 Message-ID: Subject: Re: [PATCH, AARCH64] Fix ICE in CCMP (PR64015) From: Christophe Lyon To: Marcus Shawcroft Cc: Jiong Wang , "gcc-patches@gcc.gnu.org" , Richard Henderson Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg01609.txt.bz2 On 16 January 2015 at 11:54, Marcus Shawcroft wrote: > On 15 January 2015 at 18:18, Richard Henderson wrote: >> On 12/15/2014 12:41 AM, Zhenqiang Chen wrote: >>> +(define_expand "cmp" >>> + [(set (match_operand 0 "cc_register" "") >>> + (match_operator:CC 1 "aarch64_comparison_operator" >>> + [(match_operand:GPI 2 "register_operand" "") >>> + (match_operand:GPI 3 "aarch64_plus_operand" "")]))] >>> + "" >>> + " >>> + operands[1] = gen_rtx_fmt_ee (COMPARE, SELECT_CC_MODE (GET_CODE (operands[1]), >>> + operands[2], >>> + operands[3]), >>> + operands[2], operands[3]); >>> + " >>> +) >> >> Use { } not "" for the C portion. >> >> Otherwise ok. > > Jiong... this is fine with me. /Marcus Jiong, I have noticed regressions on aarch64 after this patch: See: http://abe.tcwglab.linaro.org/logs/validations/cross-validation/gcc/trunk/219723/report-build-info.html Passed now fails [PASS => FAIL]: gcc.target/aarch64/test_frame_1.c scan-assembler-times ldr\tx30, \\[sp\\], [0-9]+ 3 gcc.target/aarch64/test_frame_2.c scan-assembler-times ldp\tx19, x30, \\[sp\\], [0-9]+ 2 gcc.target/aarch64/test_frame_4.c scan-assembler-times ldp\tx19, x30, \\[sp\\], [0-9]+ 2 gcc.target/aarch64/test_frame_6.c scan-assembler-times ldr\tx30, \\[sp\\], [0-9]+ 3 gcc.target/aarch64/test_frame_7.c scan-assembler-times ldp\tx19, x30, \\[sp\\], [0-9]+ 2 Is this expected? Thanks, Christophe.