From: Christophe Lyon <christophe.lyon@linaro.org>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>
Cc: Ramana Radhakrishnan <ramana.gcc@googlemail.com>,
Ramana Radhakrishnan <ramana.radhakrishnan@foss.arm.com>,
Jim Wilson <jim.wilson@linaro.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] [ARM] neon-testgen.ml typo
Date: Fri, 13 Nov 2015 13:36:00 -0000 [thread overview]
Message-ID: <CAKdteOZ9X=30T6tXfjex5wths73FFUzx2ncB350eK-f1dWrPKg@mail.gmail.com> (raw)
In-Reply-To: <5645C879.7090406@arm.com>
On 13 November 2015 at 12:24, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
>
> On 13/11/15 11:18, Ramana Radhakrishnan wrote:
>>>
>>> Hmm. I hadn't noticed that the crypto intrinsics tests where generated by
>>> neon-testgen.ml, I thought they were hand-written.
>>> The tests I added do not cover the crypto intrinsics, so I'm going
>>> to revert r230274 and restore all the tests generated by neon-testgen.ml
>>> until we have better coverage in advsimd-intrinsics.
>>
>> From what I remember from a few days back I thought it was generally
>> ok to get rid of the lot as we had test coverage for everything else
>> in gcc.target/arm .
>>
>> Thus don't bother reverting.
>
>
> +1. I'll also add that you can now remove neon.ml from config/arm.
Sorry, I felt so guilty that I reverted the removal already.
> And also, I think we can move the remaining hand-written tests from
> gcc.target/arm/neon/
> into gcc.target/arm/ and remove the neon/ directory altogether.
>
I'll give a deeper look at all that, and will try not to rush to meet
e/o stage1 deadline :-)
> Kyrill
>
>
>>
>> Ramana
>>
>>> Sorry for the oversight.
>>>
>>> Christophe.
>>>
>>>
>>>> Christophe.
>>>>
>>>>>> regards
>>>>>> Ramana
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Christophe.
>>>>>>>
>>>>>>>> regards
>>>>>>>> Ramana
>
>
next prev parent reply other threads:[~2015-11-13 13:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 17:29 Jim Wilson
2015-10-30 14:37 ` Ramana Radhakrishnan
2015-10-30 14:47 ` Christophe Lyon
2015-11-04 12:16 ` Ramana Radhakrishnan
2015-11-06 20:29 ` Christophe Lyon
2015-11-12 22:18 ` Christophe Lyon
2015-11-13 10:24 ` Christophe Lyon
2015-11-13 10:28 ` Kyrill Tkachov
2015-11-13 11:18 ` Ramana Radhakrishnan
2015-11-13 11:24 ` Kyrill Tkachov
2015-11-13 13:36 ` Christophe Lyon [this message]
2015-11-24 15:25 ` Christophe Lyon
2015-11-02 12:06 ` Julian Brown
2015-11-02 12:21 ` Kyrill Tkachov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKdteOZ9X=30T6tXfjex5wths73FFUzx2ncB350eK-f1dWrPKg@mail.gmail.com' \
--to=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jim.wilson@linaro.org \
--cc=kyrylo.tkachov@arm.com \
--cc=ramana.gcc@googlemail.com \
--cc=ramana.radhakrishnan@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).