public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] testsuite/aarch64: Skip SLP diagnostic under ILP32 (PR target/96974)
@ 2021-03-29 11:39 Christophe Lyon
  2021-03-31 10:07 ` Richard Biener
  0 siblings, 1 reply; 3+ messages in thread
From: Christophe Lyon @ 2021-03-29 11:39 UTC (permalink / raw)
  To: gcc-patches

The vectorizer has a very different effect with -mabi=ilp32, and
doesn't emit the expecte diagnostic, so this patch expects it only
under lp64.

2021-03-29  Christophe Lyon  <christophe.lyon@linaro.org>

	gcc/testsuite/
	PR target/96974
	* g++.target/aarch64/sve/pr96974.C: Expect SLP diagnostic only
	under lp64.
---
 gcc/testsuite/g++.target/aarch64/sve/pr96974.C | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/g++.target/aarch64/sve/pr96974.C b/gcc/testsuite/g++.target/aarch64/sve/pr96974.C
index 363241d..54000f5 100644
--- a/gcc/testsuite/g++.target/aarch64/sve/pr96974.C
+++ b/gcc/testsuite/g++.target/aarch64/sve/pr96974.C
@@ -15,4 +15,4 @@ struct c {
     int coeffs[10];
 } f;
 
-/* { dg-final { scan-tree-dump "Not vectorized: Incompatible number of vector subparts between" "slp1" } } */
+/* { dg-final { scan-tree-dump "Not vectorized: Incompatible number of vector subparts between" "slp1" { target lp64 } } } */
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] testsuite/aarch64: Skip SLP diagnostic under ILP32 (PR target/96974)
  2021-03-29 11:39 [PATCH] testsuite/aarch64: Skip SLP diagnostic under ILP32 (PR target/96974) Christophe Lyon
@ 2021-03-31 10:07 ` Richard Biener
  2021-03-31 14:00   ` Christophe Lyon
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Biener @ 2021-03-31 10:07 UTC (permalink / raw)
  To: Christophe Lyon; +Cc: GCC Patches

On Mon, Mar 29, 2021 at 1:40 PM Christophe Lyon via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> The vectorizer has a very different effect with -mabi=ilp32, and
> doesn't emit the expecte diagnostic, so this patch expects it only
> under lp64.

OK (please also backport as necessary)

> 2021-03-29  Christophe Lyon  <christophe.lyon@linaro.org>
>
>         gcc/testsuite/
>         PR target/96974
>         * g++.target/aarch64/sve/pr96974.C: Expect SLP diagnostic only
>         under lp64.
> ---
>  gcc/testsuite/g++.target/aarch64/sve/pr96974.C | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/g++.target/aarch64/sve/pr96974.C b/gcc/testsuite/g++.target/aarch64/sve/pr96974.C
> index 363241d..54000f5 100644
> --- a/gcc/testsuite/g++.target/aarch64/sve/pr96974.C
> +++ b/gcc/testsuite/g++.target/aarch64/sve/pr96974.C
> @@ -15,4 +15,4 @@ struct c {
>      int coeffs[10];
>  } f;
>
> -/* { dg-final { scan-tree-dump "Not vectorized: Incompatible number of vector subparts between" "slp1" } } */
> +/* { dg-final { scan-tree-dump "Not vectorized: Incompatible number of vector subparts between" "slp1" { target lp64 } } } */
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] testsuite/aarch64: Skip SLP diagnostic under ILP32 (PR target/96974)
  2021-03-31 10:07 ` Richard Biener
@ 2021-03-31 14:00   ` Christophe Lyon
  0 siblings, 0 replies; 3+ messages in thread
From: Christophe Lyon @ 2021-03-31 14:00 UTC (permalink / raw)
  To: Richard Biener; +Cc: GCC Patches

On Wed, 31 Mar 2021 at 12:08, Richard Biener <richard.guenther@gmail.com> wrote:
>
> On Mon, Mar 29, 2021 at 1:40 PM Christophe Lyon via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
> > The vectorizer has a very different effect with -mabi=ilp32, and
> > doesn't emit the expecte diagnostic, so this patch expects it only
> > under lp64.
>
> OK (please also backport as necessary)
>
Thanks, pushed to trunk and gcc-10

Christophe

> > 2021-03-29  Christophe Lyon  <christophe.lyon@linaro.org>
> >
> >         gcc/testsuite/
> >         PR target/96974
> >         * g++.target/aarch64/sve/pr96974.C: Expect SLP diagnostic only
> >         under lp64.
> > ---
> >  gcc/testsuite/g++.target/aarch64/sve/pr96974.C | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gcc/testsuite/g++.target/aarch64/sve/pr96974.C b/gcc/testsuite/g++.target/aarch64/sve/pr96974.C
> > index 363241d..54000f5 100644
> > --- a/gcc/testsuite/g++.target/aarch64/sve/pr96974.C
> > +++ b/gcc/testsuite/g++.target/aarch64/sve/pr96974.C
> > @@ -15,4 +15,4 @@ struct c {
> >      int coeffs[10];
> >  } f;
> >
> > -/* { dg-final { scan-tree-dump "Not vectorized: Incompatible number of vector subparts between" "slp1" } } */
> > +/* { dg-final { scan-tree-dump "Not vectorized: Incompatible number of vector subparts between" "slp1" { target lp64 } } } */
> > --
> > 2.7.4
> >

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-31 14:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 11:39 [PATCH] testsuite/aarch64: Skip SLP diagnostic under ILP32 (PR target/96974) Christophe Lyon
2021-03-31 10:07 ` Richard Biener
2021-03-31 14:00   ` Christophe Lyon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).