From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116502 invoked by alias); 1 Sep 2015 14:12:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 116492 invoked by uid 89); 1 Sep 2015 14:12:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-qk0-f182.google.com Received: from mail-qk0-f182.google.com (HELO mail-qk0-f182.google.com) (209.85.220.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 01 Sep 2015 14:12:32 +0000 Received: by qkcj187 with SMTP id j187so41118813qkc.2 for ; Tue, 01 Sep 2015 07:12:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=nS5T+7viFzbU3QWw1ChU2AI/QgS4esCKOOJ4Gc0hskc=; b=iMYrRWRCmsvyAnX3UgpoJXCiX6gt1J4W6Oph+Y0MPe0ciHJjXWRgdiRFikB4irgNxw L6QATPm96ZAnAq2NVWVV101yK1WWiGIYChBPqLWyzuAmW4PIwgHnGo6G9tDKN9f8nZa/ Gbn80cgrVPTHd0Z9pfR6afln7LFkIgHFOqCfPzJ3SbIGkYgjSBIXxUMfIKOhBBhPDegB MeEOjvAT5EJPcoYoqYVtsj2dLx6NJFf928blY29ejzxskdGjMCM9BzafRbDnpdSQCXZ6 1Vy0To1aUvjqcGmeW/vBUTvfyrPzL4NFdjYAXgb2j3pUkHM1cmXR9f91WOQYZlKaaQLF 8kIg== X-Gm-Message-State: ALoCoQnqhGl3AaT9V4cZ8E2BtTIWk3hUVvVcszU2TJNUKXC5YcfciHeDC7th68WZv+0QV/qGQR4R MIME-Version: 1.0 X-Received: by 10.55.48.5 with SMTP id w5mr18186547qkw.94.1441116286882; Tue, 01 Sep 2015 07:04:46 -0700 (PDT) Received: by 10.140.96.71 with HTTP; Tue, 1 Sep 2015 07:04:46 -0700 (PDT) In-Reply-To: <14DA89C6-4F95-4A90-847A-6B6E6909475A@comcast.net> References: <14DA89C6-4F95-4A90-847A-6B6E6909475A@comcast.net> Date: Tue, 01 Sep 2015 14:12:00 -0000 Message-ID: Subject: Re: [testsuite] Clean up effective_target cache From: Christophe Lyon To: Mike Stump Cc: "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary=001a114795485c7328051eb00866 X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00058.txt.bz2 --001a114795485c7328051eb00866 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 2144 On 25 August 2015 at 17:31, Mike Stump wrote: > On Aug 25, 2015, at 1:14 AM, Christophe Lyon = wrote: >> Some subsets of the tests override ALWAYS_CXXFLAGS or >> TEST_ALWAYS_FLAGS and perform effective_target support tests using >> these modified flags. > >> This patch adds a new function 'clear_effective_target_cache', which >> is called at the end of every .exp file which overrides >> ALWAYS_CXXFLAGS or TEST_ALWAYS_FLAGS. > > So, a simple English directive somewhere that says, if one changes ALWAYS= _CXXFLAGS or TEST_ALWAYS_FLAGS then they should do a clear_effective_target= _cache at the end as the target cache can make decisions based upon the fla= gs, and those decisions need to be redone when the flags change would be ni= ce. > > I do wonder, do we need to reexamine when setting the flags? I=E2=80=99m= thinking of a sequence like: non-thumb default, is_thumb, set flags (thumb= ), is_thumb. Anyway, safe to punt this until someone discovers it or is re= asonable sure it happens. > > Anyway, all looks good. Ok. > Here is what I have committed (r227372). I updated the comment before clear_effective_target_cache, and copied the directive you suggested above. I also added a test to check if $et_prop_list exists before clearing (there were error messages otherwise). Christophe. >> However, I noticed that lib/g++.exp changes ALWAYS_CXXFLAGS, but does >> not appear to restore it. In doubt, I didn't change it. > > Yeah, I examined it. It seems like it might not matter, as anyone settin= g and unsetting would come in cleared, and if they didn=E2=80=99t, it shoul= d be roughly the same exact state, meaning, no clearing necessary. I think= it is safe to punt this until someone finds a bug or can see a way that it= would matter. I also don=E2=80=99t think it would hurt to clear, if someo= ne wanted to refactor the code a bit and make the clearing and the cleanup = a little more automatic. I=E2=80=99m thinking of a RAII style code in whic= h the dtor runs the clear. Not sure if that is even possible in tcl. [ ch= ecking ] Nope, maybe not. Oh well. --001a114795485c7328051eb00866 Content-Type: text/x-patch; charset=US-ASCII; name="et_cache.patch" Content-Disposition: attachment; filename="et_cache.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ie1ffaye0 Content-length: 8061 MjAxNS0wOS0wMSAgQ2hyaXN0b3BoZSBMeW9uICA8Y2hyaXN0b3BoZS5seW9u QGxpbmFyby5vcmc+CgoJKiBsaWIvdGFyZ2V0LXN1cHBvcnRzLmV4cCAoY2xl YXJfZWZmZWN0aXZlX3RhcmdldF9jYWNoZSk6IE5ldy4KCShjaGVja19jYWNo ZWRfZWZmZWN0aXZlX3RhcmdldCk6IFVwZGF0ZSBldF9wcm9wX2xpc3QuCgkq IGxpYi9hc2FuLWRnLmV4cCAoYXNhbl9maW5pc2gpOiBDYWxsIGNsZWFyX2Vm ZmVjdGl2ZV90YXJnZXRfY2FjaGUuCgkqIGcrKy5kZy9jb21wYXQvY29tcGF0 LmV4cDogTGlrZXdpc2UuCgkqIGcrKy5kZy9jb21wYXQvc3RydWN0LWxheW91 dC0xLmV4cDogTGlrZXdpc2UuCgkqIGxpYi9hc2FuLWRnLmV4cDogTGlrZXdp c2UuCgkqIGxpYi9hdG9taWMtZGcuZXhwOiBMaWtld2lzZS4KCSogbGliL2Np bGstcGx1cy1kZy5leHA6IExpa2V3aXNlLgoJKiBsaWIvY2xlYXJjYXAuZXhw OiBMaWtld2lzZS4KCSogbGliL21weC1kZy5leHA6IExpa2V3aXNlLgoJKiBs aWIvdHNhbi1kZy5leHA6IExpa2V3aXNlLgoJKiBsaWIvdWJzYW4tZGcuZXhw OiBMaWtld2lzZS4KCkluZGV4OiBnY2MvdGVzdHN1aXRlL2crKy5kZy9jb21w YXQvY29tcGF0LmV4cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBnY2Mv dGVzdHN1aXRlL2crKy5kZy9jb21wYXQvY29tcGF0LmV4cAkocmV2aXNpb24g MjI3MzcwKQorKysgZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvY29tcGF0L2NvbXBh dC5leHAJKHdvcmtpbmcgY29weSkKQEAgLTc4LDYgKzc4LDcgQEAgcHJvYyBj b21wYXQtdXNlLXRzdC1jb21waWxlciB7IH0gewogCXNldCBBTFdBWVNfQ1hY RkxBR1MgJHNhdmVfYWx3YXlzX2N4eGZsYWdzCiAJc2V0IGxkX2xpYnJhcnlf cGF0aCAkc2F2ZV9sZF9saWJyYXJ5X3BhdGgKIAlzZXRfbGRfbGlicmFyeV9w YXRoX2Vudl92YXJzCisJY2xlYXJfZWZmZWN0aXZlX3RhcmdldF9jYWNoZQog ICAgIH0KIH0KIApJbmRleDogZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvY29tcGF0 L3N0cnVjdC1sYXlvdXQtMS5leHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvY29tcGF0L3N0cnVjdC1sYXlvdXQt MS5leHAJKHJldmlzaW9uIDIyNzM3MCkKKysrIGdjYy90ZXN0c3VpdGUvZysr LmRnL2NvbXBhdC9zdHJ1Y3QtbGF5b3V0LTEuZXhwCSh3b3JraW5nIGNvcHkp CkBAIC02MSw2ICs2MSw3IEBAIHByb2MgY29tcGF0LXVzZS1hbHQtY29tcGls ZXIgeyB9IHsKIAlzZXQgbGRfbGlicmFyeV9wYXRoICRhbHRfbGRfbGlicmFy eV9wYXRoCiAJc2V0X2xkX2xpYnJhcnlfcGF0aF9lbnZfdmFycwogCXJlc3Rv cmVfZ2NjX2V4ZWNfcHJlZml4X2Vudl92YXIKKwljbGVhcl9lZmZlY3RpdmVf dGFyZ2V0X2NhY2hlCiAgICAgfQogfQogCkluZGV4OiBnY2MvdGVzdHN1aXRl L2xpYi9hc2FuLWRnLmV4cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBn Y2MvdGVzdHN1aXRlL2xpYi9hc2FuLWRnLmV4cAkocmV2aXNpb24gMjI3Mzcw KQorKysgZ2NjL3Rlc3RzdWl0ZS9saWIvYXNhbi1kZy5leHAJKHdvcmtpbmcg Y29weSkKQEAgLTEzOCw2ICsxMzgsNyBAQCBwcm9jIGFzYW5fZmluaXNoIHsg YXJncyB9IHsKICAgICB9CiAgICAgc2V0IGxkX2xpYnJhcnlfcGF0aCAkYXNh bl9zYXZlZF9saWJyYXJ5X3BhdGgKICAgICBzZXRfbGRfbGlicmFyeV9wYXRo X2Vudl92YXJzCisgICAgY2xlYXJfZWZmZWN0aXZlX3RhcmdldF9jYWNoZQog fQogCiAjIFN5bWJvbGl6ZSBsaW5lcyBsaWtlCkluZGV4OiBnY2MvdGVzdHN1 aXRlL2xpYi9hdG9taWMtZGcuZXhwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGdjYy90ZXN0c3VpdGUvbGliL2F0b21pYy1kZy5leHAJKHJldmlzaW9u IDIyNzM3MCkKKysrIGdjYy90ZXN0c3VpdGUvbGliL2F0b21pYy1kZy5leHAJ KHdvcmtpbmcgY29weSkKQEAgLTEwMSw0ICsxMDEsNSBAQCBwcm9jIGF0b21p Y19maW5pc2ggeyBhcmdzIH0gewogICAgIH0gZWxzZSB7CiAJdW5zZXQgVEVT VF9BTFdBWVNfRkxBR1MKICAgICB9CisgICAgY2xlYXJfZWZmZWN0aXZlX3Rh cmdldF9jYWNoZQogfQpJbmRleDogZ2NjL3Rlc3RzdWl0ZS9saWIvY2lsay1w bHVzLWRnLmV4cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBnY2MvdGVz dHN1aXRlL2xpYi9jaWxrLXBsdXMtZGcuZXhwCShyZXZpc2lvbiAyMjczNzAp CisrKyBnY2MvdGVzdHN1aXRlL2xpYi9jaWxrLXBsdXMtZGcuZXhwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMDEsNCArMTAxLDUgQEAgcHJvYyBjaWxrcGx1c19m aW5pc2ggeyBhcmdzIH0gewogICAgIH0gZWxzZSB7CiAJdW5zZXQgVEVTVF9B TFdBWVNfRkxBR1MKICAgICB9CisgICAgY2xlYXJfZWZmZWN0aXZlX3Rhcmdl dF9jYWNoZQogfQpJbmRleDogZ2NjL3Rlc3RzdWl0ZS9saWIvY2xlYXJjYXAu ZXhwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGdjYy90ZXN0c3VpdGUv bGliL2NsZWFyY2FwLmV4cAkocmV2aXNpb24gMjI3MzcwKQorKysgZ2NjL3Rl c3RzdWl0ZS9saWIvY2xlYXJjYXAuZXhwCSh3b3JraW5nIGNvcHkpCkBAIC01 NSw0ICs1NSw1IEBAIHByb2MgY2xlYXJjYXAtZmluaXNoIHsgYXJncyB9IHsK ICAgICB9IGVsc2UgewogCXVuc2V0IFRFU1RfQUxXQVlTX0ZMQUdTCiAgICAg fQorICAgIGNsZWFyX2VmZmVjdGl2ZV90YXJnZXRfY2FjaGUKIH0KSW5kZXg6 IGdjYy90ZXN0c3VpdGUvbGliL21weC1kZy5leHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gZ2NjL3Rlc3RzdWl0ZS9saWIvbXB4LWRnLmV4cAkocmV2 aXNpb24gMjI3MzcwKQorKysgZ2NjL3Rlc3RzdWl0ZS9saWIvbXB4LWRnLmV4 cAkod29ya2luZyBjb3B5KQpAQCAtMTQyLDQgKzE0Miw1IEBAIHByb2MgbXB4 X2ZpbmlzaCB7IGFyZ3MgfSB7CiAgICAgfQogICAgIHNldCBsZF9saWJyYXJ5 X3BhdGggJG1weF9zYXZlZF9saWJyYXJ5X3BhdGgKICAgICBzZXRfbGRfbGli cmFyeV9wYXRoX2Vudl92YXJzCisgICAgY2xlYXJfZWZmZWN0aXZlX3Rhcmdl dF9jYWNoZQogfQpJbmRleDogZ2NjL3Rlc3RzdWl0ZS9saWIvdGFyZ2V0LXN1 cHBvcnRzLmV4cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBnY2MvdGVz dHN1aXRlL2xpYi90YXJnZXQtc3VwcG9ydHMuZXhwCShyZXZpc2lvbiAyMjcz NzApCisrKyBnY2MvdGVzdHN1aXRlL2xpYi90YXJnZXQtc3VwcG9ydHMuZXhw CSh3b3JraW5nIGNvcHkpCkBAIC0xMTcsNiArMTE3LDcgQEAgcHJvYyBjdXJy ZW50X3RhcmdldF9uYW1lIHsgfSB7CiAKIHByb2MgY2hlY2tfY2FjaGVkX2Vm ZmVjdGl2ZV90YXJnZXQgeyBwcm9wIGFyZ3MgfSB7CiAgICAgZ2xvYmFsIGV0 X2NhY2hlCisgICAgZ2xvYmFsIGV0X3Byb3BfbGlzdAogCiAgICAgc2V0IHRh cmdldCBbY3VycmVudF90YXJnZXRfbmFtZV0KICAgICBpZiB7IVtpbmZvIGV4 aXN0cyBldF9jYWNoZSgkcHJvcCx0YXJnZXQpXQpAQCAtMTI0LDEyICsxMjUs MzcgQEAgcHJvYyBjaGVja19jYWNoZWRfZWZmZWN0aXZlX3RhcmdldCB7IHBy bwogCXZlcmJvc2UgImNoZWNrX2NhY2hlZF9lZmZlY3RpdmVfdGFyZ2V0ICRw cm9wOiBjaGVja2luZyAkdGFyZ2V0IiAyCiAJc2V0IGV0X2NhY2hlKCRwcm9w LHRhcmdldCkgJHRhcmdldAogCXNldCBldF9jYWNoZSgkcHJvcCx2YWx1ZSkg W3VwbGV2ZWwgZXZhbCAkYXJnc10KKwlsYXBwZW5kIGV0X3Byb3BfbGlzdCAk cHJvcAorCXZlcmJvc2UgImNoZWNrX2NhY2hlZF9lZmZlY3RpdmVfdGFyZ2V0 IGNhY2hlZCBsaXN0IGlzIG5vdzogJGV0X3Byb3BfbGlzdCIgMgogICAgIH0K ICAgICBzZXQgdmFsdWUgJGV0X2NhY2hlKCRwcm9wLHZhbHVlKQogICAgIHZl cmJvc2UgImNoZWNrX2NhY2hlZF9lZmZlY3RpdmVfdGFyZ2V0ICRwcm9wOiBy ZXR1cm5pbmcgJHZhbHVlIGZvciAkdGFyZ2V0IiAyCiAgICAgcmV0dXJuICR2 YWx1ZQogfQogCisjIENsZWFyIGVmZmVjdGl2ZS10YXJnZXQgY2FjaGUuIFRo aXMgaXMgdXNlZnVsIGFmdGVyIHRlc3RpbmcKKyMgZWZmZWN0aXZlLXRhcmdl dCBmZWF0dXJlcyBhbmQgb3ZlcnJpZGluZyBURVNUX0FMV0FZU19GTEFHUyBh bmQvb3IKKyMgQUxXQVlTX0NYWEZMQUdTLgorIyBJZiBvbmUgY2hhbmdlcyBB TFdBWVNfQ1hYRkxBR1Mgb3IgVEVTVF9BTFdBWVNfRkxBR1MgdGhlbiB0aGV5 IHNob3VsZAorIyBkbyBhIGNsZWFyX2VmZmVjdGl2ZV90YXJnZXRfY2FjaGUg YXQgdGhlIGVuZCBhcyB0aGUgdGFyZ2V0IGNhY2hlIGNhbgorIyBtYWtlIGRl Y2lzaW9ucyBiYXNlZCB1cG9uIHRoZSBmbGFncywgYW5kIHRob3NlIGRlY2lz aW9ucyBuZWVkIHRvIGJlCisjIHJlZG9uZSB3aGVuIHRoZSBmbGFncyBjaGFu Z2UuIEFuIGV4YW1wbGUgb2YgdGhpcyBpcyB0aGUKKyMgYXNhbl9pbml0L2Fz YW5fZmluaXNoIHBhaXIuCisKK3Byb2MgY2xlYXJfZWZmZWN0aXZlX3Rhcmdl dF9jYWNoZSB7IH0geworICAgIGdsb2JhbCBldF9jYWNoZQorICAgIGdsb2Jh bCBldF9wcm9wX2xpc3QKKworICAgIGlmIHtbaW5mbyBleGlzdHMgZXRfcHJv cF9saXN0XX0geworCXZlcmJvc2UgImNsZWFyX2VmZmVjdGl2ZV90YXJnZXRf Y2FjaGU6ICRldF9wcm9wX2xpc3QiIDIKKwlmb3JlYWNoIHByb3AgJGV0X3By b3BfbGlzdCB7CisJICAgIHVuc2V0IGV0X2NhY2hlKCRwcm9wLHZhbHVlKQor CSAgICB1bnNldCBldF9jYWNoZSgkcHJvcCx0YXJnZXQpCisJfQorCXVuc2V0 IGV0X3Byb3BfbGlzdAorICAgIH0KK30KKwogIyBMaWtlIGNoZWNrX2NvbXBp bGUsIGJ1dCBkZWxldGUgdGhlIG91dHB1dCBmaWxlIGFuZCByZXR1cm4gdHJ1 ZSBpZiB0aGUKICMgY29tcGlsZXIgcHJpbnRlZCBubyBtZXNzYWdlcy4KIHBy b2MgY2hlY2tfbm9fY29tcGlsZXJfbWVzc2FnZXNfbm9jYWNoZSB7YXJnc30g ewpJbmRleDogZ2NjL3Rlc3RzdWl0ZS9saWIvdHNhbi1kZy5leHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gZ2NjL3Rlc3RzdWl0ZS9saWIvdHNhbi1k Zy5leHAJKHJldmlzaW9uIDIyNzM3MCkKKysrIGdjYy90ZXN0c3VpdGUvbGli L3RzYW4tZGcuZXhwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDksNCArMTQ5LDUg QEAgcHJvYyB0c2FuX2ZpbmlzaCB7IGFyZ3MgfSB7CiAgICAgfQogICAgIHNl dCBsZF9saWJyYXJ5X3BhdGggJHRzYW5fc2F2ZWRfbGlicmFyeV9wYXRoCiAg ICAgc2V0X2xkX2xpYnJhcnlfcGF0aF9lbnZfdmFycworICAgIGNsZWFyX2Vm ZmVjdGl2ZV90YXJnZXRfY2FjaGUKIH0KSW5kZXg6IGdjYy90ZXN0c3VpdGUv bGliL3Vic2FuLWRnLmV4cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBn Y2MvdGVzdHN1aXRlL2xpYi91YnNhbi1kZy5leHAJKHJldmlzaW9uIDIyNzM3 MCkKKysrIGdjYy90ZXN0c3VpdGUvbGliL3Vic2FuLWRnLmV4cAkod29ya2lu ZyBjb3B5KQpAQCAtMTIxLDQgKzEyMSw1IEBAIHByb2MgdWJzYW5fZmluaXNo IHsgYXJncyB9IHsKICAgICB9CiAgICAgc2V0IGxkX2xpYnJhcnlfcGF0aCAk dWJzYW5fc2F2ZWRfbGlicmFyeV9wYXRoCiAgICAgc2V0X2xkX2xpYnJhcnlf cGF0aF9lbnZfdmFycworICAgIGNsZWFyX2VmZmVjdGl2ZV90YXJnZXRfY2Fj aGUKIH0K --001a114795485c7328051eb00866--