From: Christophe Lyon <christophe.lyon@linaro.org>
To: Jason Merrill <jason@redhat.com>
Cc: Tom Honermann <tom@honermann.net>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [REVISED PATCH 2/9]: C++ P0482R5 char8_t: Core language support
Date: Tue, 15 Jan 2019 06:51:00 -0000 [thread overview]
Message-ID: <CAKdteOZMPuqfJ4ky11CbYTu=8+o5_wjjNTSxkRBcHAzgXV4MBQ@mail.gmail.com> (raw)
In-Reply-To: <afa759eb-1200-1b90-503b-f31058b645a1@redhat.com>
On Mon, 14 Jan 2019 at 20:59, Jason Merrill <jason@redhat.com> wrote:
>
> On 12/23/18 9:27 PM, Tom Honermann wrote:
> > Attached is a revised patch that addresses changes in P0482R6 as well as
> > feedback provided by Jason. Changes from the prior patch include:
> > - Updated the value of the __cpp_char8_t feature test macro to 201811
> > per P0482R6.
> > - Enable char8_t support with -std=c++2a per adoption of P0482R6 in
> > San Diego.
> > - Reverted the unnecessary changes to gcc/gcc/c/c-typeck.c as requested
> > by Jason.
> > - Removed unnecessary checks of 'flag_char8_t' within the C++ front
> > end as requested by Jason.
> > - Corrected the regression spotted by Jason regarding initialization of
> > signed char and unsigned char arrays with string literals.
> > - Made minor changes to the error message emitted for ill-formed
> > initialization of char arrays with UTF-8 string literals. These
> > changes do not yet implement Jason's suggestion; I'll follow up with a
> > separate patch for that due to additional test impact.
> >
> > Tested on x86_64-linux.
>
> I just applied the compiler changes with small modifications, as
> follows; thank you very much for the patches. Jonathan should check in
> the library portion before long.
>
> Jason
Hi,
The new testcase g++.dg/ext/utf-cvt-char8_t.C fails at least on arm and aarch64:
g++.dg/ext/utf-cvt-char8_t.C -std=gnu++14 (test for warnings, line 24)
g++.dg/ext/utf-cvt-char8_t.C -std=gnu++17 (test for warnings, line 24)
Christophe
next prev parent reply other threads:[~2019-01-15 6:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 19:40 [PATCH " Tom Honermann
2018-12-03 21:51 ` Jason Merrill
2018-12-03 22:01 ` Jason Merrill
2018-12-05 7:10 ` Tom Honermann
2018-12-05 16:16 ` Jason Merrill
2018-12-17 21:02 ` Jason Merrill
2018-12-17 21:47 ` Tom Honermann
2018-12-24 2:32 ` Tom Honermann
2018-12-24 2:27 ` [REVISED PATCH " Tom Honermann
2019-01-14 19:59 ` Jason Merrill
2019-01-15 4:08 ` Tom Honermann
2019-01-15 6:51 ` Christophe Lyon [this message]
2019-01-15 15:50 ` Tom Honermann
2019-01-15 18:28 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKdteOZMPuqfJ4ky11CbYTu=8+o5_wjjNTSxkRBcHAzgXV4MBQ@mail.gmail.com' \
--to=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=tom@honermann.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).