From: Christophe Lyon <christophe.lyon@linaro.org>
To: Marc Glisse <marc.glisse@inria.fr>
Cc: Jason Merrill <jason@redhat.com>,
Richard Biener <richard.guenther@gmail.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [RFTesting] New POINTER_DIFF_EXPR
Date: Wed, 22 Nov 2017 09:05:00 -0000 [thread overview]
Message-ID: <CAKdteOZRPowtVP2hsAdF_-oqhUugt33rf6BUQ9a99+aewD3Auw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1711220924480.5760@stedding.saclay.inria.fr>
On 22 November 2017 at 09:29, Marc Glisse <marc.glisse@inria.fr> wrote:
> On Wed, 22 Nov 2017, Marc Glisse wrote:
>
>> On Wed, 22 Nov 2017, Christophe Lyon wrote:
>>
>>> Since you committed this patch (r255021), my cross-builds of GCC for
>>> aarch64-linux-gnu fail while building glibc:
>>>
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/bin/aarch64-none-linux-gnu-gcc
>>> fetch-value.c -c -std=gnu99 -fgnu89-inline -O2 -Wall -Winline -Wundef
>>> -Wwrite-string
>>> s -fmerge-all-constants -frounding-math -g -Wstrict-prototypes -fPIC
>>> -I../include
>>>
>>>
>>> -I/tmp/6857183_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/gl
>>> ibc-1/nptl_db
>>> -I/tmp/6857183_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/glibc-1
>>> -I../sysdeps/unix/sysv/linux/aarch64/nptl -I../sysdeps/unix/sysv/lin
>>> ux/aarch64 -I../sysdeps/unix/sysv/linux/generic
>>> -I../sysdeps/unix/sysv/linux/wordsize-64
>>> -I../nptl/sysdeps/unix/sysv/linux -I../nptl/sysdeps/pthread
>>> -I../sysdeps/pthread -I
>>> ../sysdeps/unix/sysv/linux -I../sysdeps/gnu -I../sysdeps/unix/inet
>>> -I../nptl/sysdeps/unix/sysv -I../sysdeps/unix/sysv
>>> -I../nptl/sysdeps/unix -I../sysdeps/unix -I../sysdeps
>>> /posix -I../sysdeps/aarch64/fpu -I../sysdeps/aarch64/nptl
>>> -I../sysdeps/aarch64 -I../sysdeps/wordsize-64
>>> -I../sysdeps/ieee754/ldbl-128 -I../sysdeps/ieee754/dbl-64/wordsize-6
>>> 4 -I../sysdeps/ieee754/dbl-64 -I../sysdeps/ieee754/flt-32
>>> -I../sysdeps/aarch64/soft-fp -I../sysdeps/ieee754
>>> -I../sysdeps/generic -I../nptl -I.. -I../libio -I. -nostdinc -i
>>> system
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/lib/gcc/aarch64-none-linux-gnu/8.0.0/include
>>> -isystem /tmp/6857183_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc
>>> /tools/lib/gcc/aarch64-none-linux-gnu/8.0.0/include-fixed -isystem
>>>
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/sysroot-aarch64-none-linux-gnu/usr/include
>>> -D_LIBC_REE
>>> NTRANT -include ../include/libc-symbols.h -DPIC -DSHARED
>>> -DNOT_IN_libc=1 -DIS_IN_libthread_db=1 -DIN_LIB=libthread_db -o
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccs
>>> rc/obj-aarch64-none-linux-gnu/glibc-1/nptl_db/fetch-value.os -MD -MP
>>> -MF
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/glibc-1/nptl_db/fetch-
>>> value.os.dt -MT
>>>
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/glibc-1/nptl_db/fetch-value.os
>>> during GIMPLE pass: vrp
>>> fetch-value.c: In function '_td_locate_field':
>>> fetch-value.c:44:1: internal compiler error: Segmentation fault
>>> _td_locate_field (td_thragent_t *ta,
>>> ^~~~~~~~~~~~~~~~
>>> 0xb87c75 crash_signal
>>>
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/toplev.c:325
>>> 0x5b1934 contains_struct_check
>>>
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/tree.h:3459
>>> 0x5b1934 wi::to_wide(tree_node const*)
>>>
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/tree.h:5247
>>> 0xf05557 vr_values::two_valued_val_range_p(tree_node*, tree_node**,
>>> tree_node**)
>>>
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/vr-values.c:4051
>>> 0xf0ee48 vr_values::simplify_stmt_using_ranges(gimple_stmt_iterator*)
>>>
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/vr-values.c:4115
>>> 0xd7068f
>>> substitute_and_fold_dom_walker::before_dom_children(basic_block_def*)
>>>
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/tree-ssa-propagate.c:1073
>>> 0x1204860 dom_walker::walk(basic_block_def*)
>>>
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/domwalk.c:308
>>> 0xd6e805 substitute_and_fold_engine::substitute_and_fold()
>>>
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/tree-ssa-propagate.c:1173
>>> 0xe71b0b vrp_prop::vrp_finalize(bool)
>>>
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/tree-vrp.c:6788
>>> 0xe81667 execute_vrp
>>>
>>> /tmp/6857183_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/tree-vrp.c:6864
>>> Please submit a full bug report,
>>
>>
>> Looks like PR 83104.
>>
>> (I am a bit curious what the code looks like, since the testcase in the PR
>> is rather on the undefined side of things, though ok for something embedded)
>
>
> if (idx != 0 && DB_DESC_NELEM (desc) != 0
> && idx - (psaddr_t) 0 > DB_DESC_NELEM (desc))
>
> "idx - (psaddr_t) 0": glibc should probably avoid doing pointer arithmetic
> with a null pointer, "(ptrdiff_t) idx" looks equivalent.
>
The patch you attached in PR83104 works for me (at least the build
completes, I haven't run the tests)
Thanks,
Christophe
> --
> Marc Glisse
next prev parent reply other threads:[~2017-11-22 8:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-28 14:58 Marc Glisse
2017-11-11 0:11 ` Marc Glisse
2017-11-17 13:13 ` Richard Biener
2017-11-17 14:06 ` Jason Merrill
2017-11-18 9:54 ` Marc Glisse
2017-11-20 0:12 ` Marc Glisse
2017-11-20 14:13 ` Jason Merrill
2017-11-21 17:06 ` Jeff Law
2017-11-22 8:25 ` Christophe Lyon
2017-11-22 8:29 ` Marc Glisse
2017-11-22 8:44 ` Marc Glisse
2017-11-22 9:05 ` Christophe Lyon [this message]
2017-11-26 0:54 ` Gerald Pfeifer
2017-11-27 15:48 ` David Malcolm
2017-11-27 16:08 ` Jakub Jelinek
2017-11-17 17:37 ` Joseph Myers
2017-11-17 17:52 ` Richard Biener
2017-11-17 17:54 ` DJ Delorie
2017-11-17 18:05 ` Joseph Myers
2017-11-18 10:34 ` Marc Glisse
2017-11-18 10:23 ` Marc Glisse
2017-11-17 17:57 ` Joseph Myers
2017-11-18 10:26 ` Marc Glisse
2017-11-18 12:18 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKdteOZRPowtVP2hsAdF_-oqhUugt33rf6BUQ9a99+aewD3Auw@mail.gmail.com \
--to=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=marc.glisse@inria.fr \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).