From: Christophe Lyon <christophe.lyon@linaro.org>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Add noexcept to shared_ptr owner comparisons (LWG 2873)
Date: Tue, 05 Sep 2017 06:30:00 -0000 [thread overview]
Message-ID: <CAKdteOZaxTZapFum8bupdxcWn2NQdG+q3M4=Z7w6BF_V6_DPQQ@mail.gmail.com> (raw)
In-Reply-To: <20170605093423.GA11607@redhat.com>
Hi Jonathan
On 5 June 2017 at 11:34, Jonathan Wakely <jwakely@redhat.com> wrote:
> C++17 requires these to be noexcept, and there's no reason not to do
> it for earlier standard modes too.
>
> * include/bits/shared_ptr_base.h (__shared_ptr::owner_before)
> (__weak_ptr::owner_before, _Sp_owner_less::operator()): Add noexcept
> specifiers as per LWG 2873 and LWG 2942.
> * testsuite/20_util/owner_less/noexcept.cc: New.
> * testsuite/20_util/shared_ptr/observers/owner_before.cc: Test
> noexcept guarantees.
> * testsuite/20_util/weak_ptr/observers/owner_before.cc: Likewise.
>
> Tested powerpc64le-linux, committed to trunk.
>
I've noticed you have backported this patch to gcc-6-branch (r251673).
The new test testsuite/20_util/owner_less/noexcept.cc fails with:
/libstdc++-v3/testsuite/20_util/owner_less/noexcept.cc:34: error:
aggregate 'const std::owner_less<void> ov' has incomplete type and
cannot be defined
Christophe
next prev parent reply other threads:[~2017-09-05 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 9:34 Jonathan Wakely
2017-09-05 6:30 ` Christophe Lyon [this message]
2017-09-05 10:31 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKdteOZaxTZapFum8bupdxcWn2NQdG+q3M4=Z7w6BF_V6_DPQQ@mail.gmail.com' \
--to=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).