From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87966 invoked by alias); 23 May 2019 10:38:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 87952 invoked by uid 89); 23 May 2019 10:38:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=christophe, rights X-HELO: mail-lf1-f66.google.com Received: from mail-lf1-f66.google.com (HELO mail-lf1-f66.google.com) (209.85.167.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 May 2019 10:38:25 +0000 Received: by mail-lf1-f66.google.com with SMTP id m15so3403446lfh.4 for ; Thu, 23 May 2019 03:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mS5CpAttdjQDFUSAV5+Oss0/iICzIuCOWkts/J/KZ14=; b=YRyKYYRcCYSuTEGfehLFesO3iuNOt7WG/vsFKYro/I/pXx29S1tp8Wfmj56Clot789 NcAZCSLSyPxEynQ9nKE0uRPqHlaIfUw85yYBDCe1VC5zlITYG+CJc3K8qA0VQtBnBmr7 Ff3iOfW/1pz9ZMkwCUD6FkIAvgvEA+YyXZIISQp2predGzcJCjKCFcb7k4CCYU2YozXH PJtLjTPAhAwWHcs/5m4XH57KkNsO9FRgFjbmPWuDxr679v6ZUi7oiSgLRuTpUFuUOmfW LyQuj36ai7GPYMxIo3lk+eF1jFEeRLcfA1HQiuQjWItwYCuWy+JS5A/guUCYJkvBn406 bCyw== MIME-Version: 1.0 References: <7f75732b-08d4-09bd-a495-e6f38c79a450@codethink.co.uk> <3456942d-1fe5-0044-a216-198717d3f600@codethink.co.uk> In-Reply-To: From: Christophe Lyon Date: Thu, 23 May 2019 10:38:00 -0000 Message-ID: Subject: Re: *ping* Re: [PATCH] PR fortran/89100 Default widths for i, f and g format specifiers in format strings To: Janne Blomqvist Cc: Mark Eggleston , gcc-patches , fortran Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg01578.txt.bz2 On Wed, 22 May 2019 at 13:57, Janne Blomqvist wrote: > > On Wed, May 22, 2019 at 10:58 AM Mark Eggleston > wrote: > > > > On 13/05/2019 10:45, Mark Eggleston wrote: > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89100 see comment 4 > > > > > > Please can someone commit the attached patch as I do not have commit > > > rights. > > > > > > Change logs: > > > > > > For gcc/fortran > > > > > > Jeff Law > > > Mark Eggleston > > > > > > PR fortran/89100 > > > * gfortran.texi: Add Default widths for F, G and I format descriptors > > > to Extensions section. > > > * invoke.texi: Add -fdec-format-defaults > > > * io.c (check_format): Use default widths for i, f and g when > > > flag_dec_format_defaults is enabled. > > > * lang.opt: Add new option. > > > * options.c (set_dec_flags): Add SET_BITFLAG for > > > flag_dec_format_defaults. > > > > > > For gcc/testsuite > > > > > > Mark Eggleston > > > > > > PR fortran/89100 > > > * gfortran.dg/fmt_f_default_field_width_1.f90: New test. > > > * gfortran.dg/fmt_f_default_field_width_2.f90: New test. > > > * gfortran.dg/fmt_f_default_field_width_3.f90: New test. > > > * gfortran.dg/fmt_g_default_field_width_1.f90: New test. > > > * gfortran.dg/fmt_g_default_field_width_2.f90: New test. > > > * gfortran.dg/fmt_g_default_field_width_3.f90: New test. > > > * gfortran.dg/fmt_i_default_field_width_1.f90: New test. > > > * gfortran.dg/fmt_i_default_field_width_2.f90: New test. > > > * gfortran.dg/fmt_i_default_field_width_3.f90: New test. > > > > > > For libgfortran > > > > > > Jeff Law > > > > > > PR fortran/89100 > > > * io/format.c (parse_format_list): set default width when the > > > IOPARM_DT_DEC_EXT flag is set for i, f and g. > > > * io/io.h: add default_width_for_integer, default_width_for_float > > > and default_precision_for_float. > > > * io/write.c (write_boz): extra parameter giving length of data > > > corresponding to the type's kind. > > > (write_b): pass data length as extra parameter in calls to write_boz. > > > (write_o): pass data length as extra parameter in calls to write_boz. > > > (write_z): pass data length as extra parameter in calls to write_boz. > > > (size_from_kind): also set size is default width is set. > > > * io/write_float.def (build_float_string): new paramter inserted > > > before > > > result parameter. If default width use values passed instead of the > > > values in fnode. > > > (FORMAT_FLOAT): macro modified to check for default width and > > > calls to > > > build_float_string to pass in default width. > > > (get_float_string): set width and precision to defaults when needed. > > > > > > > > ping? > > > Committed as r271511. > Hi, I've noticed new failures on arm: gfortran.dg/fmt_f_default_field_width_1.f90 -O0 (test for excess errors) gfortran.dg/fmt_f_default_field_width_1.f90 -O1 (test for excess errors) gfortran.dg/fmt_f_default_field_width_1.f90 -O2 (test for excess errors) gfortran.dg/fmt_f_default_field_width_1.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (test for excess errors) gfortran.dg/fmt_f_default_field_width_1.f90 -O3 -g (test for excess errors) gfortran.dg/fmt_f_default_field_width_1.f90 -Os (test for excess errors) gfortran.dg/fmt_f_default_field_width_2.f90 -O0 (test for excess errors) gfortran.dg/fmt_f_default_field_width_2.f90 -O1 (test for excess errors) gfortran.dg/fmt_f_default_field_width_2.f90 -O2 (test for excess errors) gfortran.dg/fmt_f_default_field_width_2.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (test for excess errors) gfortran.dg/fmt_f_default_field_width_2.f90 -O3 -g (test for excess errors) gfortran.dg/fmt_f_default_field_width_2.f90 -Os (test for excess errors) gfortran.dg/fmt_f_default_field_width_3.f90 -O (test for excess errors) gfortran.dg/fmt_g_default_field_width_1.f90 -O0 (test for excess errors) gfortran.dg/fmt_g_default_field_width_1.f90 -O1 (test for excess errors) gfortran.dg/fmt_g_default_field_width_1.f90 -O2 (test for excess errors) gfortran.dg/fmt_g_default_field_width_1.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (test for excess errors) gfortran.dg/fmt_g_default_field_width_1.f90 -O3 -g (test for excess errors) gfortran.dg/fmt_g_default_field_width_1.f90 -Os (test for excess errors) gfortran.dg/fmt_g_default_field_width_2.f90 -O0 (test for excess errors) gfortran.dg/fmt_g_default_field_width_2.f90 -O1 (test for excess errors) gfortran.dg/fmt_g_default_field_width_2.f90 -O2 (test for excess errors) gfortran.dg/fmt_g_default_field_width_2.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (test for excess errors) gfortran.dg/fmt_g_default_field_width_2.f90 -O3 -g (test for excess errors) gfortran.dg/fmt_g_default_field_width_2.f90 -Os (test for excess errors) gfortran.dg/fmt_g_default_field_width_3.f90 -O (test for excess errors) The logs contain: /gcc/testsuite/gfortran.dg/fmt_f_default_field_width_1.f90:15:11: Error: Kind 16 not supported for type REAL at (1) Christophe > -- > Janne Blomqvist