From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6499 invoked by alias); 28 Jun 2017 09:17:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5139 invoked by uid 89); 28 Jun 2017 09:17:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-ua0-f180.google.com Received: from mail-ua0-f180.google.com (HELO mail-ua0-f180.google.com) (209.85.217.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 09:17:56 +0000 Received: by mail-ua0-f180.google.com with SMTP id g40so34003251uaa.3 for ; Wed, 28 Jun 2017 02:17:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LguQIG8kLKb0t53a0CvZSiSWz0F+w+F8RF4h7dlz6mY=; b=iTOm2LEAUZCaz0z/Fr2jYRqHmdp+LPCQXKWRsVobvvgKQFMnEUweJy9o2rVrfero/C XTceSrwHzPRaMYzlOVy/BxeoVOnEV9lgW+26fkKLmTHR8HJaZBNJWk23z0ovE5aSFfet XjEOxOp1QcpOGiKWnJw1ggvGpRhGZJA6fT2OYLfadY5OX5zHvJSVjOyM7EX2UCikmpw0 TwZMle8Rhn6VHBbiq7mmd4oUhv6sw52Ps+sijTulFBhmJf+s1wbq5w4q20xrC2UcsDQh /JnV0RM0z5W0nWa7p7zsmu7amprCMM8Berba3mU8ZxazMMhwtEHcOAxIpjdeAW1edV3h 0W+A== X-Gm-Message-State: AKS2vOzBgafZKLgJazBLLo1xtqY9LJ+SQiIEI3OvvFw8ivKB+ySYwMOq QSGQcmD9LgKgQRSlLMpHIyJyHhZv6ccb X-Received: by 10.176.28.87 with SMTP id o23mr5172523uaj.38.1498641474574; Wed, 28 Jun 2017 02:17:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.148.220 with HTTP; Wed, 28 Jun 2017 02:17:53 -0700 (PDT) In-Reply-To: References: From: Christophe Lyon Date: Wed, 28 Jun 2017 09:17:00 -0000 Message-ID: Subject: Re: Fix genmultilib reuse rule checks for large sets of option combinations To: Andreas Schwab Cc: Joseph Myers , "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary="f403043e48e0bd402f055301a8b0" X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg02132.txt.bz2 --f403043e48e0bd402f055301a8b0 Content-Type: text/plain; charset="UTF-8" Content-length: 902 On 28 June 2017 at 10:14, Andreas Schwab wrote: > On Jun 28 2017, Christophe Lyon wrote: > >> diff --git a/gcc/genmultilib b/gcc/genmultilib >> index 0767e68..e65a0dd 100644 >> --- a/gcc/genmultilib >> +++ b/gcc/genmultilib >> @@ -462,7 +462,7 @@ echo "};" >> # Generate a regular expression to validate option combinations. >> options_re= >> for set in ${options}; do >> - for opt in `echo ${set} | sed -e 's_[/|]_ _g'`; do >> + for opt in `echo ${set} | sed -e 's_[/|]_ _g' | sed -e 's/\+/./g' `; do > > No need to run two seds, just pass -e twice. Also, + isn't special, so > no backslash. > Indeed, thanks. Here is what I have committed (r249730) Christophe > Andreas. > > -- > Andreas Schwab, SUSE Labs, schwab@suse.de > GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 > "And now for something completely different." --f403043e48e0bd402f055301a8b0 Content-Type: text/plain; charset="US-ASCII"; name="genmultilib.chlog.txt" Content-Disposition: attachment; filename="genmultilib.chlog.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j4gsflvq0 Content-length: 167 MjAxNy0wNi0yOCAgQ2hyaXN0b3BoZSBMeW9uICA8Y2hyaXN0b3BoZS5seW9u QGxpbmFyby5vcmc+CgoJKiBnZW5tdWx0aWxpYiAoY29tYmluYXRpb25fc3Bh Y2UpOiBBY2NlcHQgJysnIGluIG9wdGlvbiBuYW1lcy4K --f403043e48e0bd402f055301a8b0 Content-Type: text/plain; charset="US-ASCII"; name="genmultilib.patch.txt" Content-Disposition: attachment; filename="genmultilib.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j4gsfpin1 Content-length: 606 ZGlmZiAtLWdpdCBhL2djYy9nZW5tdWx0aWxpYiBiL2djYy9nZW5tdWx0aWxp YgppbmRleCAwNzY3ZTY4Li4xZGEzYTZlIDEwMDY0NAotLS0gYS9nY2MvZ2Vu bXVsdGlsaWIKKysrIGIvZ2NjL2dlbm11bHRpbGliCkBAIC00NjIsNyArNDYy LDcgQEAgZWNobyAifTsiCiAjIEdlbmVyYXRlIGEgcmVndWxhciBleHByZXNz aW9uIHRvIHZhbGlkYXRlIG9wdGlvbiBjb21iaW5hdGlvbnMuCiBvcHRpb25z X3JlPQogZm9yIHNldCBpbiAke29wdGlvbnN9OyBkbwotICBmb3Igb3B0IGlu IGBlY2hvICR7c2V0fSB8IHNlZCAtZSAnc19bL3xdXyBfZydgOyBkbworICBm b3Igb3B0IGluIGBlY2hvICR7c2V0fSB8IHNlZCAtZSAnc19bL3xdXyBfZycg LWUgJ3MvKy8uL2cnIGA7IGRvCiAgICAgb3B0aW9uc19yZT0iJHtvcHRpb25z X3JlfSR7b3B0aW9uc19yZTorfH0ke29wdH0iCiAgIGRvbmUKIGRvbmUK --f403043e48e0bd402f055301a8b0--