From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37187 invoked by alias); 2 Jun 2017 14:19:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 37164 invoked by uid 89); 2 Jun 2017 14:19:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=1.6, sk:people X-HELO: mail-ua0-f170.google.com Received: from mail-ua0-f170.google.com (HELO mail-ua0-f170.google.com) (209.85.217.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Jun 2017 14:19:15 +0000 Received: by mail-ua0-f170.google.com with SMTP id y4so45564770uay.2 for ; Fri, 02 Jun 2017 07:19:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=CSUApd/fWawjLubwtvTxS3tdTn5Ti7UVbJBFFKwgrds=; b=SwOj7x2ylAYcT3JYurulkuTTspMSTlX5tTf+LXrGlrrbw9JKpqmZOD8KJoS2IXOZzs nASLQIIH0lgLAH0h/Z9k1Tb5WzSR2sPuoZK9Q1lHIGS5c7FS2YMhp4KMBBeqEvDFYtHV y0h7fUqUm/fwWvwxB7Z+ps2FRFJQCEsGJcpSBdiSLo5cU6pGbD36j0wJDy1p1bBjjdvr CiXnEfP/iJjwNmKr6kKN6KQ/ihGQkTpaLOBelAEwAgIpIS2CVPNdlQCAOI1WVSDsf6rV DLymTz6a+DmL+xQFqdhDJwCb6MObYMsJ9bXI35+S9cdGiAxfH/QikocFUAL4xdoOy9vs ioHg== X-Gm-Message-State: AODbwcBG37vlMu8WTedCNNooMtv5Q+e7t03qTmwisL385AHRK9toBhzD yveyHZDdd1wse9+tdQIY5chSd7LxQwMAnUqttg== X-Received: by 10.159.60.82 with SMTP id w18mr1137479uah.19.1496413157315; Fri, 02 Jun 2017 07:19:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.45.5 with HTTP; Fri, 2 Jun 2017 07:19:16 -0700 (PDT) From: Christophe Lyon Date: Fri, 02 Jun 2017 14:19:00 -0000 Message-ID: Subject: [Patch, ARM, testsuite] Add -mfloat-abi=hard to arm_neon_ok To: "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary="f403043644eeae15fc0550fad68c" X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00136.txt.bz2 --f403043644eeae15fc0550fad68c Content-Type: text/plain; charset="UTF-8" Content-length: 2698 Hi, I have recently updated the dejagnu version I use for cross-testing arm and aarch64 toolchains to 1.6+. One of the side effects was mentioned by Jonathan in https://gcc.gnu.org/ml/gcc-patches/2017-05/msg01267.html. Since I use multilibs to test many configurations, I noticed several changes in the results I get. In particular, on arm-none-linux-gnueabihf with -march=armv5t, all the tests that require arm_neon_ok fail to compile because they now use -march=armv5t -mfpu=neon -mfloat-abi=softfp -march=armv7-a, which leads to a failure to include gnu/stubs-soft.h (not present since the target is 'hf'). Previously, -march=armv5t was appended, making the tests unsupported because -mfpu=neon conflicts with -march=armv5t. Now, arm_neon_ok succeeds because it only checks if some preprocessor defines are present. This patch fixes that by including arm_neon.h in arm_neon_ok, such that it fails for unsupported cases. However, since most of these tests should pass instead of becoming unsupported, I have added flag combinations with -mfloat-abi=hard. However, this is not sufficient to make the gcc.target/arm/lto/pr65837* tests pass: they do not require arm_neon_ok, and when I tried to add it, they still failed because these lto tests do not support dg-add-options. My proposal is to add a new check_effective_target_arm_neon_ok_no_float_abi function which tries to use neon without trying to change the -mfloat-abi setting (that is, the same as arm_neon_ok, with only "" and "-mfpu=neon" in the list of flags) . This makes these two lto tests unsupported for non-hf targets (again because gnu/stubs-soft.h is not present). To make them pass on "hf" targets: - I added -mfpu=neon to dg-lto-options in pr65837-attr_0.c, because the fpu attributes in arm_neon.h only work if -mfpu=neon is enabled - I removed dg-suppress-ld-options {-mfpu=neon} from pr65837_0.c, -mfpu=neon is needed for the test to compile with toolchains where the default fpu is not neon (eg vfpv3-d16-fp16) On arm-none-linux-gnueabihf --with-cpu=cortex-a9 --with-fpu=vfp and multilib test flag=-march=armv5t, this patch brings: - 2 UNRESOLVED -> FAIL (gcc.dg/vect/vect-align-1.c) - 14 UNRESOLVED -> XPASS (in gcc.dg/vect/) - 2765 new PASS - 3639 FAIL -> PASS - 1826 UNRESOLVED -> PASS - 102 UNRESOLVED -> XFAIL as visible in the red cell at http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/248552-gnu-stubs9.patch/report-build-info.html (the build-failed line can be ignored, it was caused by a server problem) Sorry, the explanation is almost longer than the patch :-) Is it OK for trunk? (Just realizing that I forgot to document the new functions :( ) Thanks, Christophe --f403043644eeae15fc0550fad68c Content-Type: text/plain; charset="US-ASCII"; name="gnu-stubs9.chlog.txt" Content-Disposition: attachment; filename="gnu-stubs9.chlog.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j3fxqtbi0 Content-length: 704 MjAxNy0wNi0wMiAgQ2hyaXN0b3BoZSBMeW9uICA8Y2hyaXN0b3BoZS5seW9u QGxpbmFyby5vcmc+CgoJKiBsaWIvdGFyZ2V0LXN1cHBvcnRzLmV4cAoJKGNo ZWNrX2VmZmVjdGl2ZV90YXJnZXRfYXJtX25lb25fb2tfbm9jYWNoZSk6IEFk ZCBmbGFncyB3aXRoCgktbWZsb2F0LWFiaT1oYXJkLiBJbmNsdWRlIGFybV9u ZW9uLmguCgkoY2hlY2tfZWZmZWN0aXZlX3RhcmdldF9hcm1fbmVvbl9va19u b19mbG9hdF9hYmlfbm9jYWNoZSk6IE5ldy4KCShjaGVja19lZmZlY3RpdmVf dGFyZ2V0X2FybV9uZW9uX29rX25vX2Zsb2F0X2FiaSk6IE5ldy4KCSogZ2Nj LnRhcmdldC9hcm0vbHRvL3ByNjU4MzdfMC5jOiBSZXF1aXJlCglhcm1fbmVv bl9va19ub19mbG9hdF9hYmkuIEFkZCAtbWZwdT1uZW9uIHRvIGRnLWx0by1v cHRpb25zLgoJKiBnY2MudGFyZ2V0L2FybS9sdG8vcHI2NTgzNy1hdHRyXzAu YzogUmVxdWlyZQoJYXJtX25lb25fb2tfbm9fZmxvYXRfYWJpLiBSZW1vdmUg ZGctc3VwcHJlc3MtbGQtb3B0aW9ucy4K --f403043644eeae15fc0550fad68c Content-Type: text/plain; charset="US-ASCII"; name="gnu-stubs9.patch.txt" Content-Disposition: attachment; filename="gnu-stubs9.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j3fxqyp11 Content-length: 4331 ZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9hcm0vbHRv L3ByNjU4MzctYXR0cl8wLmMgYi9nY2MvdGVzdHN1aXRlL2djYy50YXJnZXQv YXJtL2x0by9wcjY1ODM3LWF0dHJfMC5jCmluZGV4IGViYzVmNDQuLmYwMDQ4 MGIgMTAwNjQ0Ci0tLSBhL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9hcm0v bHRvL3ByNjU4MzctYXR0cl8wLmMKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nY2Mu dGFyZ2V0L2FybS9sdG8vcHI2NTgzNy1hdHRyXzAuYwpAQCAtMSw2ICsxLDcg QEAKIC8qIHsgZGctbHRvLWRvIHJ1biB9ICovCiAvKiB7IGRnLXJlcXVpcmUt ZWZmZWN0aXZlLXRhcmdldCBhcm1fbmVvbl9odyB9ICovCi0vKiB7IGRnLWx0 by1vcHRpb25zIHt7LWZsdG99fSB9ICovCisvKiB7IGRnLXJlcXVpcmUtZWZm ZWN0aXZlLXRhcmdldCBhcm1fbmVvbl9va19ub19mbG9hdF9hYmkgfSAqLwor LyogeyBkZy1sdG8tb3B0aW9ucyB7ey1mbHRvIC1tZnB1PW5lb259fSB9ICov CiAKICNpbmNsdWRlICJhcm1fbmVvbi5oIgogCmRpZmYgLS1naXQgYS9nY2Mv dGVzdHN1aXRlL2djYy50YXJnZXQvYXJtL2x0by9wcjY1ODM3XzAuYyBiL2dj Yy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9hcm0vbHRvL3ByNjU4MzdfMC5jCmlu ZGV4IDZiMmRlZjkuLjVkN2NlYTcgMTAwNjQ0Ci0tLSBhL2djYy90ZXN0c3Vp dGUvZ2NjLnRhcmdldC9hcm0vbHRvL3ByNjU4MzdfMC5jCisrKyBiL2djYy90 ZXN0c3VpdGUvZ2NjLnRhcmdldC9hcm0vbHRvL3ByNjU4MzdfMC5jCkBAIC0x LDcgKzEsNyBAQAogLyogeyBkZy1sdG8tZG8gcnVuIH0gKi8KIC8qIHsgZGct cmVxdWlyZS1lZmZlY3RpdmUtdGFyZ2V0IGFybV9uZW9uX2h3IH0gKi8KKy8q IHsgZGctcmVxdWlyZS1lZmZlY3RpdmUtdGFyZ2V0IGFybV9uZW9uX29rX25v X2Zsb2F0X2FiaSB9ICovCiAvKiB7IGRnLWx0by1vcHRpb25zIHt7LWZsdG8g LW1mcHU9bmVvbn19IH0gKi8KLS8qIHsgZGctc3VwcHJlc3MtbGQtb3B0aW9u cyB7LW1mcHU9bmVvbn0gfSAqLwogCiAjaW5jbHVkZSAiYXJtX25lb24uaCIK IApkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9saWIvdGFyZ2V0LXN1cHBv cnRzLmV4cCBiL2djYy90ZXN0c3VpdGUvbGliL3RhcmdldC1zdXBwb3J0cy5l eHAKaW5kZXggZGVkNjM4My4uNzIwYjEwYiAxMDA2NDQKLS0tIGEvZ2NjL3Rl c3RzdWl0ZS9saWIvdGFyZ2V0LXN1cHBvcnRzLmV4cAorKysgYi9nY2MvdGVz dHN1aXRlL2xpYi90YXJnZXQtc3VwcG9ydHMuZXhwCkBAIC0zNDM0LDggKzM0 MzQsOSBAQCBwcm9jIGNoZWNrX2VmZmVjdGl2ZV90YXJnZXRfYXJtX25lb25f b2tfbm9jYWNoZSB7IH0gewogICAgIGdsb2JhbCBldF9hcm1fbmVvbl9mbGFn cwogICAgIHNldCBldF9hcm1fbmVvbl9mbGFncyAiIgogICAgIGlmIHsgW2No ZWNrX2VmZmVjdGl2ZV90YXJnZXRfYXJtMzJdIH0gewotCWZvcmVhY2ggZmxh Z3MgeyIiICItbWZsb2F0LWFiaT1zb2Z0ZnAiICItbWZwdT1uZW9uIiAiLW1m cHU9bmVvbiAtbWZsb2F0LWFiaT1zb2Z0ZnAiICItbWZwdT1uZW9uIC1tZmxv YXQtYWJpPXNvZnRmcCAtbWFyY2g9YXJtdjctYSJ9IHsKKwlmb3JlYWNoIGZs YWdzIHsiIiAiLW1mbG9hdC1hYmk9c29mdGZwIiAiLW1mcHU9bmVvbiIgIi1t ZnB1PW5lb24gLW1mbG9hdC1hYmk9c29mdGZwIiAiLW1mcHU9bmVvbiAtbWZs b2F0LWFiaT1zb2Z0ZnAgLW1hcmNoPWFybXY3LWEiICItbWZsb2F0LWFiaT1o YXJkIiAiLW1mcHU9bmVvbiAtbWZsb2F0LWFiaT1oYXJkIiAiLW1mcHU9bmVv biAtbWZsb2F0LWFiaT1oYXJkIC1tYXJjaD1hcm12Ny1hIn0gewogCSAgICBp ZiB7IFtjaGVja19ub19jb21waWxlcl9tZXNzYWdlc19ub2NhY2hlIGFybV9u ZW9uX29rIG9iamVjdCB7CisJCSNpbmNsdWRlIDxhcm1fbmVvbi5oPgogCQlp bnQgZHVtbXk7CiAJCSNpZm5kZWYgX19BUk1fTkVPTl9fCiAJCSNlcnJvciBu b3QgTkVPTgpAQCAtMzQ2MCw2ICszNDYxLDM4IEBAIHByb2MgY2hlY2tfZWZm ZWN0aXZlX3RhcmdldF9hcm1fbmVvbl9vayB7IH0gewogCQljaGVja19lZmZl Y3RpdmVfdGFyZ2V0X2FybV9uZW9uX29rX25vY2FjaGVdCiB9CiAKKyMgUmV0 dXJuIDEgaWYgdGhpcyBpcyBhbiBBUk0gdGFyZ2V0IHN1cHBvcnRpbmcgLW1m cHU9bmVvbiB3aXRob3V0IGFueQorIyAtbWZsb2F0LWFiaT0gb3B0aW9uLiAg VXNlZnVsIGluIHRlc3RzIHdoZXJlIGFkZF9vcHRpb25zIGlzIG5vdAorIyBz dXBwb3J0ZWQgKHN1Y2ggYXMgbHRvIHRlc3RzKS4KKworcHJvYyBjaGVja19l ZmZlY3RpdmVfdGFyZ2V0X2FybV9uZW9uX29rX25vX2Zsb2F0X2FiaV9ub2Nh Y2hlIHsgfSB7CisgICAgaWYgeyBbY2hlY2tfZWZmZWN0aXZlX3RhcmdldF9h cm0zMl0gfSB7CisJZm9yZWFjaCBmbGFncyB7IiIgIi1tZnB1PW5lb24ifSB7 CisJICAgIGlmIHsgW2NoZWNrX25vX2NvbXBpbGVyX21lc3NhZ2VzX25vY2Fj aGUgYXJtX25lb25fb2tfbm9fZmxvYXRfYWJpIG9iamVjdCB7CisJCSNpbmNs dWRlIDxhcm1fbmVvbi5oPgorCQlpbnQgZHVtbXk7CisJCSNpZm5kZWYgX19B Uk1fTkVPTl9fCisJCSNlcnJvciBub3QgTkVPTgorCQkjZW5kaWYKKwkJLyog QXZvaWQgdGhlIGNhc2Ugd2hlcmUgYSB0ZXN0IGFkZHMgLW1mcHU9bmVvbiwg YnV0IHRoZSB0b29sY2hhaW4gaXMKKwkJICAgY29uZmlndXJlZCBmb3IgLW1j cHU9YXJtOTI2ZWotcywgZm9yIGV4YW1wbGUuICAqLworCQkjaWYgX19BUk1f QVJDSCA8IDcgfHwgX19BUk1fQVJDSF9QUk9GSUxFID09ICdNJworCQkjZXJy b3IgQXJjaGl0ZWN0dXJlIGRvZXMgbm90IHN1cHBvcnQgTkVPTi4KKwkJI2Vu ZGlmCisJICAgIH0gIiRmbGFncyJdIH0geworCQlyZXR1cm4gMQorCSAgICB9 CisJfQorICAgIH0KKworICAgIHJldHVybiAwCit9CisKK3Byb2MgY2hlY2tf ZWZmZWN0aXZlX3RhcmdldF9hcm1fbmVvbl9va19ub19mbG9hdF9hYmkgeyB9 IHsKKyAgICByZXR1cm4gW2NoZWNrX2NhY2hlZF9lZmZlY3RpdmVfdGFyZ2V0 IGFybV9uZW9uX29rX25vX2Zsb2F0X2FiaSBcCisJCWNoZWNrX2VmZmVjdGl2 ZV90YXJnZXRfYXJtX25lb25fb2tfbm9fZmxvYXRfYWJpX25vY2FjaGVdCit9 CisKIHByb2MgY2hlY2tfZWZmZWN0aXZlX3RhcmdldF9hcm1fY3JjX29rX25v Y2FjaGUgeyB9IHsKICAgICBnbG9iYWwgZXRfYXJtX2NyY19mbGFncwogICAg IHNldCBldF9hcm1fY3JjX2ZsYWdzICItbWFyY2g9YXJtdjgtYStjcmMiCg== --f403043644eeae15fc0550fad68c--