From: Christophe Lyon <christophe.lyon@linaro.org>
To: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
Cc: "Yangfei (Felix)" <felix.yang@huawei.com>,
Michael Collison <michael.collison@linaro.org>,
Tejas Belagod <Tejas.Belagod@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes
Date: Thu, 13 Nov 2014 13:54:00 -0000 [thread overview]
Message-ID: <CAKdteOZtnBhEzCf6_OdkjwMbDSRiSfsQ9RfU=U5Z65i0Q7-8Cg@mail.gmail.com> (raw)
In-Reply-To: <546364B0.9020202@arm.com>
On 12 November 2014 14:46, Ramana Radhakrishnan
<ramana.radhakrishnan@arm.com> wrote:
>
>
> On 12/11/14 13:06, Christophe Lyon wrote:
>>
>> On 12 November 2014 04:50, Yangfei (Felix) <felix.yang@huawei.com> wrote:
>>>>
>>>> On Wed, Oct 22, 2014 at 10:49 PM, Michael Collison
>>>> <michael.collison@linaro.org>
>>>> wrote:
>>>>>
>>>>>
>>>>> Patch that removes extraneous comment attached.
>>>>>
>>>>> The CLZ_DEFINED_VALUE_AT_ZERO macro is hard coded to return 32. For
>>>>> the vector intrinsic vclz this is incorrect and should return the
>>>>> value
>>>>
>>>>
>>>> vclz_{s,u}8 ...
>>>>
>>>>> eight. The CTZ_DEFINED_VALUE_AT_ZERO has the same issue.
>>>>
>>>>
>>>> The patch is ok . Sorry about the delay in reviewing this.
>>>>
>>>> Ramana
>>>>
>>>
>>>
>>> Hello,
>>>
>>> Can anybody backport this patch for the 4.8/4.9 branch? They have
>>> the same issue too. Thanks.
>>>
>>
>> Hi,
>>
>> I can take care of the backport, provided a maintainer such as Ramana
>> approves it first.
>>
>> The original PR (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63365)
>> is against 4.9.2, but the bug was present in 4.8 too.
>>
>> OK to backport it to 4.8 and 4.9?
>>
>
> Ok by me unless an RM objects in the next 24 hours.
>
Committed:
- 4.9 branch: r217488.
- 4.8 branch: r217490.
> Ramana
>
>
>> Thanks,
>>
>> Christophe.
>>
>
prev parent reply other threads:[~2014-11-13 13:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 7:05 Michael Collison
2014-10-09 7:11 ` Andrew Pinski
2014-10-09 7:26 ` Michael Collison
2014-10-09 7:55 ` Tejas Belagod
2014-10-09 7:56 ` Michael Collison
2014-10-22 21:53 ` Michael Collison
2014-10-31 18:44 ` Ramana Radhakrishnan
2014-11-12 3:51 ` Yangfei (Felix)
2014-11-12 12:43 ` Christophe Lyon
2014-11-12 13:11 ` Christophe Lyon
2014-11-12 13:48 ` Ramana Radhakrishnan
2014-11-13 13:54 ` Christophe Lyon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKdteOZtnBhEzCf6_OdkjwMbDSRiSfsQ9RfU=U5Z65i0Q7-8Cg@mail.gmail.com' \
--to=christophe.lyon@linaro.org \
--cc=Tejas.Belagod@arm.com \
--cc=felix.yang@huawei.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=michael.collison@linaro.org \
--cc=ramana.radhakrishnan@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).