From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57163 invoked by alias); 18 Jan 2019 14:46:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 57145 invoked by uid 89); 18 Jan 2019 14:46:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:209.85.217.68, Hx-spam-relays-external:209.85.217.68 X-HELO: mail-vs1-f68.google.com Received: from mail-vs1-f68.google.com (HELO mail-vs1-f68.google.com) (209.85.217.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Jan 2019 14:46:05 +0000 Received: by mail-vs1-f68.google.com with SMTP id h78so8534896vsi.6 for ; Fri, 18 Jan 2019 06:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e0ss+6Lwdl8Y76oyXS7jQhBPt9p+VpGYbGQ8+sWVjSQ=; b=ZDdQSpyDPrsxnB7zr+TEYYKVPamXzgtWk/91cLfj0H8MML0VEtH0J4DXJLCVTiiYbH SdDZVnN9yu9oz+DNiGF/8h3x+r5QrQzG87/FQ8i0YDljcSDp+j8jJNa8RXNpjkktFW0e kUn4GsjiJKgjAZTwo6SihJXjoxYwtxuDoRzPY= MIME-Version: 1.0 References: <50dbd993-f778-a2a4-e63c-1c2b3b85de41@gmail.com> <21994e14-d1b8-e893-72d2-86b9674e0fab@honermann.net> <99ca7332-f658-d5fe-fc42-b4199111ad3d@redhat.com> <5d6f1d8d-0e71-5d8e-d269-ee2aa50ab0b9@redhat.com> In-Reply-To: From: Christophe Lyon Date: Fri, 18 Jan 2019 14:46:00 -0000 Message-ID: Subject: Re: PATCH: Updated error messages for ill-formed cases of array initialization by string literal To: Rainer Orth Cc: Jason Merrill , Joseph Myers , Tom Honermann , Martin Sebor , gcc-patches , Marek Polacek Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg01078.txt.bz2 On Fri, 18 Jan 2019 at 13:52, Rainer Orth wrote: > > Hi Jason, > > > On 1/15/19 12:59 PM, Joseph Myers wrote: > >> On Tue, 15 Jan 2019, Jason Merrill wrote: > >> > >>> I actually incorporated the C++ part of these changes into yesterday's > >>> commit, > >>> using Martin's first suggestion. Here's the adjusted C patch, which I'd like > >>> a C maintainer to approve. > >> > >> The front-end changes are OK. However, in the testcase changes, some of > >> the new expected diagnostics are hardcoding that "unsigned int" is th > >> type of char32_t, which isn't correct for all platforms (for example, it's > >> definitely not the type when int is 16-bit). In principle the same > >> applies to diagnostics hardcoding the choice of char16_t, although > >> variations are at least less likely there. > > > > This updated patch removes {short ,}unsigned int from the expected > > diagnostics. And also improves error_init to accept additional arguments, > > like pedwarn_init already does. > > > > Tested x86_64-pc-linux-gnu. > > there are now a couple of failures on several (32-bit?) targets: > > +FAIL: gcc.dg/utf-array.c (test for errors, line 15) > +FAIL: gcc.dg/utf-array.c (test for errors, line 21) > +FAIL: gcc.dg/utf-array.c (test for errors, line 33) > > I'm seeing it on i386-pc-solaris2.11 (32-bit only), and there are also > gcc-testresults reports on i686-pc-linux-gnu, m68k-unknown-linux-gnu, > and x86_64-pc-linux-gnu. > Seeing similar errors on arm and aarch64 too. > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University