From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <christophe.lyon@linaro.org>
Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com
 [IPv6:2607:f8b0:4864:20::344])
 by sourceware.org (Postfix) with ESMTPS id 408A73857838
 for <gcc-patches@gcc.gnu.org>; Tue, 13 Oct 2020 14:01:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 408A73857838
Received: by mail-ot1-x344.google.com with SMTP id e20so21556otj.11
 for <gcc-patches@gcc.gnu.org>; Tue, 13 Oct 2020 07:01:18 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=Q60GNhw9TcDLqeH9lJHSBlDvc1GEMBIa2TXEsZvzuck=;
 b=KChyHfE9IciThW0TcMzCTjEOXo/cPiApCx0UU/RHV5k/SjXT0F84bf2gFsOF+au7Lb
 rcxroGMw/L50S+znWi2QmfDlaaAYVYxlewlNTLUOwwTLJgk13tdYQzHKueyvzaBDomKt
 l+yjBU9Huw1J05bG3/Xcc2kSRahaYtJ8ljCn1eS76QGa5hLyq0RwUaUO0kXxE8nHVzn5
 OMZQLFP5bmTGQPuoeuwj7236eWqlvoTd8hb7rJFuad6aNKhTJeW8D+x6CSROo4bjjfAg
 P4/jpknmxKRwr1R0hHdCSjXkcT5LjY9riDDT3NTRu8h9njxsaxuq48Wt4q8+3tW0a0YN
 QSew==
X-Gm-Message-State: AOAM531PV0eDqPbQPbFQ4d35pAJRd4/TEZgE/hHjyeu45eadD5KVW6AB
 Hy9dGdtptTsDJhKqJR05sZvikupswRPSgNmRyj5bxg==
X-Google-Smtp-Source: ABdhPJyKIbnpytbS727OFKQU/lq1+nP1elHeRW40qE7PYOOqeanEk6ATJmEWXQUGpdMDkneA88lPCIuJZIP/UTFOMWw=
X-Received: by 2002:a05:6830:204c:: with SMTP id
 f12mr19862752otp.73.1602597677430; 
 Tue, 13 Oct 2020 07:01:17 -0700 (PDT)
MIME-Version: 1.0
References: <mptr1qse41l.fsf@arm.com>
 <CAKdteOZp51Hw_wyQ4tHaBS3Ca2oS9g1xD1ksYXG_p=sDbqTo5g@mail.gmail.com>
 <mptwnzunsiv.fsf@arm.com>
In-Reply-To: <mptwnzunsiv.fsf@arm.com>
From: Christophe Lyon <christophe.lyon@linaro.org>
Date: Tue, 13 Oct 2020 16:01:06 +0200
Message-ID: <CAKdteOZx6-HpAmCaW-xV_xS9K0w6j+_zy1dK4p0seK9M5DTydg@mail.gmail.com>
Subject: Re: [PATCH] arm: Add a couple of extra stack-protector tests
To: Christophe Lyon <christophe.lyon@linaro.org>,
 gcc Patches <gcc-patches@gcc.gnu.org>, 
 nick clifton <nickc@redhat.com>, Richard Earnshaw <richard.earnshaw@arm.com>, 
 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
 Kyrylo Tkachov <kyrylo.tkachov@arm.com>, 
 Richard Sandiford <richard.sandiford@arm.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_MANYTO, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Oct 2020 14:01:20 -0000

On Tue, 13 Oct 2020 at 15:51, Richard Sandiford
<richard.sandiford@arm.com> wrote:
>
> Christophe Lyon <christophe.lyon@linaro.org> writes:
> > On Wed, 23 Sep 2020 at 20:33, Richard Sandiford
> > <richard.sandiford@arm.com> wrote:
> >>
> >> These tests were inspired by the corresponding aarch64 ones that I just
> >> committed.  They already pass.
> >>
> >> Tested on arm-linux-gnueabi, arm-linux-gnueabihf and armeb-eabi.
> >> OK for trunk?
> >>
> >> Richard
> >>
> >>
> >> gcc/testsuite/
> >>         * gcc.target/arm/stack-protector-5.c: New test.
> >>         * gcc.target/arm/stack-protector-6.c: Likewise.
> >> ---
> >
> > Hi Richard,
> >
> > These new tests fail when compiling for cortex-a15 and cortex-a57...
> > There are 2 "str" instructions generated, the code is much longer than
> > for cortex-a9 for instance.
> >
> > They pass with cortex-a9, cortex-a5 and arm10tdmi.
>
> Gah, thanks for the heads-up.  I've applied the below as obvious
> after testing on arm-linux-gnueabihf and armeb-eabi.
>

Nice, I hadn't thought of that workaround.

> Richard
>