From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99109 invoked by alias); 14 Jun 2017 08:29:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 99099 invoked by uid 89); 14 Jun 2017 08:29:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-ua0-f182.google.com Received: from mail-ua0-f182.google.com (HELO mail-ua0-f182.google.com) (209.85.217.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Jun 2017 08:29:43 +0000 Received: by mail-ua0-f182.google.com with SMTP id 68so72756909uas.0 for ; Wed, 14 Jun 2017 01:29:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=m2Vu32Qs2VJnWKilYLNMkmpP3XgtkBMATxG6pN72UzQ=; b=GWYZK30exkCx2Jkk/N8qLH5r/TgafHDZBsGeahvEPQKodVnDg8uGAs80huSN9d9SPq RswSDWdTBOsSseBRK/Zqn4LMVmfd4wFarERspQ8nBRuCclB7zTgYTMzhtF0D8CTxf7qu tcugFCZpr5l886SJdD0j0ucyvpSu8bOwm9CPXb5hgruMUZ22FA3Q4Y/qYg8Bw2kOJ6l3 Dn9V6NmTolFaRNXX/+8ywnpjntBkKvSvx6DjL3GCOVj21J53V6sQZg7L88zEAbpHLLo5 R1m4+lFg2jp8haHZ48UBcO1QO+SW7VZbMzS3Ly30TRc/amha3F83yIlI309SX7/pZ1hz vGCQ== X-Gm-Message-State: AKS2vOwtBGw6HdGwvRc79HrZUVDa+dxOSppL3gdtPEAxROZfjwHwJG63 UVLGsv3oQ7s0zSAOqy0H1PZJ8P4qq4+b X-Received: by 10.159.49.88 with SMTP id n24mr5230665uab.117.1497428986673; Wed, 14 Jun 2017 01:29:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.50.131 with HTTP; Wed, 14 Jun 2017 01:29:46 -0700 (PDT) In-Reply-To: References: From: Christophe Lyon Date: Wed, 14 Jun 2017 08:29:00 -0000 Message-ID: Subject: Re: [PATCH, GCC/testsuite/ARM] Consistently check for neon in vect effective targets To: Thomas Preudhomme Cc: Kyrill Tkachov , Ramana Radhakrishnan , Richard Earnshaw , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01001.txt.bz2 On 14 June 2017 at 10:25, Thomas Preudhomme wrote: > > > On 13/06/17 20:22, Christophe Lyon wrote: >> >> Hi Thomas, >> >> On 13 June 2017 at 11:08, Thomas Preudhomme >> wrote: >>> >>> Hi, >>> >>> Conditions checked for ARM targets in vector-related effective targets >>> are inconsistent: >>> >>> * sometimes arm*-*-* is checked >>> * sometimes Neon is checked >>> * sometimes arm_neon_ok and sometimes arm_neon is used for neon check >>> * sometimes check_effective_target_* is used, sometimes >>> is-effective-target >>> >>> This patch consolidate all of these check into using is-effective-target >>> arm_neon and when little endian was checked, the check is kept. >>> >>> ChangeLog entry is as follows: >>> >>> *** gcc/testsuite/ChangeLog *** >>> >>> 2017-06-06 Thomas Preud'homme >>> >>> * lib/target-supports.exp (check_effective_target_vect_int): >>> Replace >>> current ARM check by ARM NEON's availability check. >>> (check_effective_target_vect_intfloat_cvt): Likewise. >>> (check_effective_target_vect_uintfloat_cvt): Likewise. >>> (check_effective_target_vect_floatint_cvt): Likewise. >>> (check_effective_target_vect_floatuint_cvt): Likewise. >>> (check_effective_target_vect_shift): Likewise. >>> (check_effective_target_whole_vector_shift): Likewise. >>> (check_effective_target_vect_bswap): Likewise. >>> (check_effective_target_vect_shift_char): Likewise. >>> (check_effective_target_vect_long): Likewise. >>> (check_effective_target_vect_float): Likewise. >>> (check_effective_target_vect_perm): Likewise. >>> (check_effective_target_vect_perm_byte): Likewise. >>> (check_effective_target_vect_perm_short): Likewise. >>> (check_effective_target_vect_widen_sum_hi_to_si_pattern): >>> Likewise. >>> (check_effective_target_vect_widen_sum_qi_to_hi): Likewise. >>> (check_effective_target_vect_widen_mult_qi_to_hi): Likewise. >>> (check_effective_target_vect_widen_mult_hi_to_si): Likewise. >>> (check_effective_target_vect_widen_mult_qi_to_hi_pattern): >>> Likewise. >>> (check_effective_target_vect_widen_mult_hi_to_si_pattern): >>> Likewise. >>> (check_effective_target_vect_widen_shift): Likewise. >>> (check_effective_target_vect_extract_even_odd): Likewise. >>> (check_effective_target_vect_interleave): Likewise. >>> (check_effective_target_vect_multiple_sizes): Likewise. >>> (check_effective_target_vect64): Likewise. >>> (check_effective_target_vect_max_reduc): Likewise. >>> >>> Testing: Testsuite shows no regression when targeting ARMv7-A with >>> -mfpu=neon-fpv4 and -mfloat-abi=hard or when targeting Cortex-M3 with >>> default FPU and float ABI (soft). >>> >> >> That's strange, my testing detects a syntax error: >> >> Executed from: gcc.dg/vect/vect.exp >> gcc.dg/vect/slp-9.c: error executing dg-final: unbalanced close paren > > > Indeed, I can see the missing parenthesis. I've checked again with the sum > file and even with -v -v -v -v dg-cmp-results does not show any regression. > compare_tests does though but is often more noisy (saying some tests having > disappeared and appeared). > This sounds like dg-cmp-results needs to be improved here. I'll do that > first then test a fixed version of the patch. > I did patch compare_tests a while ago such that it catches ERROR message from dejagnu (r240288) > Many thanks for the testing! > >> >> See >> http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/249142-consistent_neon_check/report-build-info.html >> for a full picture. >> >> Note that the cells with "BETTER" seem to be mostly several PASSes >> becoming unsupported. >> >> Thanks, > > > Best regards, > > Thomas