From: Christophe Lyon <christophe.lyon@linaro.org>
To: Tamar Christina <Tamar.Christina@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
"christophe.lyon@st.com" <christophe.lyon@st.com>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
James Greenhalgh <James.Greenhalgh@arm.com>,
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>, nd <nd@arm.com>
Subject: Re: [AArch64][ARM][GCC][PATCHv2 3/3] Add tests for missing Poly64_t intrinsics to GCC
Date: Tue, 08 Nov 2016 11:21:00 -0000 [thread overview]
Message-ID: <CAKdteOa4ZsykDiB+MyXRz5FmeZxWXLHUsLygouegy0+qrXk_pg@mail.gmail.com> (raw)
In-Reply-To: <VI1PR0801MB203111629E51AC006DC2D496FFA70@VI1PR0801MB2031.eurprd08.prod.outlook.com>
On 7 November 2016 at 14:55, Tamar Christina <Tamar.Christina@arm.com> wrote:
> Hi all,
>
> This patch (3 of 3) adds updates tests for the NEON intrinsics
> added by the previous patches:
>
> Ran regression tests on aarch64-none-linux-gnu
> and on arm-none-linux-gnueabihf.
>
> Ok for trunk?
>
> Thanks,
> Tamar
>
>
> gcc/testsuite/
> 2016-11-04 Tamar Christina <tamar.christina@arm.com>
>
> * gcc.target/aarch64/advsimd-intrinsics/p64.c: New.
> * gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h
> (Poly64x1_t, Poly64x2_t): Added type.
> (AARCH64_ONLY): Added macro.
> * gcc.target/aarch64/advsimd-intrinsics/vcombine.c:
> Added test for Poly64.
> * gcc.target/aarch64/advsimd-intrinsics/vcreate.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vdup-vmov.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vdup_lane.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vget_high.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vget_lane.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vget_low.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vldX.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vldX_dup.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vldX_lane.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vstX_lane.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vst1_lane.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vld1.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vreinterpret_p128.c:
> Added AArch64 flags.
> * gcc.target/aarch64/advsimd-intrinsics/vreinterpret_p64.c:
> Added Aarch64 flags.
Hi Tamar,
A while ago I added p64_p128.c, to contain all the poly64/128
tests except for vreinterpret.
Why do you need to create p64.c ?
Similarly, adding tests for vcreate_p64 etc... in p64.c or p64_p128.c
might be easier to maintain than adding them to vcreate.c etc
with several #ifdef conditions.
For vdup-vmod.c, why do you add the "&& defined(__aarch64__)"
condition? These intrinsics are defined in arm/arm_neon.h, right?
They are tested in p64_p128.c
Looking at your patch, it seems some tests are currently missing
for arm: vget_high_p64. I'm not sure why I missed it when I removed
neont-testgen...
Regarding vreinterpret_p128.c, doesn't the existing
effective-target arm_crypto_ok prevent the tests from
running on aarch64?
Thanks,
Christophe
next prev parent reply other threads:[~2016-11-08 11:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 13:55 Tamar Christina
2016-11-08 11:21 ` Christophe Lyon [this message]
2016-11-08 11:59 ` Tamar Christina
2016-11-24 11:45 ` Tamar Christina
2016-11-25 14:54 ` Christophe Lyon
2016-11-25 15:03 ` Christophe Lyon
2016-11-25 16:01 ` Tamar Christina
2016-11-29 9:50 ` Tamar Christina
2016-11-29 10:12 ` Christophe Lyon
2016-11-29 12:58 ` Christophe Lyon
2016-11-29 13:48 ` Kyrill Tkachov
2016-11-29 13:55 ` James Greenhalgh
2016-11-30 9:05 ` Christophe Lyon
2016-11-30 9:40 ` Tamar Christina
2016-12-07 4:34 ` Andrew Pinski
2016-12-12 11:29 ` Tamar Christina
2016-12-12 23:53 ` Andrew Pinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKdteOa4ZsykDiB+MyXRz5FmeZxWXLHUsLygouegy0+qrXk_pg@mail.gmail.com \
--to=christophe.lyon@linaro.org \
--cc=James.Greenhalgh@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Tamar.Christina@arm.com \
--cc=christophe.lyon@st.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).