From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67644 invoked by alias); 18 Aug 2018 22:44:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 67615 invoked by uid 89); 18 Aug 2018 22:44:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=4.1 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPAM_BODY,SPF_PASS autolearn=no version=3.3.2 spammy=ASAP, HTo:U*tkoenig, Hx-languages-length:1489, H*f:sk:2018072 X-HELO: mail-ua1-f48.google.com Received: from mail-ua1-f48.google.com (HELO mail-ua1-f48.google.com) (209.85.222.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 18 Aug 2018 22:44:01 +0000 Received: by mail-ua1-f48.google.com with SMTP id c12-v6so7770647uan.3 for ; Sat, 18 Aug 2018 15:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HmC6ON1HpzUZRua1qc18IirpQIGDiFiRI9LDbFIyjds=; b=HxcUXESOeOwPsJgcM1WWLPpXp+yhTgNYdBD6d5xXF5jrGAmaVNK3d6I1+LfOM0f3gw gTiQV9GKXJs1H68JGdScyU8uTD9QcnQ/dKk66Yn+5TRj2ta8Q4QV7gSBdT2mpTjIKPcB CVqv7W1njcCR19o7mmxwXWqTwaGuwUpjkILVU= MIME-Version: 1.0 References: <20180726133142.DE075D801C7@oc3748833570.ibm.com> <01cd923e-18c7-f745-a75d-49536d56cdbf@netcologne.de> <5B6021C0.5060507@arm.com> <20180802113135.5qmwnfpxwv4dic6z@student.ethz.ch> <20180802170441.aidlg6grthuavogc@student.ethz.ch> <805d5eb8-c014-223e-0590-cd0e1eadb739@netcologne.de> In-Reply-To: <805d5eb8-c014-223e-0590-cd0e1eadb739@netcologne.de> From: Christophe Lyon Date: Sat, 18 Aug 2018 22:44:00 -0000 Message-ID: Subject: Re: Async I/O patch with compilation fix To: Thomas Koenig Cc: koenigni@student.ethz.ch, Andre Simoes Dias Vieira , gcc Patches , fortran@gcc.gnu.org, Ulrich Weigand , David Edelsohn , clyon@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg01105.txt.bz2 On Fri, 17 Aug 2018 at 17:41, Thomas Koenig wrote: > > Hi Christophe, > Hi, > sorry that this took so long, but a holiday followed by a > business trip seven timezones away can do that :-) > Sorry, I am on holidays too, and not back yet :) > > I applied this patch, and again I still see regressions on > > armeb-none-linux-gnueabihf > > --with-cpu cortex-a9 > > --with-fpu neon-fp16 > > The info that you supplied in the PR indicates some sort of library > problem exposed by the patch, possibly by including gthr.h. > > All Nicolas and I could come up with was to remove the async I/O > functionality from armeb-* and by xfailing the tests. > > This is done by > > +#if defined(__GTHREAD_HAS_COND) && defined(__GTHREADS_CXX0X) && > !defined(__ARMEB__) > +#define ASYNC_IO 1 > +#else > +#define ASYNC_IO 0 > +#endif > > If somebody comes up with something more fine-grained for the > feature test, we can put this in now or later. > > Regression-tested on x86_64-pc-linux-gnu (which showed that > xfail lines in the testsuite aren't wildly inaccurate). > > So, I'd appreciate testing. If this passes, this will be > committed ASAP. > I tried this version of the patch, and I'm still seeing the regression on array_constructor_8.f90. I didn't try to run the new tests (I only applied the patch part) I'll try to investigate the PR a bit more when I'm back at the office (e/o August) Christophe > Regards > > Thomas >