From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116841 invoked by alias); 5 Nov 2019 13:06:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 116833 invoked by uid 89); 5 Nov 2019 13:06:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=(unknown) X-HELO: mail-lj1-f180.google.com Received: from mail-lj1-f180.google.com (HELO mail-lj1-f180.google.com) (209.85.208.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Nov 2019 13:06:21 +0000 Received: by mail-lj1-f180.google.com with SMTP id m9so21705824ljh.8 for ; Tue, 05 Nov 2019 05:06:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y1D1SFMok6OhmnWjQzFuWZwQf61xuidw9u5LVeOMCLM=; b=ndbe08MSwYBwq2e2+amCjDzz2kw7sBY4r9eoSZPylT+QjRJz3asLZuLF/AfcgYqf73 hrXF3ik20fQ9R7KJ95m4/sPdudmJDTFZ1rHzUhE7ZWRdyYELCPi7XnqucGKK5e68dcKk 80W/vHWzdTS028IPPL2AqH8daMNWbnH2yFu8PXlKO3Bfu2WWWePWzseqgScW22k3RqVW tx2Nox19uvqBoIUAdjeJ+0WhKanzt9wCEWEl4F+zVTB/rAKXdYMWzwgZm5r1xW+zWkOx ic8P7cavw47WaCJibopjc09dAcLkgZOL2b/5z1axuX56ewBtbNHCp6cSl7JyEwTW//ui OxTw== MIME-Version: 1.0 References: In-Reply-To: From: Christophe Lyon Date: Tue, 05 Nov 2019 13:06:00 -0000 Message-ID: Subject: Re: PR92163 To: Prathamesh Kulkarni Cc: Richard Biener , gcc Patches , Jakub Jelinek Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00273.txt.bz2 On Tue, 5 Nov 2019 at 05:46, Prathamesh Kulkarni wrote: > > On Mon, 4 Nov 2019 at 18:37, Christophe Lyon wrote: > > > > On Mon, 28 Oct 2019 at 16:03, Prathamesh Kulkarni > > wrote: > > > > > > On Mon, 28 Oct 2019 at 07:18, Richard Biener wrote: > > > > > > > > On Fri, Oct 25, 2019 at 9:58 PM Prathamesh Kulkarni > > > > wrote: > > > > > > > > > > On Fri, 25 Oct 2019 at 13:19, Richard Biener wrote: > > > > > > > > > > > > On Wed, Oct 23, 2019 at 11:45 PM Prathamesh Kulkarni > > > > > > wrote: > > > > > > > > > > > > > > Hi, > > > > > > > The attached patch tries to fix PR92163 by calling > > > > > > > gimple_purge_dead_eh_edges from ifcvt_local_dce if we need eh cleanup. > > > > > > > Does it look OK ? > > > > > > > > > > > > Hmm. I think it shows an issue with the return value of remove_stmt_form_eh_lp > > > > > > which is true if the LP index is -1 (externally throwing). We don't > > > > > > need to purge > > > > > > any edges in that case. That is, if-conversion should never need to > > > > > > do EH purging > > > > > > since that would be wrong-code. > > > > > > > > > > > > As of the segfault can you please instead either pass down need_eh_cleanup > > > > > > as function parameter (and NULL from ifcvt) or use the return value in DSE > > > > > > to set the bit in the caller. > > > > > Hi Richard, > > > > > Thanks for the suggestions, does the attached patch look OK ? > > > > > Bootstrap+test in progress on x86_64-unknown-linux-gnu. > > > > > > > > OK. > > > Thanks, committed to trunk in r277525 after bootstrap+test on > > > x86_64-unknown-linux-gnu. > > > > > > > Hi Prathamesh, > > > > There's a problem with the new test you added: if uses -fopenacc which > > is not supported by arm-eabi or aarch64-elf targets for instance. > > You probably want to move the test to gcc.dg/goacc or add > > dg-require-effective-target fopenacc. > Oops, sorry about that. Could you please confirm if attached patch > fixes the issue ? > I added dg-require-effective-target fopenacc. > Yes that works. Maybe you can commit it as obvious? Thanks, Christophe > Thanks, > Prathamesh > > > > Thanks, > > > > Christophe > > > > > Thanks, > > > Prathamesh > > > > > > > > Richard. > > > > > > > > > Thanks, > > > > > Prathamesh > > > > > > > > > > > > Thanks, > > > > > > Richard. > > > > > > > > > > > > > Thanks, > > > > > > > Prathamesh