From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 1C28A3858039 for ; Mon, 10 May 2021 11:21:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1C28A3858039 Received: by mail-pj1-x1031.google.com with SMTP id g24so9564233pji.4 for ; Mon, 10 May 2021 04:21:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=2ofkJZy+uxjQe1PeEjnwwCUO7FJ+xSGVGhj4e/8UunE=; b=G5l4cI/U8q9VBvpOADy9ZWPGdZQkmTs/HERR+LqGxDHR2a85GXyk9+QFtjgGyFG85K nRNlocPxKotaCj+OI8c8RxHDb2+Ep96DDTvII0WQQAxe2DumeQFlmfKM+tmBl1fSeqTI UQSKXjEI8blu423/ure6vm+p8mUS5a32MImBdD1ykBoReJ08XHL9o2P+gygkHnj/CGSq 7nkdFo0rMLUIw1C4SmbHJNjGHqLoj3x5SQoj7VtfLUlTbwMKY4qOJ2LhvZViWX037pxQ Id1cVUdu+/laAHhphEVru4ySrb3/WI1X83SKP8gO/r7frzQ5QHqvItf5cUgEOYQKgK99 eI6g== X-Gm-Message-State: AOAM530qw6CEd4nSAoF6s1TqtcPmCvAg6zJPsZZEpJhlDjZvp/KUPJjN vgbYyB8VKeGCF0+PDy8VTSXVgTgdrhvLGwYxyTdK0VY0XdQ= X-Google-Smtp-Source: ABdhPJyq2vJVjvPrzmL1odDnYl0/2gnonMQUod52sTkRmAsJHo3MI6jg8Wr51cCYFlkKjzrSwceLzwKpDVGbrHc3EKs= X-Received: by 2002:a17:90a:6289:: with SMTP id d9mr27178183pjj.84.1620645710760; Mon, 10 May 2021 04:21:50 -0700 (PDT) MIME-Version: 1.0 References: <1619791790-628-1-git-send-email-christophe.lyon@linaro.org> In-Reply-To: <1619791790-628-1-git-send-email-christophe.lyon@linaro.org> From: Christophe Lyon Date: Mon, 10 May 2021 13:21:40 +0200 Message-ID: Subject: Re: [PATCH 1/9] arm: MVE: Convert vcmp[eq|ne]* in arm_mve.h to use only 's' builtin version To: gcc Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 May 2021 11:21:53 -0000 Ping for the series? On Fri, 30 Apr 2021 at 16:09, Christophe Lyon wrote: > > There is no need to have a signed and an unsigned version of these > builtins. This is similar to what we do for Neon in arm_neon.h. > This mechanical patch enables later cleanup patches. > > 2021-03-01 Christophe Lyon > > gcc/ > * config/arm/arm_mve.h (__arm_vcmpeq*u*, __arm_vcmpne*u*): Call > the 's' version of the builtin. > --- > gcc/config/arm/arm_mve.h | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/gcc/config/arm/arm_mve.h b/gcc/config/arm/arm_mve.h > index 3a40c6e..e4dfe91 100644 > --- a/gcc/config/arm/arm_mve.h > +++ b/gcc/config/arm/arm_mve.h > @@ -3695,21 +3695,21 @@ __extension__ extern __inline mve_pred16_t > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __arm_vcmpneq_u8 (uint8x16_t __a, uint8x16_t __b) > { > - return __builtin_mve_vcmpneq_uv16qi (__a, __b); > + return __builtin_mve_vcmpneq_sv16qi ((int8x16_t)__a, (int8x16_t)__b); > } > > __extension__ extern __inline mve_pred16_t > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __arm_vcmpneq_u16 (uint16x8_t __a, uint16x8_t __b) > { > - return __builtin_mve_vcmpneq_uv8hi (__a, __b); > + return __builtin_mve_vcmpneq_sv8hi ((int16x8_t)__a, (int16x8_t)__b); > } > > __extension__ extern __inline mve_pred16_t > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __arm_vcmpneq_u32 (uint32x4_t __a, uint32x4_t __b) > { > - return __builtin_mve_vcmpneq_uv4si (__a, __b); > + return __builtin_mve_vcmpneq_sv4si ((int32x4_t)__a, (int32x4_t)__b); > } > > __extension__ extern __inline int8x16_t > @@ -3932,7 +3932,7 @@ __extension__ extern __inline mve_pred16_t > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __arm_vcmpneq_n_u8 (uint8x16_t __a, uint8_t __b) > { > - return __builtin_mve_vcmpneq_n_uv16qi (__a, __b); > + return __builtin_mve_vcmpneq_n_sv16qi ((int8x16_t)__a, (int8_t)__b); > } > > __extension__ extern __inline mve_pred16_t > @@ -3953,14 +3953,14 @@ __extension__ extern __inline mve_pred16_t > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __arm_vcmpeqq_u8 (uint8x16_t __a, uint8x16_t __b) > { > - return __builtin_mve_vcmpeqq_uv16qi (__a, __b); > + return __builtin_mve_vcmpeqq_sv16qi ((int8x16_t)__a, (int8x16_t)__b); > } > > __extension__ extern __inline mve_pred16_t > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __arm_vcmpeqq_n_u8 (uint8x16_t __a, uint8_t __b) > { > - return __builtin_mve_vcmpeqq_n_uv16qi (__a, __b); > + return __builtin_mve_vcmpeqq_n_sv16qi ((int8x16_t)__a, (int8_t)__b); > } > > __extension__ extern __inline mve_pred16_t > @@ -4774,7 +4774,7 @@ __extension__ extern __inline mve_pred16_t > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __arm_vcmpneq_n_u16 (uint16x8_t __a, uint16_t __b) > { > - return __builtin_mve_vcmpneq_n_uv8hi (__a, __b); > + return __builtin_mve_vcmpneq_n_sv8hi ((int16x8_t)__a, (int16_t)__b); > } > > __extension__ extern __inline mve_pred16_t > @@ -4795,14 +4795,14 @@ __extension__ extern __inline mve_pred16_t > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __arm_vcmpeqq_u16 (uint16x8_t __a, uint16x8_t __b) > { > - return __builtin_mve_vcmpeqq_uv8hi (__a, __b); > + return __builtin_mve_vcmpeqq_sv8hi ((int16x8_t)__a, (int16x8_t)__b); > } > > __extension__ extern __inline mve_pred16_t > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __arm_vcmpeqq_n_u16 (uint16x8_t __a, uint16_t __b) > { > - return __builtin_mve_vcmpeqq_n_uv8hi (__a, __b); > + return __builtin_mve_vcmpeqq_n_sv8hi ((int16x8_t)__a, (int16_t)__b); > } > > __extension__ extern __inline mve_pred16_t > @@ -5616,7 +5616,7 @@ __extension__ extern __inline mve_pred16_t > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __arm_vcmpneq_n_u32 (uint32x4_t __a, uint32_t __b) > { > - return __builtin_mve_vcmpneq_n_uv4si (__a, __b); > + return __builtin_mve_vcmpneq_n_sv4si ((int32x4_t)__a, (int32_t)__b); > } > > __extension__ extern __inline mve_pred16_t > @@ -5637,14 +5637,14 @@ __extension__ extern __inline mve_pred16_t > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __arm_vcmpeqq_u32 (uint32x4_t __a, uint32x4_t __b) > { > - return __builtin_mve_vcmpeqq_uv4si (__a, __b); > + return __builtin_mve_vcmpeqq_sv4si ((int32x4_t)__a, (int32x4_t)__b); > } > > __extension__ extern __inline mve_pred16_t > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __arm_vcmpeqq_n_u32 (uint32x4_t __a, uint32_t __b) > { > - return __builtin_mve_vcmpeqq_n_uv4si (__a, __b); > + return __builtin_mve_vcmpeqq_n_sv4si ((int32x4_t)__a, (int32_t)__b); > } > > __extension__ extern __inline mve_pred16_t > -- > 2.7.4 >