From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26970 invoked by alias); 3 Dec 2019 08:11:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 26955 invoked by uid 89); 3 Dec 2019 08:11:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*RU:209.85.208.194, HX-Spam-Relays-External:209.85.208.194 X-HELO: mail-lj1-f194.google.com Received: from mail-lj1-f194.google.com (HELO mail-lj1-f194.google.com) (209.85.208.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Dec 2019 08:11:47 +0000 Received: by mail-lj1-f194.google.com with SMTP id e10so2692815ljj.6 for ; Tue, 03 Dec 2019 00:11:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v9tRRz8dpRWKj8eKMfS/jGAO8lCVTIjpNhtfhP08Ym0=; b=rWrrmmM+s+nXgruSBoB6VF9GJLYLLm3aPN1zAyBJC8tUyqnQ9g1VsKa7RRJRexrPPE tDmqJpKVyMPrIklpuvFfRymqrQCoVJ+iBZcayeUO4M3Z92ZNO5jJuMvF0KHVGohQbnlG 3H+SjdfMmS4d8frSCRxkndp8UV3dvkvW+zafxaqU5tQIwH3qCIEaoOdol7RrlWuJUhrI j6FRXZ4GrE99nIFy6pJJS1C+mxfX1ctPI++4frnPywbWF8GoAGdhxrsFexKQikpj2O3P tmvvJFFOIPRcxXv7esur+9nCsGo/E10nRuuippVMnhoir6PpO0XAoiHOMj/rnK+pcwbR Vwbg== MIME-Version: 1.0 References: <23ef4bc4-bae7-662e-d6e7-07a60df053d4@honermann.net> <423ff8de-b0df-71ce-07a9-ee82ae083334@honermann.net> In-Reply-To: <423ff8de-b0df-71ce-07a9-ee82ae083334@honermann.net> From: Christophe Lyon Date: Tue, 03 Dec 2019 08:11:00 -0000 Message-ID: Subject: Re: [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests To: Tom Honermann Cc: "libstdc++@gcc.gnu.org" , gcc-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00105.txt.bz2 On Mon, 16 Sep 2019 at 04:34, Tom Honermann wrote: > > A revised patch is attached that modifies the tests for deleted ostream > inserters to require C++2a. This is required by the revision of patch > 2/4 that adds proper preprocessor conditionals to the definitions. > > Tom. > > On 9/15/19 3:40 PM, Tom Honermann wrote: > > This patch adds new tests to validate new deleted overloads of wchar_t, > > char8_t, char16_t, and char32_t for ordinary and wide formatted > > character and string ostream inserters. > > > > Additionally, new tests are added to validate invocations of u8path with > > sequences of char8_t for both the C++17 and filesystem TS implementations. > > > > libstdc++-v3/ChangeLog: > > > > 2019-09-15 Tom Honermann > > > > * > > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc: > > > > New test to validate deleted overloads of character and string > > inserters for narrow ostreams. > > * > > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc: > > > > New test to validate deleted overloads of character and string > > inserters for wide ostreams. > > * > > libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc: > > New test to validate u8path invocations with sequences of > > char8_t. > > * > > libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc > > > > New test to validate u8path invocations with sequences of > > char8_t. > > Hi, I've noticed that the new test 27_io/filesystem/path/factory/u8path-char8_t.cc fails to compile on arm-none-eabi with default cpu/fpu, because: /tools/arm-none-eabi/bin/ld: /obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/src/.libs/libstdc++.a(string-inst.o): in function `_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_': string-inst.cc:(.text._ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_[_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_]+0xf4): undefined reference to `_ZSt15__alloc_on_moveISaIcEEvRT_S2_' [etc...] The one in experimental is unsupported thanks to // { dg-require-filesystem-ts "" } Should that be added to the version in 27_io? Thanks, Christophe > > Tom. >