From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93407 invoked by alias); 5 Oct 2015 10:07:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 93352 invoked by uid 89); 5 Oct 2015 10:07:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f49.google.com Received: from mail-qg0-f49.google.com (HELO mail-qg0-f49.google.com) (209.85.192.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 05 Oct 2015 10:07:47 +0000 Received: by qgx61 with SMTP id 61so145021385qgx.3 for ; Mon, 05 Oct 2015 03:07:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=LeMQQIB1CLD1A1qgDxSZLw4+7PXDyFdTmjGNRsWpkoU=; b=KmENr/Wm4uZm4T5kC5uAAQeE6sqPxSJUC8wPYYKNzQEHz3eH8tDOFNCw2yK9krLEvf sSUBWiOnZYDmhTRBa+vuX5rfsl9ow/+zYvvV1bUSwJNmntKxePcvyYUP5KQgTIgkvOri 3/vFLdYYq5AqavqeKoTOU8aqDcNIIDKh5C+drUbH+uKIYctMOYLMQcWXhGypeuvz+gGC GeUT70eYhegJJe6UZ0HsPKwW7qN5gbIgFcWCk2psjEdzguFOLbr46Xs/gqGQcrlQF3DJ 4DuDV8TMCGSMS+hsHezMQZaMmn4/vtSvblrQGz4qcjeS6Gp73Lm19MZFxwDMYazcnWwy RJ/Q== X-Gm-Message-State: ALoCoQnlVDwcQpUGM7znIP2kWYse9IBwnAFGf4H/iojbTCvq2Tt+rAR7eW5m8NMFM5ZjggX0f7ju MIME-Version: 1.0 X-Received: by 10.140.232.73 with SMTP id d70mr39381778qhc.72.1444039665288; Mon, 05 Oct 2015 03:07:45 -0700 (PDT) Received: by 10.140.44.10 with HTTP; Mon, 5 Oct 2015 03:07:45 -0700 (PDT) In-Reply-To: <20151001094126.GA23247@arm.com> References: <1443167973-37806-1-git-send-email-james.greenhalgh@arm.com> <1443167973-37806-3-git-send-email-james.greenhalgh@arm.com> <560CEFC3.4080700@arm.com> <20151001094126.GA23247@arm.com> Date: Mon, 05 Oct 2015 10:07:00 -0000 Message-ID: Subject: Re: [Patch 2/2 ARM/AArch64] Add a new Cortex-A53 scheduling model From: Christophe Lyon To: James Greenhalgh Cc: Marcus Shawcroft , "gcc-patches@gcc.gnu.org" , Richard Earnshaw , Kyrylo Tkachov , Ramana Radhakrishnan Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00375.txt.bz2 On 1 October 2015 at 11:41, James Greenhalgh wrote: > On Thu, Oct 01, 2015 at 09:33:07AM +0100, Marcus Shawcroft wrote: >> On 25/09/15 08:59, James Greenhalgh wrote: >> > >> > Hi, >> > >> > This patch introduces a new scheduling model for Cortex-A53. >> > >> > Bootstrapped and tested on arm-none-linux-gnueabi and aarch64-none-linux-gnu >> > and checked with a variety of popular benchmarking and microbenchmarking >> > suites to show a benefit. >> > >> > OK? >> > >> > Thanks, >> > James >> > >> > --- >> > 2015-09-25 James Greenhalgh >> > >> > * config/arm/aarch-common-protos.h >> > (aarch_accumulator_forwarding): New. >> > (aarch_forward_to_shift_is_not_shifted_reg): Likewise. >> > * config/arm/aarch-common.c (aarch_accumulator_forwarding): New. >> > (aarch_forward_to_shift_is_not_shifted_reg): Liekwise. >> > * config/arm/cortex-a53.md: Rewrite. >> > >> >> OK aarch64 with Kyrill's comments fixed. >> /M > > Thanks, > > I had to rebase this over Evandro's recent patch adding neon_ldp/neon_ldp_q > types to the old scheduling model. The rebase was obvious to resolve, and > while I was there I also added the neon_stp/neon_stp_q types which were > missing. > > I've attached what I ultimately committed as revision 228324. I messed up > fixing the ChangeLog typo before commit, so that is revision 228325. > Hi James, Since this commit I can see gcc.target/aarch64/advsimd-intrinsics/vst1_lane.c fail at -O2 /aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1_lane.c: In function 'exec_vst1_lane': /aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1_lane.c:96:1: internal compiler error: output_operand: invalid %-code 0x78f79e output_operand_lossage(char const*, ...) /aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/final.c:3417 0x7934f3 output_asm_insn(char const*, rtx_def**) /aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/final.c:3782 0x793d77 final_scan_insn(rtx_insn*, _IO_FILE*, int, int, int*) /aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/final.c:3029 0x794b3a final(rtx_insn*, _IO_FILE*, int) /aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/final.c:2058 0x7956fb rest_of_handle_final /aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/final.c:4449 0x7956fb execute /aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/final.c:4524 Please submit a full bug report, on aarch64_be. I haven't looked at it in more details though. > Thanks, > James >