From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22287 invoked by alias); 7 Dec 2012 08:35:08 -0000 Received: (qmail 22227 invoked by uid 22791); 7 Dec 2012 08:35:07 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_QE X-Spam-Check-By: sourceware.org Received: from mail-qa0-f47.google.com (HELO mail-qa0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Dec 2012 08:35:01 +0000 Received: by mail-qa0-f47.google.com with SMTP id a19so1726423qad.20 for ; Fri, 07 Dec 2012 00:35:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:x-gm-message-state; bh=s94eFQ1bxmVVaTQQVfORu4uob2asqM3YJlSvQoqmjbM=; b=SMIbxZ0JCaZTWViU/rNoqHgSexlmXcP84VCv0Ghmgcee0ojp8o1zWzYkcYQ1LfjV/I 7qrUuu/4OINkaK7/dVMJIkNqh7rkisDEKYVnuUSIUNdZF9+EdHlnLpUNeAHHsxMCcMmd Oj5HgwzXGcq5HtRCgvfK4KfEnLrrsbvnqzFAEkFF4kzSXcVBxmRjDSvUF4+3qXS+ZXXS yYY+E4OC9FUcMFPwXq7xMvCvt6EZ6+dqRzdEqPq9ukAqxG/NUL/r8TUfWU9ahIBNv8c0 JKg6ZO49HfV22eZszSVpiGwDvtTzfubS6RnjmtrJcYuWXD6+dYxb4fbjszFqFWxqF+mu v2xg== MIME-Version: 1.0 Received: by 10.224.185.138 with SMTP id co10mr7704154qab.97.1354869300129; Fri, 07 Dec 2012 00:35:00 -0800 (PST) Received: by 10.49.84.106 with HTTP; Fri, 7 Dec 2012 00:34:59 -0800 (PST) In-Reply-To: References: Date: Fri, 07 Dec 2012 08:35:00 -0000 Message-ID: Subject: Re: [ARM] Turning off 64bits ops in Neon and gfortran/modulo-scheduling problem From: Christophe Lyon To: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQm4xASw0O4CVndochqSMISd+MjAm1Ci6YXjpSyPTY//wbeqRTJXgjrd2Cewq/9DNmaxlPtg X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-12/txt/msg00454.txt.bz2 Ping? http://gcc.gnu.org/ml/gcc-patches/2012-11/msg02558.html Thanks, Christophe. On 30 November 2012 17:34, Christophe Lyon wrote: > On 29 November 2012 21:59, Joseph S. Myers wrote: >> On Thu, 29 Nov 2012, Christophe Lyon wrote: >> >>> 2012-11-28 Christophe Lyon >>> >>> gcc/ >>> * config/arm/arm-protos.h (tune_params): Add >>> prefer_neon_for_64bits field. >>> * config/arm/arm.c (prefer_neon_for_64bits): New variable. >>> (arm_slowmul_tune): Default prefer_neon_for_64bits to false. >>> (arm_fastmul_tune, arm_strongarm_tune, arm_xscale_tune): Ditto. >>> (arm_9e_tune, arm_v6t2_tune, arm_cortex_tune): Ditto. >>> (arm_cortex_a5_tune, arm_cortex_a15_tune): Ditto. >>> (arm_cortex_a9_tune, arm_fa726te_tune): Ditto. >>> (arm_option_override): Handle -mneon-for-64bits new option. >>> * config/arm/arm.h (TARGET_PREFER_NEON_64BITS): New macro. >>> (prefer_neon_for_64bits): Declare new variable. >>> * config/arm/arm.md (arch): Rename neon_onlya8 and neon_nota8 to >>> avoid_neon_for_64bits and neon_for_64bits. >>> (arch_enabled): Handle new arch types. >>> (one_cmpldi2): Use new arch names. >>> * config/arm/neon.md (adddi3_neon, subdi3_neon, iordi3_neon) >>> (anddi3_neon, xordi3_neon, ashldi3_neon, di3_neon): Use >>> neon_for_64bits instead of nota8 and avoid_neon_for_64bits instead >>> of onlya8. >> >> This ChangeLog entry doesn't appear to mention the arm.opt change. >> Furthermore, the patch seems to be missing any .texi change to document >> the option; any new option needs documentation. You are also missing >> testcases for the testsuite to verify that both enabled and disabled >> states of the option work properly. >> > Indeed, I forgot about the documentation; here is an updated patch. > > Regarding the testcases, as this patch disables transformations > recently introduced, I would have appreciated if testcases had been > associated with them in the 1st place.... This requirement should be > enforced :-) > > Tested with qemu on target arm-none-linux-gnueabi. > > > 2012-11-30 Christophe Lyon > > gcc/ > * config/arm/arm-protos.h (tune_params): Add > prefer_neon_for_64bits field. > * config/arm/arm.c (prefer_neon_for_64bits): New variable. > (arm_slowmul_tune): Default prefer_neon_for_64bits to false. > (arm_fastmul_tune, arm_strongarm_tune, arm_xscale_tune): Ditto. > (arm_9e_tune, arm_v6t2_tune, arm_cortex_tune): Ditto. > (arm_cortex_a5_tune, arm_cortex_a15_tune): Ditto. > (arm_cortex_a9_tune, arm_fa726te_tune): Ditto. > (arm_option_override): Handle -mneon-for-64bits new option. > * config/arm/arm.h (TARGET_PREFER_NEON_64BITS): New macro. > (prefer_neon_for_64bits): Declare new variable. > * config/arm/arm.md (arch): Rename neon_onlya8 and neon_nota8 to > avoid_neon_for_64bits and neon_for_64bits. > (arch_enabled): Handle new arch types. > (one_cmpldi2): Use new arch names. > * config/arm/arm.opt (mneon-for-64bits): Add option. > * config/arm/neon.md (adddi3_neon, subdi3_neon, iordi3_neon) > (anddi3_neon, xordi3_neon, ashldi3_neon, di3_neon): Use > neon_for_64bits instead of nota8 and avoid_neon_for_64bits instead > of onlya8. > * doc/invoke.texi (-mneon-for-64bits): Document. > > gcc/testsuite/ > * gcc.target/arm/neon-for-64bits-1.c: New tests. > * gcc.target/arm/neon-for-64bits-2.c: Likewise.