From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121340 invoked by alias); 23 Nov 2015 13:00:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 121318 invoked by uid 89); 23 Nov 2015 13:00:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qk0-f169.google.com Received: from mail-qk0-f169.google.com (HELO mail-qk0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 23 Nov 2015 13:00:47 +0000 Received: by qkas77 with SMTP id s77so58799499qka.0 for ; Mon, 23 Nov 2015 05:00:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=o2rsJZQVdLyTJEujZloEcz8B1c4w+3qoS5TC+q8NfU8=; b=GF2v7xvSd1IPHYoZG0yRfdSdARvSvA2A6HuICHIPmORF/m4QK/vcoEzgXVMGvDXGpl QC/s6gjfB+T19rQmUCLzipkf3hF74Ma3pcndws+JoSDnqdIuxhfhhIERfoKDvqxkgxKw N1xEp4tNfxBf3P25lSBob2NTORLNGOM6mISuG3H+dhsf42dweH7XEgkiBOvkJruWwUV/ OwyVqbddi/ZnufGNLXLJ9efAOhOS+NuovBDB6PzQNiEQZJxwKqdnPKMqb1cf4dIGZmuR tnmxDn23owZrg40vqzdyiAjQpjdQWmGmXkbrbWo5HuFglX9bMvVbaiv+RY8rllOIxNEi s8wA== X-Gm-Message-State: ALoCoQnpQ6vxVk5B4DXoxco6awOWN5c6V/Nn2X0t2ncxlo+wrvzK/rTXJ0TKLX0B8MjooLFaikTf MIME-Version: 1.0 X-Received: by 10.55.203.151 with SMTP id u23mr25949346qkl.84.1448283645108; Mon, 23 Nov 2015 05:00:45 -0800 (PST) Received: by 10.140.109.200 with HTTP; Mon, 23 Nov 2015 05:00:45 -0800 (PST) In-Reply-To: <20151123124112.GA5675@tucnak.redhat.com> References: <5652C3E0.4030000@partner.samsung.com> <5652C459.8090500@partner.samsung.com> <20151123080753.GS5675@tucnak.redhat.com> <565307B5.3000901@partner.samsung.com> <20151123124112.GA5675@tucnak.redhat.com> Date: Mon, 23 Nov 2015 13:05:00 -0000 Message-ID: Subject: Re: [PATCH 1/2] Libsanitizer merge from upstream r253555. From: Christophe Lyon To: Jakub Jelinek Cc: Maxim Ostapenko , Kostya Serebryany , GCC Patches , Yury Gribov , Vyacheslav Barinov , Slava Garbuzov , Adhemerval Zanella Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg02705.txt.bz2 On 23 November 2015 at 13:41, Jakub Jelinek wrote: > On Mon, Nov 23, 2015 at 03:33:57PM +0300, Maxim Ostapenko wrote: >> + Adhemerval >> >> Christophe, it looks like your kernel headers (asm/ptrace.h) don't contain >> ARM_VFPREGS_SIZE. Do you use old kernel version? > Yes, I do use old kernel headers. I could upgrade them, but I tend to avoid changing versions (binutils, glibc, newlib, kernel headers) unless really necessary. > Unlike LLVM, we do care to support older kernel headers. > So, if it is say a define, you could add > libsanitizer/include/system/linux/ptrace.h > or > libsanitizer/include/system/asm/ptrace.h > that would #include_next the original header and ifdef __arm__ and > that define is not defined (or some other condition, kernel version etc.), > define it. > > Jakub So, given Jakub's answer I'll not upgrade them yet on my side :-)