From: Christophe Lyon <christophe.lyon@linaro.org>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [Patch,Aarch64] Make frame grow downwards
Date: Fri, 28 Jun 2013 11:46:00 -0000 [thread overview]
Message-ID: <CAKdteOadV597TCOe1v3AHoyi9qaKmtgv0XQuEWVuAcmeUqVHDw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
Hi,
Following the discussion on
http://gcc.gnu.org/ml/gcc/2013-05/msg00208.html
here is a patch to change the frame direction.
Passed 'make check' with no regression on aarch64-none-linux-gnu and
with a few UNSUPPORTED -> PASS on aarch64-none-elf (pr34225, pr38616,
pr38902, pr40971, pr46440, pr47766, pr49307, all of which are guarded
by dg-require-effective-target fstack_protector).
OK for trunk?
Thanks,
Christophe.
2013-06-28 Christophe Lyon <christophe.lyon@linaro.org>
* config/aarch64/aarch64.h (FRAME_GROWS_DOWNWARD): Define to 1.
* config/aarch64/aarch64.c (aarch64_initial_elimination_offset):
Add get_frame_size () when eliminating frame pointer.
[-- Attachment #2: aarch64-frame.txt --]
[-- Type: text/plain, Size: 2148 bytes --]
diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index 527b00d..d8f2801 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -1943,7 +1943,7 @@ aarch64_save_or_restore_callee_save_registers (HOST_WIDE_INT offset,
Establish the stack frame by decreasing the stack pointer with a
properly calculated size and, if necessary, create a frame record
filled with the values of LR and previous frame pointer. The
- current FP is also set up is it is in use. */
+ current FP is also set up if it is in use. */
void
aarch64_expand_prologue (void)
@@ -4031,7 +4031,7 @@ aarch64_initial_elimination_offset (unsigned from, unsigned to)
return offset - crtl->outgoing_args_size;
if (from == FRAME_POINTER_REGNUM)
- return cfun->machine->frame.saved_regs_size;
+ return cfun->machine->frame.saved_regs_size + get_frame_size ();
}
if (to == STACK_POINTER_REGNUM)
@@ -4040,6 +4040,7 @@ aarch64_initial_elimination_offset (unsigned from, unsigned to)
{
HOST_WIDE_INT elim = crtl->outgoing_args_size
+ cfun->machine->frame.saved_regs_size
+ + get_frame_size ()
- cfun->machine->frame.fp_lr_offset;
elim = AARCH64_ROUND_UP (elim, STACK_BOUNDARY / BITS_PER_UNIT);
return elim;
diff --git a/gcc/config/aarch64/aarch64.h b/gcc/config/aarch64/aarch64.h
index a08797b..5048258 100644
--- a/gcc/config/aarch64/aarch64.h
+++ b/gcc/config/aarch64/aarch64.h
@@ -434,7 +434,7 @@ enum reg_class
#define INDEX_REG_CLASS CORE_REGS
#define BASE_REG_CLASS POINTER_REGS
-/* Register pairs used to eliminate unneeded registers that point intoi
+/* Register pairs used to eliminate unneeded registers that point into
the stack frame. */
#define ELIMINABLE_REGS \
{ \
@@ -475,7 +475,7 @@ extern enum aarch64_processor aarch64_tune;
/* Stack layout; function entry, exit and calling. */
#define STACK_GROWS_DOWNWARD 1
-#define FRAME_GROWS_DOWNWARD 0
+#define FRAME_GROWS_DOWNWARD 1
#define STARTING_FRAME_OFFSET 0
next reply other threads:[~2013-06-28 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 11:46 Christophe Lyon [this message]
2013-08-30 15:21 ` Christophe Lyon
2013-11-12 4:40 ` Christophe Lyon
2013-11-12 17:38 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKdteOadV597TCOe1v3AHoyi9qaKmtgv0XQuEWVuAcmeUqVHDw@mail.gmail.com \
--to=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).