From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22544 invoked by alias); 4 Sep 2015 14:52:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21805 invoked by uid 89); 4 Sep 2015 14:52:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f46.google.com Received: from mail-qg0-f46.google.com (HELO mail-qg0-f46.google.com) (209.85.192.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 04 Sep 2015 14:52:08 +0000 Received: by qgx61 with SMTP id 61so17657199qgx.3 for ; Fri, 04 Sep 2015 07:52:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=N1KFx8KZ6tC4T+rV1tany7Ipp0Hld+uBnj2hHVfGxy0=; b=QJUgwkGNnx4+Rk6wEGZJmYEwPIBxopwjxwh4UOmN1/DeEWo9A/wtjUMW7isFw5BKOo P7r5NRee4BZCn8sTLgoQw7BBnh7eWlBY5Glh5K7gLVlOQNq0RkQRnEqr84Y+07xi97ce ip9yrava02L/O4Whskrv7B2m2kPz9ptUmQe+VlBOpbIBlbVYojaKcFz6+wjq4h2OACln NrB7NXz4ki5o5W5iwC1BAXGmdICLgeXea7QofjtSBVyuW6M+fAhkEJxF+28nk3zpKHu3 HHNBZJy7h0ymEavWWttaf6j9H9ud17QDNTW5wkTSNy1TwqCqHMb4A7XIKTMtJRZAvp5X YotA== X-Gm-Message-State: ALoCoQn0ANiqf/pFcbJwJi0MkrURWfcgZmtDV/PMopF00TcA8JD0n9lnlK8VKil2KRSyp8BpATj8 MIME-Version: 1.0 X-Received: by 10.140.232.20 with SMTP id d20mr6019480qhc.72.1441378326443; Fri, 04 Sep 2015 07:52:06 -0700 (PDT) Received: by 10.140.96.71 with HTTP; Fri, 4 Sep 2015 07:52:06 -0700 (PDT) In-Reply-To: References: <14DA89C6-4F95-4A90-847A-6B6E6909475A@comcast.net> Date: Fri, 04 Sep 2015 14:54:00 -0000 Message-ID: Subject: Re: [testsuite] Clean up effective_target cache From: Christophe Lyon To: "H.J. Lu" Cc: Mike Stump , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00356.txt.bz2 On 4 September 2015 at 15:58, H.J. Lu wrote: > On Fri, Sep 4, 2015 at 6:15 AM, Christophe Lyon > wrote: >> On 4 September 2015 at 14:13, H.J. Lu wrote: >>> On Fri, Sep 4, 2015 at 4:47 AM, H.J. Lu wrote: >>>> On Fri, Sep 4, 2015 at 4:27 AM, H.J. Lu wrote: >>>>> On Fri, Sep 4, 2015 at 4:18 AM, H.J. Lu wrote: >>>>>> On Thu, Sep 3, 2015 at 8:03 AM, Christophe Lyon >>>>>> wrote: >>>>>>> On 3 September 2015 at 13:31, H.J. Lu wrote: >>>>>>>> On Wed, Sep 2, 2015 at 7:02 AM, Christophe Lyon >>>>>>>> wrote: >>>>>>>>> On 1 September 2015 at 16:04, Christophe Lyon >>>>>>>>> wrote: >>>>>>>>>> On 25 August 2015 at 17:31, Mike Stump w= rote: >>>>>>>>>>> On Aug 25, 2015, at 1:14 AM, Christophe Lyon wrote: >>>>>>>>>>>> Some subsets of the tests override ALWAYS_CXXFLAGS or >>>>>>>>>>>> TEST_ALWAYS_FLAGS and perform effective_target support tests u= sing >>>>>>>>>>>> these modified flags. >>>>>>>>>>> >>>>>>>>>>>> This patch adds a new function 'clear_effective_target_cache',= which >>>>>>>>>>>> is called at the end of every .exp file which overrides >>>>>>>>>>>> ALWAYS_CXXFLAGS or TEST_ALWAYS_FLAGS. >>>>>>>>>>> >>>>>>>>>>> So, a simple English directive somewhere that says, if one chan= ges ALWAYS_CXXFLAGS or TEST_ALWAYS_FLAGS then they should do a clear_effect= ive_target_cache at the end as the target cache can make decisions based up= on the flags, and those decisions need to be redone when the flags change w= ould be nice. >>>>>>>>>>> >>>>>>>>>>> I do wonder, do we need to reexamine when setting the flags? I= =E2=80=99m thinking of a sequence like: non-thumb default, is_thumb, set fl= ags (thumb), is_thumb. Anyway, safe to punt this until someone discovers i= t or is reasonable sure it happens. >>>>>>>>>>> >>>>>>>>>>> Anyway, all looks good. Ok. >>>>>>>>>>> >>>>>>>>>> Here is what I have committed (r227372). >>>>>>>>> >>>>>>>>> Hmmm, in fact this was r227401. >>>>>>>>> >>>>>>>> >>>>>>>> It caused: >>>>>>>> >>>>>>>> ERROR: can't unset "et_cache(arm_neon_ok,value)": no such element = in array >>>>>>>> ERROR: can't unset "et_cache(arm_neon_ok,value)": no such element = in array >>>>>>>> ERROR: can't unset "et_cache(arm_neon_ok,value)": no such element = in array >>>>>>>> ERROR: can't unset "et_cache(dfp,value)": no such element in array >>>>>>>> ERROR: can't unset "et_cache(fsanitize_address,value)": no such el= ement in array >>>>>>>> ERROR: can't unset "et_cache(ia32,value)": no such element in array >>>>>>>> ERROR: can't unset "et_cache(ia32,value)": no such element in array >>>>>>>> ERROR: can't unset "et_cache(ia32,value)": no such element in array >>>>>>>> ERROR: can't unset "et_cache(ia32,value)": no such element in array >>>>>>>> ERROR: can't unset "et_cache(ia32,value)": no such element in array >>>>>>>> ERROR: can't unset "et_cache(ilp32,value)": no such element in arr= ay >>>>>>>> ERROR: can't unset "et_cache(ilp32,value)": no such element in arr= ay >>>>>>>> ERROR: can't unset "et_cache(ilp32,value)": no such element in arr= ay >>>>>>>> ERROR: can't unset "et_cache(ilp32,value)": no such element in arr= ay >>>>>>>> ERROR: can't unset "et_cache(label_values,value)": no such element= in array >>>>>>>> ERROR: can't unset "et_cache(lp64,value)": no such element in array >>>>>>>> ERROR: can't unset "et_cache(lp64,value)": no such element in array >>>>>>>> ERROR: can't unset "et_cache(lp64,value)": no such element in array >>>>>>>> ERROR: can't unset "et_cache(ptr32plus,value)": no such element in= array >>>>>>>> ERROR: can't unset "et_cache(ptr32plus,value)": no such element in= array >>>>>>>> ... >>>>>>>> >>>>>>>> on Linux/x86-64: >>>>>>>> >>>>>>>> https://gcc.gnu.org/ml/gcc-testresults/2015-09/msg00167.html >>>>>>>> >>>>>>> >>>>>>> I'll have a look. >>>>>>> That's the configuration I used to check before committing, but I am >>>>>>> going to re-check. >>>>>> >>>>>> proc check_cached_effective_target { prop args } { >>>>>> global et_cache >>>>>> global et_prop_list >>>>>> >>>>>> set target [current_target_name] >>>>>> if {![info exists et_cache($prop,target)] >>>>>> || $et_cache($prop,target) !=3D $target} { >>>>>> verbose "check_cached_effective_target $prop: checking $targ= et" 2 >>>>>> set et_cache($prop,target) $target >>>>>> set et_cache($prop,value) [uplevel eval $args] >>>>>> lappend et_prop_list $prop >>>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >>>>>> >>>>>> Aren't you appending $pop to et_prop_list even if it may be already >>>>>> on the list? >>>>>> >>>>>> verbose "check_cached_effective_target cached list is now: >>>>>> $et_prop_list" 2 >>>>>> } >>>>>> set value $et_cache($prop,value) >>>>>> verbose "check_cached_effective_target $prop: returning $value f= or >>>>>> $target" 2 >>>>>> return $value >>>>>> } >>>>>> >>>>> >>>>> Like this? >>>>> >>>>> -- >>>>> H.J. >>>>> --- >>>>> diff --git a/gcc/testsuite/lib/target-supports.exp >>>>> b/gcc/testsuite/lib/target-supports.exp >>>>> index aad45f9..a6c16fe 100644 >>>>> --- a/gcc/testsuite/lib/target-supports.exp >>>>> +++ b/gcc/testsuite/lib/target-supports.exp >>>>> @@ -125,7 +125,9 @@ proc check_cached_effective_target { prop args } { >>>>> verbose "check_cached_effective_target $prop: checking $target" 2 >>>>> set et_cache($prop,target) $target >>>>> set et_cache($prop,value) [uplevel eval $args] >>>>> - lappend et_prop_list $prop >>>>> + if {[lsearch $et_prop_list $prop] < 0} { >>>>> + lappend et_prop_list $prop >>>>> + } >>>>> verbose "check_cached_effective_target cached list is now: $et_prop= _list" 2 >>>>> } >>>>> set value $et_cache($prop,value) >>>> >>>> >>>> It should be >>>> >>>> if {![info exists et_prop_list] >>>> || [lsearch $et_prop_list $prop] < 0} { >>>> lappend et_prop_list $prop >>>> } >>>> >>> >>> Here is a patch. OK for trunk? >>> >> >> It makes sense, indeed, although I still haven't managed to reproduce >> the issue you reported. > > The failure is random with parallel check on machines with >=3D 8 cores. > In fact that's because you are running the testsuite with several values for 'target' (unix and unix/-m32), which indeed result in appending $prop twice. Thanks > > -- > H.J.