From: Christophe Lyon <christophe.lyon@linaro.org>
To: Alan Lawrence <alan.lawrence@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 12/14][ARM/AArch64 Testsuite] Update advsimd-intrinsics tests to add float16 vectors
Date: Mon, 25 May 2015 12:37:00 -0000 [thread overview]
Message-ID: <CAKdteOahWsO4XE09nL6HhJVfV8v3BwhFTy1FajvOsTX0-4LhYA@mail.gmail.com> (raw)
In-Reply-To: <5537DAFA.8060909@arm.com>
On 22 April 2015 at 19:31, Alan Lawrence <alan.lawrence@arm.com> wrote:
> This is a fairly straightforward addition of a new type: I've added it in on
> equal status to the other types, because the various
> vector-load/store/element-manipulating intrinsics, are *not* conditional on
> HW support. (They just involve moving 16-bit chunks around, just like
> s16/u16/p16).
>
> Thus, for many tests, this just involves adding default "expected" values of
> { 0x3333 ...}. While there are indeed more of such "default" values for
> float16x4/8 than any other type (because there are fewer intrinsics), there
> are plenty others, so this seems consistent. However, there is no vdup_n_f16
> intrinsic so I worked around this using a macro (yes, a bit ugh).
I have recently checked-in a cleanup patch to remove all these default
"expected values" of 0x3333, so you'll have to rework your patch.
Sorry for not catching this earlier.
Christophe.
>
> There are many check_GNU_style.sh violations here but I tried to be
> consistent with the existing code.
>
> Passing on arm-none-linux-gnueabihf and aarch64-none-linux-gnu,
> aarch64_be-none-elf (following previous patch)
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h (hfloat16_t,
> vdup_n_f16): New.
> (result, expected, CHECK_RESULTS, CHECK_RESULTS_NAMED,
> clean_results):
> Add float16x4 and float16x8 cases.
>
> DECL_VARIABLE_64BITS_VARIANTS: Add float16x4 case.
> DECL_VARIABLE_128BITS_VARIANTS: Add float16x8 case.
>
> * gcc.target/aarch64/advsimd-intrinsics/compute-data-ref.h (buffer,
> buffer_pad, buffer_dup, buffer_dup_pad): Add float16x4 and
> float16x8.
>
> * gcc.target/aarch64/advsimd-intrinsics/vaba.c: Add expected results
> for float16x4 and float16x8.
> * gcc.target/aarch64/advsimd-intrinsics/vabal.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vabd.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vabdl.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vabs.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vadd.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vaddl.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vaddw.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vand.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vbic.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vbsl.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vcls.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vclz.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vcnt.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vdup-vmov.c: Likewise.
>
> * gcc.target/aarch64/advsimd-intrinsics/vcombine.c: Add expected
> results for float16x4 and float16x8.
> (main): add test of float16x4 -> float16x8 case.
> * gcc.target/aarch64/advsimd-intrinsics/vcreate.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vdup_lane.c: Likewise.
next prev parent reply other threads:[~2015-05-25 11:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 16:54 [PATCH 0/14][ARM/AArch64] __FP16 support, vectors, intrinsics, testsuite Alan Lawrence
2015-04-22 16:58 ` [PATCH 1/14][ARM] Add float16x4_t intrinsics Alan Lawrence
2015-04-22 16:59 ` [PATCH 4/14][ARM] Remaining float16 intrinsics: vld..., vst..., vget_low|high, vcombine Alan Lawrence
2015-04-22 16:59 ` [PATCH 3/14][ARM] Add float16x8_t intrinsics Alan Lawrence
2015-04-22 16:59 ` [PATCH 2/14][ARM]Add float16x8_t type Alan Lawrence
2015-04-22 17:06 ` [PATCH 5/14][AArch64] Add basic fp16 support Alan Lawrence
2015-04-29 21:22 ` Joseph Myers
2015-05-08 12:55 ` Alan Lawrence
2015-04-22 17:11 ` [PATCH 6/14][AArch64] Add support for float16x{4,8}_t vectors/builtins Alan Lawrence
2015-04-22 17:14 ` [PATCH 7/14][AArch64] vld{2,3,4}{,_lane,_dup},vcombine,vcreate Alan Lawrence
2015-04-22 17:40 ` Alan Lawrence
2015-04-22 17:16 ` [PATCH 8/14][AArch64]Add vreinterpret, float_truncate_lo/hi, vget_low/high Alan Lawrence
2015-04-22 17:19 ` [PATCH 9/14][AArch64] vld1(q?)_dup, missing vreinterpretq intrinsics Alan Lawrence
2015-04-22 17:21 ` [PATCH 10/14][AArch64] Add vcvt(_high)?_f32_f16 intrinsics Alan Lawrence
2015-04-22 17:31 ` [PATCH 12/14][ARM/AArch64 Testsuite] Update advsimd-intrinsics tests to add float16 vectors Alan Lawrence
2015-05-25 12:37 ` Christophe Lyon [this message]
2015-04-22 17:31 ` [PATCH 11/14][fold-const.c] Fix bigendian HFmode in native_interpret_real Alan Lawrence
2015-04-22 17:36 ` [PATCH 13/14][ARM/AArch64 testsuite] Use gcc-dg-runtest in advsimd-intrinsics.exp Alan Lawrence
2015-05-25 12:43 ` Christophe Lyon
2015-05-26 16:48 ` Alan Lawrence
2015-05-26 19:12 ` Christophe Lyon
2015-05-28 10:50 ` Alan Lawrence
2015-05-28 11:53 ` Christophe Lyon
2015-05-28 12:33 ` Christophe Lyon
2015-05-28 13:57 ` Alan Lawrence
2015-04-22 17:38 ` [PATCH 14/14][ARM/AArch64 testsuite] Test float16_t vcvt_* intrinsics Alan Lawrence
2015-05-25 13:31 ` Christophe Lyon
2015-05-08 12:56 ` [PATCH 0/14][ARM/AArch64] __FP16 support, vectors, intrinsics, testsuite Alan Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKdteOahWsO4XE09nL6HhJVfV8v3BwhFTy1FajvOsTX0-4LhYA@mail.gmail.com \
--to=christophe.lyon@linaro.org \
--cc=alan.lawrence@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).