From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20840 invoked by alias); 25 May 2015 11:52:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 20826 invoked by uid 89); 25 May 2015 11:52:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f53.google.com Received: from mail-qg0-f53.google.com (HELO mail-qg0-f53.google.com) (209.85.192.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 25 May 2015 11:52:00 +0000 Received: by qgew3 with SMTP id w3so43486507qge.2 for ; Mon, 25 May 2015 04:51:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=5HMDLUzojJDaaHl60qm+PMVx0WdE2IUWFCeSYK2RgI8=; b=fGSVoICoy52xP/X9jj3asmfqdGbmZUJTRwqYXmwll3B5iPbJn1QHHRKRke5SUSUR2U bO6wGLBLHY3uRS2c+OFJU2sZ+w7U9rHmIZYexwKiGbOqvvnAhZxTt0Z+LwocR+oa1QSd 93jVArtAaES0lVnjQD2L5slCACoccBeo2SkTSVwxPjFtrx29l3RVf+3wtidz6ABSMqc9 g8XmuBuNUEnOPVot799mlYBIAUst+aZgFo8W21/UAwLRWg13XEXozs8sq0Aah+EVyfjR oMrbUHLfLkf5v2DIx7UcpkBGGY3XinW42XR6S4IqFea79/hTLlVSsyrW1JW0BD5V1zDK ypLg== X-Gm-Message-State: ALoCoQmlgmxK3oz2Dp9vUI0dhAdrVV1/EuzQy6TU4LlJ12ABr02hCXDTjyUSVXH1TiECY29gvMsd MIME-Version: 1.0 X-Received: by 10.55.26.167 with SMTP id l39mr43302870qkh.4.1432554716794; Mon, 25 May 2015 04:51:56 -0700 (PDT) Received: by 10.140.102.164 with HTTP; Mon, 25 May 2015 04:51:56 -0700 (PDT) In-Reply-To: <5537DAFA.8060909@arm.com> References: <5537D241.1000606@arm.com> <5537DAFA.8060909@arm.com> Date: Mon, 25 May 2015 12:37:00 -0000 Message-ID: Subject: Re: [PATCH 12/14][ARM/AArch64 Testsuite] Update advsimd-intrinsics tests to add float16 vectors From: Christophe Lyon To: Alan Lawrence Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg02240.txt.bz2 On 22 April 2015 at 19:31, Alan Lawrence wrote: > This is a fairly straightforward addition of a new type: I've added it in on > equal status to the other types, because the various > vector-load/store/element-manipulating intrinsics, are *not* conditional on > HW support. (They just involve moving 16-bit chunks around, just like > s16/u16/p16). > > Thus, for many tests, this just involves adding default "expected" values of > { 0x3333 ...}. While there are indeed more of such "default" values for > float16x4/8 than any other type (because there are fewer intrinsics), there > are plenty others, so this seems consistent. However, there is no vdup_n_f16 > intrinsic so I worked around this using a macro (yes, a bit ugh). I have recently checked-in a cleanup patch to remove all these default "expected values" of 0x3333, so you'll have to rework your patch. Sorry for not catching this earlier. Christophe. > > There are many check_GNU_style.sh violations here but I tried to be > consistent with the existing code. > > Passing on arm-none-linux-gnueabihf and aarch64-none-linux-gnu, > aarch64_be-none-elf (following previous patch) > > gcc/testsuite/ChangeLog: > > * gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h (hfloat16_t, > vdup_n_f16): New. > (result, expected, CHECK_RESULTS, CHECK_RESULTS_NAMED, > clean_results): > Add float16x4 and float16x8 cases. > > DECL_VARIABLE_64BITS_VARIANTS: Add float16x4 case. > DECL_VARIABLE_128BITS_VARIANTS: Add float16x8 case. > > * gcc.target/aarch64/advsimd-intrinsics/compute-data-ref.h (buffer, > buffer_pad, buffer_dup, buffer_dup_pad): Add float16x4 and > float16x8. > > * gcc.target/aarch64/advsimd-intrinsics/vaba.c: Add expected results > for float16x4 and float16x8. > * gcc.target/aarch64/advsimd-intrinsics/vabal.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vabd.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vabdl.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vabs.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vadd.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vaddl.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vaddw.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vand.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vbic.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vbsl.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vcls.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vclz.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vcnt.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vdup-vmov.c: Likewise. > > * gcc.target/aarch64/advsimd-intrinsics/vcombine.c: Add expected > results for float16x4 and float16x8. > (main): add test of float16x4 -> float16x8 case. > * gcc.target/aarch64/advsimd-intrinsics/vcreate.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vdup_lane.c: Likewise.