From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by sourceware.org (Postfix) with ESMTPS id 87CDF398600B for ; Wed, 16 Sep 2020 12:42:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 87CDF398600B Received: by mail-oi1-x244.google.com with SMTP id x14so7907893oic.9 for ; Wed, 16 Sep 2020 05:42:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZNzMx2zA1YTxBkhNXJaB6s1POCuwbgjslf7jBFiv1xw=; b=UutBQd0mjDEhTC8nNHmbhkTVJnpsmpq/I89RfQ8J37GUq1jKqNB4D4EIOG6Ni9/X4U uc30CyuDcKBZomGYSEI9WzI2QKemszxLOALS6jaKnRzG0Unu05rrUWsHvaVYpyDjkGnM zbGYjeRvcqfT+5kFGYBUC49GPYmT1XSYHwwiJWk+PUdKaaQgySSpI56epOWQGrICrioe fljs7rwgJWuB20At2/oWPq8USzC5m46DzROhK/0n6aSpvlNRsyGioMOSXLXto0F+mGyT Rstr5Rc6ZAV9Cn3cRIwlXaX13NV+g6f9APC6wwumwiJPn8FAndE0nUxVyXGDFd8swH/0 NnWQ== X-Gm-Message-State: AOAM533XNSYkJl1yMjZVbMo4HS0qzVTZF9vSk2ouCA3urRxzxm9fpvuN oCrB5DMEXj0cGqj638fklL+XZm+5xcVzUjtXDx+8SQ== X-Google-Smtp-Source: ABdhPJwuXbW0BErfIRHGTio0i+FUnWplDuA6cXddx+JaA3UlDbnvZp/iUDVq1WnATm8bspgpUAr2TozEa53brevU/as= X-Received: by 2002:aca:cc05:: with SMTP id c5mr2849341oig.64.1600260167845; Wed, 16 Sep 2020 05:42:47 -0700 (PDT) MIME-Version: 1.0 References: <8639966E-3140-4A79-A0D4-0F35E20AD6BA@amazon.com> In-Reply-To: <8639966E-3140-4A79-A0D4-0F35E20AD6BA@amazon.com> From: Christophe Lyon Date: Wed, 16 Sep 2020 14:42:37 +0200 Message-ID: Subject: Re: [aarch64] Backport missing NEON intrinsics to GCC8 To: "Pop, Sebastian" Cc: Kyrylo Tkachov , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Sep 2020 12:42:49 -0000 On Wed, 16 Sep 2020 at 07:21, Pop, Sebastian via Gcc-patches wrote: > > Thanks Kyrill for your review. > > I committed the patches to the gcc-8 branch: > https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommitdiff;h=3D2c55e6caa9432b2c1= f081cb3aeddd36abec03233 > https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommit;h=3Da4004f62d60ada3a20dbf= 30146ca461047a575cc > > and to the gcc-9 branch: > https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommit;h=3Dc5aca0333b723d5e20366= 593cd01047d105f54e4 > > Sebastian > Hi Sebastian, The new tests vld1x3 and vld1x4 fail on arm, I am seeing new failures on gcc-8 and gcc-9 branches after r8-10451, r8-10452 and r9-8874. Is that expected/fixed later in the backport series? (on the release branches, my validations are running for every commit) Thanks, Christophe > =EF=BB=BFOn 9/15/20, 7:46 AM, "Kyrylo Tkachov" w= rote: > > Hi Sebastian, > > This patch implements missing intrinsics. > I'm okay with this being applied to the GCC 8 branch as these intrins= ics have been defined in ACLE for a long time. > It is arguably a bug that they've been missing from GCC8. > Their implementation is fairly self-contained we haven't had any bugs= reported against these in my recollection. > > So ok on the grounds that it's a bug-fix. > Thanks, > Kyrill > > From: Pop, Sebastian > Sent: 11 September 2020 20:54 > To: gcc-patches@gcc.gnu.org; Kyrylo Tkachov > Subject: [aarch64] Backport missing NEON intrinsics to GCC8 > > Hi, > > gcc-8 branch is missing NEON intrinsics for loads and stores. > Attached patches pass bootstrap and regression testing on Graviton2 a= arch64-linux. > > Ok to commit to gcc-8 branch? > > Thanks, > Sebastian >