From: Christophe Lyon <christophe.lyon@linaro.org>
To: Tamar Christina <Tamar.Christina@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, nd <nd@arm.com>,
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Subject: Re: [GCC][PATCH][ARM][Committed] Disable sdiv_1 test on softfloat targets.
Date: Tue, 13 Jun 2017 08:41:00 -0000 [thread overview]
Message-ID: <CAKdteOatNQAXDAo9GN=cthDGRnx3Ja7HtryJfiNR=Cp3qvU8PA@mail.gmail.com> (raw)
In-Reply-To: <VI1PR0801MB20318725438A6DE6BBE20C65FFC20@VI1PR0801MB2031.eurprd08.prod.outlook.com>
On 13 June 2017 at 10:31, Tamar Christina <Tamar.Christina@arm.com> wrote:
> Hi Christophe,
>
>> > gcc/testsuite/
>> > 2017-06-12 Tamar Christina <tamar.christina@arm.com>
>> >
>> > * gcc.target/arm/sdiv_costs_1.c: Require arm_v8_vfp_ok.
>> >
>>
>> I think you forgot to add a dg-add-options directive, to add -march=armv8-a
>> or similar.
>
> Weird, is it still failing? When I tested it was skipping one configuration and executing the rest.
>
> arm_v8_vfp_ok is supposed to add -mfpu=fp-armv8. When I tried it with dg-add-options it didn't
> work because it kept adding more options after the -march=armv8-a and reverting it back to armv7.
>
dg-require-effective-target arm_v8_vfp_ok checks if there is a
combination of options to enable
the support for arm v8 vfp. In my log, I can see the arm_v8_vfp_ok
sample code was compiled
with -mfpu=fp-armv8 -mfloat-abi=softfp (on an arm-none-linux-gnueabi toolchain),
but you still need to add dg-add-options, otherwise the testcase is compiled
with -O3 only, (so *without* -mfpu=fp-armv8), and scan-assembler-times fail.
> The only way I found that seemed to work was skipping the test if not supported.
>
> In principle all I really need to know is if the target has a hardware div, but
> check_effective_target_arm_divmod_simode did not seem to work.
>
>>
>> Christophe
>>
>> > Thanks,
>> > Tamar
>> > ________________________________________
>> > From: gcc-patches-owner@gcc.gnu.org <gcc-patches-owner@gcc.gnu.org>
>> on
>> > behalf of Tamar Christina <Tamar.Christina@arm.com>
>> > Sent: Monday, June 12, 2017 1:35:08 PM
>> > To: GCC Patches
>> > Cc: nd; Kyrylo Tkachov; Richard Earnshaw; Ramana Radhakrishnan
>> > Subject: [GCC][PATCH][ARM][Committed] Disable sdiv_1 test on softfloat
>> targets.
>> >
>> > Hi All,
>> >
>> > I committed this as r249122 under the GCC obvious rule.
>> >
>> > This fixes the failing test gcc.target/arm/sdiv_costs_1.c on soft
>> > float targets by disabling it on those targets since the div calls aren't
>> expanded.
>> >
>> > gcc/testsuite/
>> > 2017-06-12 Tamar Christina <tamar.christina@arm.com>
>> >
>> > * gcc.target/arm/sdiv_costs_1.c: Disable on softfloat.
>> >
>> > Thanks,
>> > Tamar
next prev parent reply other threads:[~2017-06-13 8:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 12:35 Tamar Christina
2017-06-12 13:27 ` Tamar Christina
2017-06-13 7:57 ` Christophe Lyon
2017-06-13 8:31 ` Tamar Christina
2017-06-13 8:41 ` Christophe Lyon [this message]
2017-06-13 10:10 ` Tamar Christina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKdteOatNQAXDAo9GN=cthDGRnx3Ja7HtryJfiNR=Cp3qvU8PA@mail.gmail.com' \
--to=christophe.lyon@linaro.org \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Tamar.Christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).