From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11369 invoked by alias); 13 Jun 2017 08:41:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11352 invoked by uid 89); 13 Jun 2017 08:41:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-ua0-f178.google.com Received: from mail-ua0-f178.google.com (HELO mail-ua0-f178.google.com) (209.85.217.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jun 2017 08:41:47 +0000 Received: by mail-ua0-f178.google.com with SMTP id h39so71174406uaa.3 for ; Tue, 13 Jun 2017 01:41:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=y9SrPbgWOeG9MyAaWnhDshPuVHvbnt3G02OREooqQZ8=; b=NNzqMZo1ICzsAK47qJdgzC7rsaOKyU60n/24GMUcp/9zSV/LgWOZnPKauAfM8eVVhN k1X0pYYIn5o6FAj3FQfK1foyoHK/eMVSc6wHcy4UM/QzjhfuqK8F2o5goJugBCUC8q2k VJknOup0y7YhYJfLnEmVtc+h78KX8jTHjdWuv6Cbz/n1LVIIxIM964bXENd/yTk5QbEi J+7hBiCOhR4DlR/pjBLyODUqoUDzk0V1jWoCD0A+kzlr5LdBB6v7QGKGYh6Szo4hjvDf lLfRdTm9LtjPI166f8ZksDejsZHwTJ1S8wNLsdWW7LGAUn5usjFt41a8EQg+PWi2aiJx uR5w== X-Gm-Message-State: AKS2vOxh36pNLzqotPA2vSZ2r3+/vgDxMgT7V+3Molk7mG4yTMlXYGQI xg5pqTwjExQ0EyP4UOMt1OLEaq6IWRZZ4HXxQg== X-Received: by 10.176.28.28 with SMTP id a28mr1660618uaj.38.1497343309824; Tue, 13 Jun 2017 01:41:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.50.131 with HTTP; Tue, 13 Jun 2017 01:41:49 -0700 (PDT) In-Reply-To: References: From: Christophe Lyon Date: Tue, 13 Jun 2017 08:41:00 -0000 Message-ID: Subject: Re: [GCC][PATCH][ARM][Committed] Disable sdiv_1 test on softfloat targets. To: Tamar Christina Cc: GCC Patches , nd , Kyrylo Tkachov , Richard Earnshaw , Ramana Radhakrishnan Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00873.txt.bz2 On 13 June 2017 at 10:31, Tamar Christina wrote: > Hi Christophe, > >> > gcc/testsuite/ >> > 2017-06-12 Tamar Christina >> > >> > * gcc.target/arm/sdiv_costs_1.c: Require arm_v8_vfp_ok. >> > >> >> I think you forgot to add a dg-add-options directive, to add -march=armv8-a >> or similar. > > Weird, is it still failing? When I tested it was skipping one configuration and executing the rest. > > arm_v8_vfp_ok is supposed to add -mfpu=fp-armv8. When I tried it with dg-add-options it didn't > work because it kept adding more options after the -march=armv8-a and reverting it back to armv7. > dg-require-effective-target arm_v8_vfp_ok checks if there is a combination of options to enable the support for arm v8 vfp. In my log, I can see the arm_v8_vfp_ok sample code was compiled with -mfpu=fp-armv8 -mfloat-abi=softfp (on an arm-none-linux-gnueabi toolchain), but you still need to add dg-add-options, otherwise the testcase is compiled with -O3 only, (so *without* -mfpu=fp-armv8), and scan-assembler-times fail. > The only way I found that seemed to work was skipping the test if not supported. > > In principle all I really need to know is if the target has a hardware div, but > check_effective_target_arm_divmod_simode did not seem to work. > >> >> Christophe >> >> > Thanks, >> > Tamar >> > ________________________________________ >> > From: gcc-patches-owner@gcc.gnu.org >> on >> > behalf of Tamar Christina >> > Sent: Monday, June 12, 2017 1:35:08 PM >> > To: GCC Patches >> > Cc: nd; Kyrylo Tkachov; Richard Earnshaw; Ramana Radhakrishnan >> > Subject: [GCC][PATCH][ARM][Committed] Disable sdiv_1 test on softfloat >> targets. >> > >> > Hi All, >> > >> > I committed this as r249122 under the GCC obvious rule. >> > >> > This fixes the failing test gcc.target/arm/sdiv_costs_1.c on soft >> > float targets by disabling it on those targets since the div calls aren't >> expanded. >> > >> > gcc/testsuite/ >> > 2017-06-12 Tamar Christina >> > >> > * gcc.target/arm/sdiv_costs_1.c: Disable on softfloat. >> > >> > Thanks, >> > Tamar