From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21620 invoked by alias); 8 Jan 2013 16:24:38 -0000 Received: (qmail 21603 invoked by uid 22791); 8 Jan 2013 16:24:35 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-ob0-f173.google.com (HELO mail-ob0-f173.google.com) (209.85.214.173) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Jan 2013 16:24:21 +0000 Received: by mail-ob0-f173.google.com with SMTP id xn12so640833obc.32 for ; Tue, 08 Jan 2013 08:24:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=mEnmZu2KieczeZev8GaowP+zmvbRxdaxal06xQoKbOc=; b=fUlIMsQ3Rqzp+r3Pwjc00Tn8r+AGUXF8KkNjTmcG+86J2fHDMI8cB92adITS9w7yoY itzExhu3G1TygrQSvPwg+Dbx9RKw1waDqcvdLC9DxK/qHfI/Vl43HhIQ2hpdb3TXfz5r 3QR7vbIthZdDjlqgMU3XKuyINXnfodUHn+C7U+uuqf13fuGgwPwznmph/OWtSrxT545M AIqOa3hKjBqeZwMcGhuMvMeMXsI5EQ0nxzpGVbuESoQTaUWXyp5GvXe5Zk4SusPsrs8D F/ox2jT1uPCONGIvS65lUyHwQwlnDXxRYG6UKC/FYbgYH3H3cPmfNOIxVUYGiKEDlyqP 8yig== MIME-Version: 1.0 Received: by 10.182.39.9 with SMTP id l9mr45868695obk.32.1357662260924; Tue, 08 Jan 2013 08:24:20 -0800 (PST) Received: by 10.60.115.67 with HTTP; Tue, 8 Jan 2013 08:24:20 -0800 (PST) In-Reply-To: References: <50CF366B.2060405@arm.com> Date: Tue, 08 Jan 2013 16:24:00 -0000 Message-ID: Subject: Re: [ARM] Turning off 64bits ops in Neon and gfortran/modulo-scheduling problem From: Christophe Lyon To: Richard Earnshaw Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQktNLDw3RGABctBbhfzj19jmHP7NTryNxfmwQvdVWnR3nxGD2oX4WUW39IdF5NWBX26HilF X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00424.txt.bz2 Ping? http://gcc.gnu.org/ml/gcc-patches/2012-12/msg01197.html Thanks, Christophe On 19 December 2012 16:59, Christophe Lyon wrote: > On 17 December 2012 16:12, Richard Earnshaw wrote: >> On 29/11/12 17:16, Christophe Lyon wrote: >>> On trunk I have noticed a regression in gfortran when using modulo >>> scheduling: sms-1.f90 now fails, but I suspect it's not because of >>> this patch since forcing compilation for armv5t makes the same test >>> fail with and without my patch. >>> >> >> Hmm, that's worrying. Could you please makesure this is recorded in >> bugzilla. If this is a regression, please mark it as such. >> > I was about to do so, but after bisecting it turns out that the > problem was introduced by > http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=192969 and is very > likely to be another instance of PR55562, which has just been fixed > by http://gcc.gnu.org/ml/gcc-patches/2012-12/msg01137.html. > > >> >> Now that this optimization is disabled by default, the onlya8 code is >> completely redundant and should be purged, along with the insn alternatives >> that used it. >> >> R. >> > Here is a new version of my patch, with the cleanup you requested. > > 2012-12-18 Christophe Lyon > > gcc/ > * config/arm/arm-protos.h (tune_params): Add > prefer_neon_for_64bits field. > * config/arm/arm.c (prefer_neon_for_64bits): New variable. > (arm_slowmul_tune): Default prefer_neon_for_64bits to false. > (arm_fastmul_tune, arm_strongarm_tune, arm_xscale_tune): Ditto. > (arm_9e_tune, arm_v6t2_tune, arm_cortex_tune): Ditto. > (arm_cortex_a5_tune, arm_cortex_a15_tune): Ditto. > (arm_cortex_a9_tune, arm_fa726te_tune): Ditto. > (arm_option_override): Handle -mneon-for-64bits new option. > * config/arm/arm.h (TARGET_PREFER_NEON_64BITS): New macro. > (prefer_neon_for_64bits): Declare new variable. > * config/arm/arm.md (arch): Rename neon_onlya8 and neon_nota8 to > avoid_neon_for_64bits and neon_for_64bits. Remove onlya8 and > nota8. > (arch_enabled): Handle new arch types. Remove support for onlya8 > and nota8. > (one_cmpldi2): Use new arch names. > * config/arm/arm.opt (mneon-for-64bits): Add option. > * config/arm/neon.md (adddi3_neon, subdi3_neon, iordi3_neon) > (anddi3_neon, xordi3_neon, ashldi3_neon, di3_neon): Use > neon_for_64bits instead of nota8 and avoid_neon_for_64bits instead > of onlya8. > * doc/invoke.texi (-mneon-for-64bits): Document. > > gcc/testsuite/ > * gcc.target/arm/neon-for-64bits-1.c: New tests. > * gcc.target/arm/neon-for-64bits-2.c: Likewise.