From: Christophe Lyon <christophe.lyon@linaro.org>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
Cc: Marek Polacek <polacek@redhat.com>,
Gcc Patch List <gcc-patches@gcc.gnu.org>,
"Joseph S. Myers" <joseph@codesourcery.com>,
Jason Merrill <jason@redhat.com>
Subject: Re: [PATCH c/c++] use explicit locations for some warnings in c-pragma.c
Date: Mon, 21 Sep 2015 00:24:00 -0000 [thread overview]
Message-ID: <CAKdteOb0ZsF26pctO+ObqoqEXZmCHk2cwjnQvX5K9BRYRrtH5A@mail.gmail.com> (raw)
In-Reply-To: <CAESRpQCe5=ih8-kw-kMg7v+rxLHbfdr3VtGAfbyyPFJ=Fez+aQ@mail.gmail.com>
On 20 September 2015 at 23:40, Manuel López-Ibáñez
<lopezibanez@gmail.com> wrote:
> On 20 September 2015 at 22:32, Christophe Lyon
> <christophe.lyon@linaro.org> wrote:
>> On 25 May 2015 at 22:16, Manuel López-Ibáñez <lopezibanez@gmail.com> wrote:
>>> On 25 May 2015 at 21:56, Marek Polacek <polacek@redhat.com> wrote:
>>>> Perhaps we should introduce GCC_BAD_LOC with a location_t argument and use it
>>>> here.
>>>
>>> Why would we want to obfuscate code like that? I would propose to
>>> actually remove GCC_BAD completely.
>>>
>> Hi
>> It looks like this patch has finally been committed on 2015-09-18
>> (r227923), right?
>
> Yes, I had almost forgotten about it.
>
>> I'm not sure why, since the 1st warning is xfail.
>
> Strange that I missed this, but I can see it now. (Well, not so
> strange, contrib/compare_tests sometimes produces nonsense)
>
> Could you try with this patch? It seems to work for me. I'll commit it
> as obvious if it works for you too.
>
> Index: gcc/testsuite/gcc.dg/pragma-diag-5.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/pragma-diag-5.c (revision 227932)
> +++ gcc/testsuite/gcc.dg/pragma-diag-5.c (working copy)
> @@ -1,6 +1,7 @@
> /* { dg-do compile } */
> -#pragma GCC diagnostic /* { dg-warning "24:missing" "missing" { xfail
> *-*-* } } */
> +#pragma GCC diagnostic /* { dg-warning "missing" "missing" } */
> +/* { dg-warning "24:missing" "missing" { xfail *-*-* } 2 } */
It works for me if I replace 24 by 62.
Christophe.
>
> #pragma GCC diagnostic warn /* { dg-warning "24:expected" } */
>
> #pragma GCC diagnostic ignored "-Wfoo" /* { dg-warning "32:unknown" } */
>
> Cheers,
>
> Manuel.
next prev parent reply other threads:[~2015-09-21 0:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 17:47 Manuel López-Ibáñez
2015-05-25 19:48 ` Jason Merrill
2015-05-25 20:17 ` Marek Polacek
2015-05-25 20:55 ` Manuel López-Ibáñez
2015-09-20 20:38 ` Christophe Lyon
2015-09-20 22:35 ` Manuel López-Ibáñez
2015-09-21 0:24 ` Christophe Lyon [this message]
2015-09-21 0:29 ` Manuel López-Ibáñez
2015-09-21 0:33 ` Christophe Lyon
2015-09-21 1:46 ` Manuel López-Ibáñez
2015-09-21 5:50 ` Christophe Lyon
2015-09-21 12:32 ` Manuel López-Ibáñez
2015-11-04 9:46 ` Mike Stump
2015-11-04 21:02 ` Manuel López-Ibáñez
2015-11-06 21:16 ` Mike Stump
2015-11-06 21:18 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKdteOb0ZsF26pctO+ObqoqEXZmCHk2cwjnQvX5K9BRYRrtH5A@mail.gmail.com \
--to=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=lopezibanez@gmail.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).