From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122385 invoked by alias); 24 Nov 2015 15:23:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 122370 invoked by uid 89); 24 Nov 2015 15:23:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f52.google.com Received: from mail-qg0-f52.google.com (HELO mail-qg0-f52.google.com) (209.85.192.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 24 Nov 2015 15:23:28 +0000 Received: by qgeb1 with SMTP id b1so12618694qge.1 for ; Tue, 24 Nov 2015 07:23:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=W9rniz4dMZt/+kolBVs4oaMQU9+UmOW/S2hgXjIp+pE=; b=SM0VlxAf+wLtX1H6oCDgLwkGLAWeAGNr+fe9uroIrHhWsya94WV6p7tB+puxRqUWlH 9RWZN16NukI8rrO1RDENLTlnMDcaL9LBJJDUaIOg8uPpqX4/A2f+HcvZA64WMMXDLZyo 4lz1NoB0UamIDU9S3wFW0HI9bqpZD/PMS7MKeyGrct4YAc3yapgKV/MHdPzcbn+r/KJO NitacFeUrirtc3fcmsVmkKACKeRYv8lFB9EIcYYWPXLeedX3SnGxmfLNJjOKtee8hlpm 8Po+IBULJvk27heR8FpH2ESiV6eM8fhzt9aW2szg6gtKaeqrKsfYhkKHJEAt7Kj3skvZ vT9Q== X-Gm-Message-State: ALoCoQmDYCSha4gredxgEgtr5gqp5weKXjDtuNtDcavoCKwB2k8LxzUjrQXPacTc5vv1k4Z1Q8gY MIME-Version: 1.0 X-Received: by 10.140.17.105 with SMTP id 96mr34340752qgc.34.1448378605926; Tue, 24 Nov 2015 07:23:25 -0800 (PST) Received: by 10.140.109.200 with HTTP; Tue, 24 Nov 2015 07:23:25 -0800 (PST) In-Reply-To: References: <56337FD6.5040602@foss.arm.com> <5645C879.7090406@arm.com> Date: Tue, 24 Nov 2015 15:25:00 -0000 Message-ID: Subject: Re: [PATCH] [ARM] neon-testgen.ml typo From: Christophe Lyon To: Kyrill Tkachov Cc: Ramana Radhakrishnan , Ramana Radhakrishnan , Jim Wilson , "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary=001a11c0dd964ef28005254aec9d X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg02923.txt.bz2 --001a11c0dd964ef28005254aec9d Content-Type: text/plain; charset=UTF-8 Content-length: 1861 On 13 November 2015 at 14:36, Christophe Lyon wrote: > On 13 November 2015 at 12:24, Kyrill Tkachov wrote: >> >> On 13/11/15 11:18, Ramana Radhakrishnan wrote: >>>> >>>> Hmm. I hadn't noticed that the crypto intrinsics tests where generated by >>>> neon-testgen.ml, I thought they were hand-written. >>>> The tests I added do not cover the crypto intrinsics, so I'm going >>>> to revert r230274 and restore all the tests generated by neon-testgen.ml >>>> until we have better coverage in advsimd-intrinsics. >>> >>> From what I remember from a few days back I thought it was generally >>> ok to get rid of the lot as we had test coverage for everything else >>> in gcc.target/arm . >>> >>> Thus don't bother reverting. >> >> >> +1. I'll also add that you can now remove neon.ml from config/arm. > > Sorry, I felt so guilty that I reverted the removal already. > >> And also, I think we can move the remaining hand-written tests from >> gcc.target/arm/neon/ >> into gcc.target/arm/ and remove the neon/ directory altogether. >> > I'll give a deeper look at all that, and will try not to rush to meet > e/o stage1 deadline :-) > I've given a look at this in more detail. I've attached the list of intrinsics that would no longer be tested after removing the tests generated by neon-testgen.ml. They are mostly p64 and p128, as well as: - p8/p16 vreinterpretq. Not sure why they are not in my tests. - vrnd* - vtst[q]_p8. Not sure why they are not in my tests So there is a bit of work to create new tests before removing the ml-generated ones. Christophe >> Kyrill >> >> >>> >>> Ramana >>> >>>> Sorry for the oversight. >>>> >>>> Christophe. >>>> >>>> >>>>> Christophe. >>>>> >>>>>>> regards >>>>>>> Ramana >>>>>>> >>>>>>> >>>>>>> >>>>>>>> Christophe. >>>>>>>> >>>>>>>>> regards >>>>>>>>> Ramana >> >> --001a11c0dd964ef28005254aec9d Content-Type: text/plain; charset=US-ASCII; name="neon-not-covered-after-cleanup.txt" Content-Disposition: attachment; filename="neon-not-covered-after-cleanup.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ihdj82700 Content-length: 3034 dmJzbHFfcDY0CnZic2xfcDY0CnZjb21iaW5lX3A2NAp2Y3JlYXRlX3A2NAp2 ZHVwcV9sYW5lX3A2NAp2ZHVwcV9uX3A2NAp2ZHVwX2xhbmVfcDY0CnZkdXBf bl9wNjQKdmdldF9sb3dfcDY0CnZsZDFxX2R1cF9wNjQKdmxkMXFfbGFuZV9w NjQKdmxkMXFfcDY0CnZsZDFfZHVwX3A2NAp2bGQxX2xhbmVfcDY0CnZsZDFf cDY0CnZsZDJfZHVwX3A2NAp2bGQyX3A2NAp2bGQzX2R1cF9wNjQKdmxkM19w NjQKdmxkNF9kdXBfcDY0CnZsZDRfcDY0CnZyZWludGVycHJldHFfZjMyX3Ax MjgKdnJlaW50ZXJwcmV0cV9mMzJfcDY0CnZyZWludGVycHJldHFfcDEyOF9m MzIKdnJlaW50ZXJwcmV0cV9wMTI4X3AxNgp2cmVpbnRlcnByZXRxX3AxMjhf cDY0CnZyZWludGVycHJldHFfcDEyOF9wOAp2cmVpbnRlcnByZXRxX3AxMjhf czE2CnZyZWludGVycHJldHFfcDEyOF9zMzIKdnJlaW50ZXJwcmV0cV9wMTI4 X3M2NAp2cmVpbnRlcnByZXRxX3AxMjhfczgKdnJlaW50ZXJwcmV0cV9wMTI4 X3UxNgp2cmVpbnRlcnByZXRxX3AxMjhfdTMyCnZyZWludGVycHJldHFfcDEy OF91NjQKdnJlaW50ZXJwcmV0cV9wMTI4X3U4CnZyZWludGVycHJldHFfcDE2 X3AxMjgKdnJlaW50ZXJwcmV0cV9wMTZfcDY0CnZyZWludGVycHJldHFfcDE2 X3A4CnZyZWludGVycHJldHFfcDE2X3MxNgp2cmVpbnRlcnByZXRxX3AxNl9z MzIKdnJlaW50ZXJwcmV0cV9wMTZfczY0CnZyZWludGVycHJldHFfcDE2X3M4 CnZyZWludGVycHJldHFfcDE2X3UxNgp2cmVpbnRlcnByZXRxX3AxNl91MzIK dnJlaW50ZXJwcmV0cV9wMTZfdTY0CnZyZWludGVycHJldHFfcDE2X3U4CnZy ZWludGVycHJldHFfcDY0X2YzMgp2cmVpbnRlcnByZXRxX3A2NF9wMTI4CnZy ZWludGVycHJldHFfcDY0X3AxNgp2cmVpbnRlcnByZXRxX3A2NF9wOAp2cmVp bnRlcnByZXRxX3A2NF9zMTYKdnJlaW50ZXJwcmV0cV9wNjRfczMyCnZyZWlu dGVycHJldHFfcDY0X3M2NAp2cmVpbnRlcnByZXRxX3A2NF9zOAp2cmVpbnRl cnByZXRxX3A2NF91MTYKdnJlaW50ZXJwcmV0cV9wNjRfdTMyCnZyZWludGVy cHJldHFfcDY0X3U2NAp2cmVpbnRlcnByZXRxX3A2NF91OAp2cmVpbnRlcnBy ZXRxX3A4X3AxMjgKdnJlaW50ZXJwcmV0cV9wOF9wMTYKdnJlaW50ZXJwcmV0 cV9wOF9wNjQKdnJlaW50ZXJwcmV0cV9wOF9zMTYKdnJlaW50ZXJwcmV0cV9w OF9zMzIKdnJlaW50ZXJwcmV0cV9wOF9zNjQKdnJlaW50ZXJwcmV0cV9wOF9z OAp2cmVpbnRlcnByZXRxX3A4X3UxNgp2cmVpbnRlcnByZXRxX3A4X3UzMgp2 cmVpbnRlcnByZXRxX3A4X3U2NAp2cmVpbnRlcnByZXRxX3A4X3U4CnZyZWlu dGVycHJldHFfczE2X3AxMjgKdnJlaW50ZXJwcmV0cV9zMTZfcDY0CnZyZWlu dGVycHJldHFfczMyX3AxMjgKdnJlaW50ZXJwcmV0cV9zMzJfcDY0CnZyZWlu dGVycHJldHFfczY0X3AxMjgKdnJlaW50ZXJwcmV0cV9zNjRfcDY0CnZyZWlu dGVycHJldHFfczhfcDEyOAp2cmVpbnRlcnByZXRxX3M4X3A2NAp2cmVpbnRl cnByZXRxX3UxNl9wMTI4CnZyZWludGVycHJldHFfdTE2X3A2NAp2cmVpbnRl cnByZXRxX3UzMl9wMTI4CnZyZWludGVycHJldHFfdTMyX3A2NAp2cmVpbnRl cnByZXRxX3U2NF9wMTI4CnZyZWludGVycHJldHFfdTY0X3A2NAp2cmVpbnRl cnByZXRxX3U4X3AxMjgKdnJlaW50ZXJwcmV0cV91OF9wNjQKdnJlaW50ZXJw cmV0X2YzMl9wNjQKdnJlaW50ZXJwcmV0X3AxNl9wNjQKdnJlaW50ZXJwcmV0 X3A2NF9mMzIKdnJlaW50ZXJwcmV0X3A2NF9wMTYKdnJlaW50ZXJwcmV0X3A2 NF9wOAp2cmVpbnRlcnByZXRfcDY0X3MxNgp2cmVpbnRlcnByZXRfcDY0X3Mz Mgp2cmVpbnRlcnByZXRfcDY0X3M2NAp2cmVpbnRlcnByZXRfcDY0X3M4CnZy ZWludGVycHJldF9wNjRfdTE2CnZyZWludGVycHJldF9wNjRfdTMyCnZyZWlu dGVycHJldF9wNjRfdTgKdnJlaW50ZXJwcmV0X3A4X3A2NAp2cmVpbnRlcnBy ZXRfczE2X3A2NAp2cmVpbnRlcnByZXRfczMyX3A2NAp2cmVpbnRlcnByZXRf czY0X3A2NAp2cmVpbnRlcnByZXRfczhfcDY0CnZyZWludGVycHJldF91MTZf cDY0CnZyZWludGVycHJldF91NjRfcDY0CnZyZWludGVycHJldF91OF9wNjQK dnJuZGFfZjMyCnZybmRhcV9mMzIKdnJuZF9mMzIKdnJuZG1fZjMyCnZybmRt cV9mMzIKdnJuZG5fZjMyCnZybmRucV9mMzIKdnJuZHBfZjMyCnZybmRwcV9m MzIKdnJuZHFfZjMyCnZzbGlxX25fcDY0CnZzbGlfbl9wNjQKdnNyaXFfbl9w NjQKdnNyaV9uX3A2NAp2dHN0cV9wOAp2dHN0X3A4Cg== --001a11c0dd964ef28005254aec9d--