* [PATCH][ARM] Fix test fail with conflicting -mfloat-abi
@ 2018-01-12 14:46 Sudakshina Das
2018-01-12 18:34 ` Christophe Lyon
0 siblings, 1 reply; 5+ messages in thread
From: Sudakshina Das @ 2018-01-12 14:46 UTC (permalink / raw)
To: gcc-patches
Cc: nd, Kyrill Tkachov, Ramana Radhakrishnan, Richard Earnshaw,
Christophe Lyon
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
Hi
This patch fixes my earlier test case that fails for arm-none-eabi
with explicit user option for -mfloat-abi which conflict with
the test case options. I have added a guard to skip the test
on those cases.
@Christophe:
Sorry about this. I think this should fix the test case.
Can you please confirm if this works for you?
Thanks
Sudi
gcc/testsuite/ChangeLog
2018-01-12 Sudakshina Das <sudi.das@arm.com>
* gcc.c-torture/compile/pr82096.c: Add dg-skip-if
directive.
[-- Attachment #2: fix-test.diff --]
[-- Type: text/x-patch, Size: 491 bytes --]
diff --git a/gcc/testsuite/gcc.c-torture/compile/pr82096.c b/gcc/testsuite/gcc.c-torture/compile/pr82096.c
index 9fed28c..759d390 100644
--- a/gcc/testsuite/gcc.c-torture/compile/pr82096.c
+++ b/gcc/testsuite/gcc.c-torture/compile/pr82096.c
@@ -1,3 +1,4 @@
+/* { dg-skip-if "Do not combine float-abi values" { arm*-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */
/* { dg-additional-options "-march=armv5t -mthumb -mfloat-abi=soft" { target arm*-*-* } } */
static long long AL[24];
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][ARM] Fix test fail with conflicting -mfloat-abi
2018-01-12 14:46 [PATCH][ARM] Fix test fail with conflicting -mfloat-abi Sudakshina Das
@ 2018-01-12 18:34 ` Christophe Lyon
2018-01-16 10:37 ` Sudakshina Das
0 siblings, 1 reply; 5+ messages in thread
From: Christophe Lyon @ 2018-01-12 18:34 UTC (permalink / raw)
To: Sudi Das
Cc: gcc Patches, nd, Kyrill Tkachov, Ramana Radhakrishnan, Richard Earnshaw
Le 12 janv. 2018 15:26, "Sudakshina Das" <sudi.das@arm.com> a écrit :
Hi
This patch fixes my earlier test case that fails for arm-none-eabi
with explicit user option for -mfloat-abi which conflict with
the test case options. I have added a guard to skip the test
on those cases.
@Christophe:
Sorry about this. I think this should fix the test case.
Can you please confirm if this works for you?
Yes it does thanks
Thanks
Sudi
gcc/testsuite/ChangeLog
2018-01-12 Sudakshina Das <sudi.das@arm.com>
* gcc.c-torture/compile/pr82096.c: Add dg-skip-if
directive.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][ARM] Fix test fail with conflicting -mfloat-abi
2018-01-12 18:34 ` Christophe Lyon
@ 2018-01-16 10:37 ` Sudakshina Das
2018-01-19 18:06 ` Kyrill Tkachov
0 siblings, 1 reply; 5+ messages in thread
From: Sudakshina Das @ 2018-01-16 10:37 UTC (permalink / raw)
To: Christophe Lyon
Cc: gcc Patches, nd, Kyrill Tkachov, Ramana Radhakrishnan, Richard Earnshaw
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
Hi Christophe
On 12/01/18 18:32, Christophe Lyon wrote:
> Le 12 janv. 2018 15:26, "Sudakshina Das" <sudi.das@arm.com> a écrit :
>
> Hi
>
> This patch fixes my earlier test case that fails for arm-none-eabi
> with explicit user option for -mfloat-abi which conflict with
> the test case options. I have added a guard to skip the test
> on those cases.
>
> @Christophe:
> Sorry about this. I think this should fix the test case.
> Can you please confirm if this works for you?
>
>
> Yes it does thanks
Thanks for checking that. I have added one more directive for armv5t as
well to avoid any conflicts for mcpu options.
Sudi
>
>
> Thanks
> Sudi
>
> gcc/testsuite/ChangeLog
>
> 2018-01-12 Sudakshina Das <sudi.das@arm.com>
>
> * gcc.c-torture/compile/pr82096.c: Add dg-skip-if
> directive.
>
[-- Attachment #2: fix-test.diff --]
[-- Type: text/x-patch, Size: 546 bytes --]
diff --git a/gcc/testsuite/gcc.c-torture/compile/pr82096.c b/gcc/testsuite/gcc.c-torture/compile/pr82096.c
index 9fed28c..35551f5 100644
--- a/gcc/testsuite/gcc.c-torture/compile/pr82096.c
+++ b/gcc/testsuite/gcc.c-torture/compile/pr82096.c
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target arm_arch_v5t_ok } */
+/* { dg-skip-if "Do not combine float-abi values" { arm*-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */
/* { dg-additional-options "-march=armv5t -mthumb -mfloat-abi=soft" { target arm*-*-* } } */
static long long AL[24];
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][ARM] Fix test fail with conflicting -mfloat-abi
2018-01-16 10:37 ` Sudakshina Das
@ 2018-01-19 18:06 ` Kyrill Tkachov
2018-01-22 11:36 ` Sudakshina Das
0 siblings, 1 reply; 5+ messages in thread
From: Kyrill Tkachov @ 2018-01-19 18:06 UTC (permalink / raw)
To: Sudakshina Das, Christophe Lyon
Cc: gcc Patches, nd, Ramana Radhakrishnan, Richard Earnshaw
On 16/01/18 10:31, Sudakshina Das wrote:
> Hi Christophe
>
> On 12/01/18 18:32, Christophe Lyon wrote:
>> Le 12 janv. 2018 15:26, "Sudakshina Das" <sudi.das@arm.com> a écrit :
>>
>> Hi
>>
>> This patch fixes my earlier test case that fails for arm-none-eabi
>> with explicit user option for -mfloat-abi which conflict with
>> the test case options. I have added a guard to skip the test
>> on those cases.
>>
>> @Christophe:
>> Sorry about this. I think this should fix the test case.
>> Can you please confirm if this works for you?
>>
>>
>> Yes it does thanks
>
> Thanks for checking that. I have added one more directive for armv5t as well to avoid any conflicts for mcpu options.
>
I agree with what Sudi said in https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01422.html
I'd rather keep the test in the generic torture suite as long as we get the directives right.
So this is ok for trunk (as the changes are arm-specific directives) with one change below:
Thanks,
Kyrill
> Sudi
>
>>
>>
>> Thanks
>> Sudi
>>
>> gcc/testsuite/ChangeLog
>>
>> 2018-01-12 Sudakshina Das <sudi.das@arm.com>
>>
>> * gcc.c-torture/compile/pr82096.c: Add dg-skip-if
>> directive.
>>
>
diff --git a/gcc/testsuite/gcc.c-torture/compile/pr82096.c b/gcc/testsuite/gcc.c-torture/compile/pr82096.c
index 9fed28c..35551f5 100644
--- a/gcc/testsuite/gcc.c-torture/compile/pr82096.c
+++ b/gcc/testsuite/gcc.c-torture/compile/pr82096.c
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target arm_arch_v5t_ok } */
Please also guard this on { target arm*-*-* }
That way this test will be run on other targets as well so that they can benefit from it.
+/* { dg-skip-if "Do not combine float-abi values" { arm*-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */
/* { dg-additional-options "-march=armv5t -mthumb -mfloat-abi=soft" { target arm*-*-* } } */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][ARM] Fix test fail with conflicting -mfloat-abi
2018-01-19 18:06 ` Kyrill Tkachov
@ 2018-01-22 11:36 ` Sudakshina Das
0 siblings, 0 replies; 5+ messages in thread
From: Sudakshina Das @ 2018-01-22 11:36 UTC (permalink / raw)
To: Kyrill Tkachov, Christophe Lyon
Cc: gcc Patches, nd, Ramana Radhakrishnan, Richard Earnshaw
Hi Kyrill
On 19/01/18 18:00, Kyrill Tkachov wrote:
>
> On 16/01/18 10:31, Sudakshina Das wrote:
>> Hi Christophe
>>
>> On 12/01/18 18:32, Christophe Lyon wrote:
>>> Le 12 janv. 2018 15:26, "Sudakshina Das" <sudi.das@arm.com> a écrit :
>>>
>>> Hi
>>>
>>> This patch fixes my earlier test case that fails for arm-none-eabi
>>> with explicit user option for -mfloat-abi which conflict with
>>> the test case options. I have added a guard to skip the test
>>> on those cases.
>>>
>>> @Christophe:
>>> Sorry about this. I think this should fix the test case.
>>> Can you please confirm if this works for you?
>>>
>>>
>>> Yes it does thanks
>>
>> Thanks for checking that. I have added one more directive for armv5t
>> as well to avoid any conflicts for mcpu options.
>>
>
> I agree with what Sudi said in
> https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01422.html
> I'd rather keep the test in the generic torture suite as long as we get
> the directives right.
>
> So this is ok for trunk (as the changes are arm-specific directives)
> with one change below:
>
> Thanks,
> Kyrill
>
>> Sudi
>>
>>>
>>>
>>> Thanks
>>> Sudi
>>>
>>> gcc/testsuite/ChangeLog
>>>
>>> 2018-01-12 Sudakshina Das <sudi.das@arm.com>
>>>
>>> Â Â Â Â Â Â Â Â * gcc.c-torture/compile/pr82096.c: Add dg-skip-if
>>> Â Â Â Â Â Â Â Â directive.
>>>
>>
>
>
> diff --git a/gcc/testsuite/gcc.c-torture/compile/pr82096.c
> b/gcc/testsuite/gcc.c-torture/compile/pr82096.c
> index 9fed28c..35551f5 100644
> --- a/gcc/testsuite/gcc.c-torture/compile/pr82096.c
> +++ b/gcc/testsuite/gcc.c-torture/compile/pr82096.c
> @@ -1,3 +1,5 @@
> +/* { dg-require-effective-target arm_arch_v5t_ok } */
>
> Please also guard this on { target arm*-*-* }
> That way this test will be run on other targets as well so that they can
> benefit from it.
>
> +/* { dg-skip-if "Do not combine float-abi values" { arm*-*-* } {
> "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */
> Â /* { dg-additional-options "-march=armv5t -mthumb -mfloat-abi=soft" {
> target arm*-*-* } } */
>
Thanks committed with the change as r256941
Sudi
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-22 10:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-12 14:46 [PATCH][ARM] Fix test fail with conflicting -mfloat-abi Sudakshina Das
2018-01-12 18:34 ` Christophe Lyon
2018-01-16 10:37 ` Sudakshina Das
2018-01-19 18:06 ` Kyrill Tkachov
2018-01-22 11:36 ` Sudakshina Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).